- 17 3月, 2015 4 次提交
-
-
由 Brandon Weiss 提交于
I’m renaming all instances of `use_transcational_fixtures` to `use_transactional_tests` and “transactional fixtures” to “transactional tests”. I’m deprecating `use_transactional_fixtures=`. So anyone who is explicitly setting this will get a warning telling them to use `use_transactional_tests=` instead. I’m maintaining backwards compatibility—both forms will work. `use_transactional_tests` will check to see if `use_transactional_fixtures` is set and use that, otherwise it will use itself. But because `use_transactional_tests` is a class attribute (created with `class_attribute`) this requires a little bit of hoop jumping. The writer method that `class_attribute` generates defines a new reader method that return the value being set. Which means we can’t set the default of `true` using `use_transactional_tests=` as was done previously because that won’t take into account anyone using `use_transactional_fixtures`. Instead I defined the reader method manually and it checks `use_transactional_fixtures`. If it was set then it should be used, otherwise it should return the default, which is `true`. If someone uses `use_transactional_tests=` then it will overwrite the backwards-compatible method with whatever they set.
-
由 Rafael Mendonça França 提交于
Move Adapter to private constant
-
由 Abdelkader Boudih 提交于
Adds more clarity on how to use custom rake tasks with arguments passed to it [ci skip]
-
由 Mohnish G J 提交于
-
- 16 3月, 2015 5 次提交
-
-
由 Semyon Pupkov 提交于
-
由 Xavier Noria 提交于
[skip ci] Fix typos in guides
-
由 Anton Davydov 提交于
-
由 Arun Agrawal 提交于
[skip ci] Fix typo in actionmailer documentation
-
由 Anton Davydov 提交于
-
- 15 3月, 2015 18 次提交
-
-
由 Arthur Nogueira Neves 提交于
[ci skip] Fix dead link
-
由 eileencodes 提交于
If there was a polymorphic hm:t association with a scope AND second non-scoped hm:t association on a model the polymorphic scope would leak through into the call for the non-polymorhic hm:t association. This would only break if `hotel.drink_designers` was called before `hotel.recipes`. If `hotel.recipes` was called first there would be no problem with the SQL. Before (employable_type should not be here): ``` SELECT COUNT(*) FROM "drink_designers" INNER JOIN "chefs" ON "drink_designers"."id" = "chefs"."employable_id" INNER JOIN "departments" ON "chefs"."department_id" = "departments"."id" WHERE "departments"."hotel_id" = ? AND "chefs"."employable_type" = ? [["hotel_id", 1], ["employable_type", "DrinkDesigner"]] ``` After: ``` SELECT COUNT(*) FROM "recipes" INNER JOIN "chefs" ON "recipes"."chef_id" = "chefs"."id" INNER JOIN "departments" ON "chefs"."department_id" = "departments"."id" WHERE "departments"."hotel_id" = ? [["hotel_id", 1]] ``` From the SQL you can see that `employable_type` was leaking through when calling recipes. The solution is to dup the chain of the polymorphic association so it doesn't get cached. Additionally, this follows `scope_chain` which dup's the `source_reflection`'s `scope_chain`. This required another model/table/relationship because the leak only happens on a hm:t polymorphic that's called before another hm:t on the same model. I am specifically testing the SQL here instead of the number of records becasue the test could pass if there was 1 drink designer recipe for the drink designer chef even though the `employable_type` was leaking through. This needs to specifically check that `employable_type` is not in the SQL statement.
-
由 Andrew White 提交于
add mailer suffix to comments for email previews
-
由 Claudio B. 提交于
[ci skip]Doc fix about association hierarchy
-
由 keepcosmos 提交于
-
由 yuuji.yaginuma 提交于
-
由 Carlos Antonio da Silva 提交于
Cleaning actionview tests
-
由 Arun Agrawal 提交于
Fix typo in Action Pack changelog
-
由 Mike Naberezny 提交于
-
由 Thiago Pradi 提交于
-
由 Thiago Pradi 提交于
-
由 Thiago Pradi 提交于
-
由 Thiago Pradi 提交于
-
由 Thiago Pradi 提交于
-
由 Arthur Nogueira Neves 提交于
[ci skip] Subject-verb agreement
-
由 Joel Brewer 提交于
-
由 Arthur Neves 提交于
-
- 14 3月, 2015 3 次提交
-
-
由 Rafael Mendonça França 提交于
Asserting partials modification
-
由 Rafael Mendonça França 提交于
Add `rake initializer`
-
由 Naoto Kaneko 提交于
This task prints out initializers for an application. It is useful to develop a rubygem which involves the initialization process.
-
- 13 3月, 2015 10 次提交
-
-
由 Christian Ress 提交于
Closes #19321. [ci skip]
-
由 Andrew Hendrie 提交于
Changed "create Articles view" to "new article view". The create action doesn't typically have a view assigned to it. The view that's being referred to is the 'new' Article view.
-
由 Rafael Mendonça França 提交于
Return truthy value from head method
-
由 Rafael Mendonça França 提交于
`QueueAdapters` now does lazy lookup
-
由 Rafael Mendonça França 提交于
Update sprockets links to point to rails org
-
由 Joshua Peek 提交于
-
由 Abdelkader Boudih 提交于
[ci skip] correct output of select
-
由 Tamir Duberstein 提交于
-
由 Kuldeep Aggarwal 提交于
-
由 Joel Hayhurst 提交于
It was returning false in normal circumstances. This broke the `head :ok and return if` construct. Add appropriate test.
-