1. 09 11月, 2015 1 次提交
    • Y
      Deprecate `#table_exists?`, `#tables` and passing arguments to `#talbes` · 7429633b
      yui-knk 提交于
      Reported on #21509, how views is treated by `#tables` are differ
      by each adapters. To fix this different behavior, after Rails 5.0
      is released, deprecate `#tables`.
      
      And `#table_exists?` would check both tables and views.
      To make their behavior consistent with `#tables`, after Rails 5.0
      is released, deprecate `#table_exists?`.
      7429633b
  2. 02 11月, 2015 1 次提交
  3. 20 9月, 2015 1 次提交
  4. 18 9月, 2015 1 次提交
    • R
      Add `unsigned` support for numeric data types in MySQL · f3772f72
      Ryuta Kamizono 提交于
      Example:
      
          create_table :foos do |t|
            t.integer :unsigned_integer, unsigned: true
            t.bigint  :unsigned_bigint,  unsigned: true
            t.float   :unsigned_float,   unsigned: true
            t.decimal :unsigned_decimal, unsigned: true, precision: 10, scale: 2
          end
      f3772f72
  5. 22 5月, 2015 1 次提交
  6. 19 5月, 2015 1 次提交
  7. 31 3月, 2015 1 次提交
    • K
      use Model.reset_column_information to clear table cache connection wide. · bf6a33fd
      Kuldeep Aggarwal 提交于
          `widgets` table is being created in `primary_keys_test.rb` for PostgreSQLAdapter, MysqlAdapter, Mysql2Adapter
          and it makes test to fail earlier.
      
          Before:
            `bundle exec rake mysql2:test`
      
          ```
          Finished in 127.287669s, 35.5258 runs/s, 97.8885 assertions/s.
      
            1) Error:
          PersistenceTest::SaveTest#test_save_touch_false:
          ActiveModel::UnknownAttributeError: unknown attribute 'name' for #<Class:0x0000000a7d6ef0>.
              /home/kd/projects/kd-rails/activerecord/lib/active_record/attribute_assignment.rb:36:in `rescue in _assign_attribute'
              /home/kd/projects/kd-rails/activerecord/lib/active_record/attribute_assignment.rb:34:in `_assign_attribute'
              /home/kd/projects/kd-rails/activemodel/lib/active_model/attribute_assignment.rb:40:in `block in _assign_attributes'
              /home/kd/projects/kd-rails/activemodel/lib/active_model/attribute_assignment.rb:39:in `each'
              /home/kd/projects/kd-rails/activemodel/lib/active_model/attribute_assignment.rb:39:in `_assign_attributes'
              /home/kd/projects/kd-rails/activerecord/lib/active_record/attribute_assignment.rb:26:in `_assign_attributes'
              /home/kd/projects/kd-rails/activemodel/lib/active_model/attribute_assignment.rb:33:in `assign_attributes'
              /home/kd/projects/kd-rails/activerecord/lib/active_record/core.rb:293:in `initialize'
              /home/kd/projects/kd-rails/activerecord/lib/active_record/inheritance.rb:61:in `new'
              /home/kd/projects/kd-rails/activerecord/lib/active_record/inheritance.rb:61:in `new'
              /home/kd/projects/kd-rails/activerecord/lib/active_record/persistence.rb:50:in `create!'
              /home/kd/projects/kd-rails/activerecord/test/cases/persistence_test.rb:913:in `test_save_touch_false'
      
          4522 runs, 12460 assertions, 0 failures, 1 errors, 4 skips
          ```
      
          After:
            `bundle exec rake mysql2:test`
      
          ```
             Finished in 135.785086s, 33.3026 runs/s, 91.7774 assertions/s.
      
             4522 runs, 12462 assertions, 0 failures, 0 errors, 4 skips
          ```
      bf6a33fd
  8. 17 3月, 2015 1 次提交
    • B
      Closes rails/rails#18864: Renaming transactional fixtures to transactional tests · 09658635
      Brandon Weiss 提交于
      I’m renaming all instances of `use_transcational_fixtures` to
      `use_transactional_tests` and “transactional fixtures” to
      “transactional tests”.
      
      I’m deprecating `use_transactional_fixtures=`. So anyone who is
      explicitly setting this will get a warning telling them to use
      `use_transactional_tests=` instead.
      
      I’m maintaining backwards compatibility—both forms will work.
      `use_transactional_tests` will check to see if
      `use_transactional_fixtures` is set and use that, otherwise it will use
      itself. But because `use_transactional_tests` is a class attribute
      (created with `class_attribute`) this requires a little bit of hoop
      jumping. The writer method that `class_attribute` generates defines a
      new reader method that return the value being set. Which means we can’t
      set the default of `true` using `use_transactional_tests=` as was done
      previously because that won’t take into account anyone using
      `use_transactional_fixtures`. Instead I defined the reader method
      manually and it checks `use_transactional_fixtures`. If it was set then
      it should be used, otherwise it should return the default, which is
      `true`. If someone uses `use_transactional_tests=` then it will
      overwrite the backwards-compatible method with whatever they set.
      09658635
  9. 24 2月, 2015 1 次提交
  10. 18 2月, 2015 1 次提交
  11. 22 1月, 2015 1 次提交
  12. 29 12月, 2014 1 次提交
  13. 28 12月, 2014 2 次提交
  14. 07 8月, 2014 1 次提交
  15. 26 6月, 2014 1 次提交
  16. 06 6月, 2014 1 次提交
  17. 24 5月, 2014 1 次提交
    • S
      Remove `Column#primary` · 05dd3df3
      Sean Griffin 提交于
      It appears to have been used at some point in the past, but is no longer
      used in any meaningful way. Whether a column is considered primary is
      a property of the model, not the schema/column. This also removes the
      need for yet another layer of caching of the model's schema, and we can
      leave that to the schema cache.
      05dd3df3
  18. 12 5月, 2014 1 次提交
    • P
      Handle other pk types in PostgreSQL gracefully. · c0a12453
      Patrick Robertson 提交于
      In #10410 it was noted that you can no longer create PK's with the
      type of bigserial in PostgreSQL in 4.0.0.rc1. This is mostly
      because the newer adapter is checking for column type with the
      id column instead of just letting it pass through like it did
      before.
      
      Side effects:
      You may just create a PK column of a type that you really don't
      want to be your PK. As far as I can tell this was allowed in 3.2.X
      and perhaps an exception should be raised if you try and do
      something extremely dumb.
      c0a12453
  19. 05 2月, 2014 1 次提交
  20. 09 11月, 2013 1 次提交
  21. 08 11月, 2013 1 次提交
  22. 12 5月, 2013 1 次提交
  23. 08 5月, 2013 1 次提交
  24. 07 5月, 2013 1 次提交
    • P
      Handle other pk types in PostgreSQL gracefully. · 0e00c6b2
      Patrick Robertson 提交于
      In #10410 it was noted that you can no longer create PK's with the
      type of bigserial in PostgreSQL in 4.0.0.rc1. This is mostly
      because the newer adapter is checking for column type with the
      id column instead of just letting it pass through like it did
      before.
      
      Side effects:
      You may just create a PK column of a type that you really don't
      want to be your PK. As far as I can tell this was allowed in 3.2.X
      and perhaps an exception should be raised if you try and do
      something extremely dumb.
      0e00c6b2
  25. 18 1月, 2013 2 次提交
  26. 02 1月, 2013 1 次提交
  27. 02 12月, 2012 2 次提交
  28. 26 10月, 2012 1 次提交
    • J
      Remove ActiveRecord::Model · 9e4c41c9
      Jon Leighton 提交于
      In the end I think the pain of implementing this seamlessly was not
      worth the gain provided.
      
      The intention was that it would allow plain ruby objects that might not
      live in your main application to be subclassed and have persistence
      mixed in. But I've decided that the benefit of doing that is not worth
      the amount of complexity that the implementation introduced.
      9e4c41c9
  29. 12 2月, 2012 1 次提交
  30. 11 2月, 2012 1 次提交
  31. 31 1月, 2012 1 次提交
  32. 29 12月, 2011 1 次提交
  33. 16 12月, 2011 1 次提交
  34. 15 12月, 2011 1 次提交
  35. 02 12月, 2011 1 次提交
    • J
      Add test for read_attribute(:id) with non-standard PK. · e9fb6d04
      Jon Leighton 提交于
      Also make it actually work.
      
      It slows down all read_attribute accesses to map 'id' to whatever the PK
      actually is, inside read_attribute. So instead make sure the necessary
      methods are defined and that they redirect wherever they need to go.
      e9fb6d04
  36. 30 11月, 2011 1 次提交
  37. 06 10月, 2011 1 次提交