- 14 2月, 2019 1 次提交
-
-
由 eileencodes 提交于
In chat Sam Saffron asked how to use the setter now that configurations is no longer a hash and you need to do AR::Base.configurations["test"]=. Technically you can do `ActiveRecord::Base.configurations = { the hash }` but I realized the old way throws an error and is unintuitive. To aid in the transition from hashes to objects this PR makes a few changes: 1) Re-adds a deprecated hash setter `[]=` that will add a new hash to the configurations list OR replace an existing hash if that environment is already present. This won't be supported in future Rails versions but a good error is important. 2) Changed to throw deprecation warnings on the methods we decided to support for hash conversion and raise on the methods we don't support. 3) Refactored the setter/getter hash deprecation warnings messages and rewrote them. Getters message: ``` DEPRECATION WARNING: `ActiveRecord::Base.configurations` no longer returns a hash. Methods that act on the hash like `values` are deprecated and will be removed in Rails 6.1. Use the `configs_for` method to collect and iterate over the database configurations. ``` Setter message: ``` DEPRECATION WARNING: Setting `ActiveRecord::Base.configurations` with `[]=` is deprecated. Use `ActiveRecord::Base.configurations=` directly to set the configurations instead. ``` 4) Rewrote the legacy configurations test file to test all the public methods in the DatabaseConfigurations class.
-
- 11 2月, 2019 13 次提交
-
-
由 Gannon McGibbon 提交于
Clarify collection proxy docs
-
由 Ryuta Kamizono 提交于
This reverts commit b46601b5, reversing changes made to 4e6737f1.
-
由 Ryuta Kamizono 提交于
-
由 Eileen M. Uchitelle 提交于
Correct JavaScript guide example
-
由 Matthew Draper 提交于
Avoid extra package install
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
SQLite3: Implement `add_foreign_key` and `remove_foreign_key`
-
由 Ryuta Kamizono 提交于
This reverts commit 141f50ef, reversing changes made to 317efa5c. Reason: `add_foreign_key` and `remove_foreign_key` are implemented at #35212. [ci skip]
-
由 Ryuta Kamizono 提交于
I implemented Foreign key create in `create_table` for SQLite3 at #24743. This follows #24743 to implement `add_foreign_key` and `remove_foreign_key`. Unfortunately SQLite3 has one limitation that `PRAGMA foreign_key_list(table-name)` doesn't have constraint name. So we couldn't implement find/remove foreign key by name for now. Fixes #35207. Closes #31343.
-
由 Ryuta Kamizono 提交于
-
由 yuuji.yaginuma 提交于
Some tests are running yarn install during the test. The directory used for isolation test is not subject to yarn workspace, and it occurs because the required package is not installed. In order to avoid this, I fixed all necessary packages to be installed before run test and use symlink to `node_modules`. This is a bit complicated, as `yarn install` needs to be run in a specific directory before running the test. However, running `yarn install` every time run the test is expensive when testing locally and should be avoided.
-
由 Yuji Yaginuma 提交于
This reverts commit 38f9e41f, reversing changes made to 5e493c3b. Reason: The ajv@6.9.1 was released that fixes issue.
-
由 Charlie Jonas 提交于
Swap `#users` jQuery selector to correct position and prevent the escaping of HTML.
-
- 10 2月, 2019 6 次提交
-
-
由 Yuji Yaginuma 提交于
Avoid ajv@6.9.0 for now
-
由 yuuji.yaginuma 提交于
Because ajv@6.9.0 does not work with webpack. Ref: https://github.com/epoberezkin/ajv/issues/941
-
由 Ryuta Kamizono 提交于
Do not allow to add column without column name
-
由 Aaron Patterson 提交于
Fix memory leaks in development
-
由 Hiroyuki Morita 提交于
-
- 09 2月, 2019 12 次提交
-
-
由 Ryuta Kamizono 提交于
It makes to ease to handle all short-hand methods (e.g. validates arguments etc).
-
由 yuuji.yaginuma 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
This commit exposes all system wide view paths so that we can clear their caches.
-
由 Aaron Patterson 提交于
This commit splits the digest cache from the "details identity" cache. Now both caches can be managed independently.
-
由 Ryuta Kamizono 提交于
`object.transform_values!` returns `object` itself.
-
由 Kasper Timm Hansen 提交于
-
由 Guillermo Iguaran 提交于
-
由 Guillermo Iguaran 提交于
-
由 Gannon McGibbon 提交于
The docs for `ActiveRecord::Associations::CollectionProxy` describe `ActiveRecord::Associations::Association`. I've moved them to association and rewrote collection proxy's docs to be more applicable to what the class actually does.` [ci skip]
-
由 Ryuta Kamizono 提交于
`Association#target=` invokes `loaded!`, so we no longer need to call the `loaded!` explicitly. Since Preloader is private API, we don't guarantee that it behaves like older version as long as using Preloader directly. But this refactoring fortunately also fix the Preloader compatibility issue #35195. Closes #35195.
-
- 08 2月, 2019 8 次提交
-
-
由 Kasper Timm Hansen 提交于
Fix elapsed time calculations
-
由 Ryuta Kamizono 提交于
Fix `relation.exists?` with giving both `distinct` and `offset`
-
由 Ryuta Kamizono 提交于
Bugfix has_many association #size when ids reader is cached and assoc…
-
由 bogdanvlviv 提交于
I've found a few places in Rails code base where I think it makes sense to calculate elapsed time more precisely by using `Concurrent.monotonic_time`: - Fix calculation of elapsed time in `ActiveSupport::Cache::MemoryStore#prune` - Fix calculation of elapsed time in `ActiveRecord::ConnectionAdapters::ConnectionPool::Queue#wait_poll` - Fix calculation of elapsed time in `ActiveRecord::ConnectionAdapters::ConnectionPool#attempt_to_checkout_all_existing_connections` - Fix calculation of elapsed time in `ActiveRecord::ConnectionAdapters::Mysql2Adapter#explain` See https://docs.ruby-lang.org/en/2.5.0/Process.html#method-c-clock_gettime https://blog.dnsimple.com/2018/03/elapsed-time-with-ruby-the-right-way Related to 7c454214
-
由 Ryuta Kamizono 提交于
The `distinct` affects (reduces) rows of the result, so it is important part when both `distinct` and `offset` are given. Replacing SELECT clause to `1 AS one` and removing `distinct` and `order` is just optimization for the `exists?`, we should not apply the optimization for that case. Fixes #35191.
-
由 Bogdan Gusiev 提交于
-
由 Ryuta Kamizono 提交于
Relation is not best place to do this.
-
由 Ryuta Kamizono 提交于
Address test_belongs_to_does_not_use_order_by failure
-