- 05 12月, 2013 4 次提交
-
-
由 Godfrey Chan 提交于
-
由 Godfrey Chan 提交于
-
由 Godfrey Chan 提交于
-
由 Godfrey Chan 提交于
-
- 04 12月, 2013 10 次提交
-
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
This reads a lot better, and we won't need to try start_with? for blank delimiters. Also rename method name to read better.
-
由 Carlos Antonio da Silva 提交于
The conversion without area code already changed the passed number in place, so change the other method to do the same.
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
-
由 Dimko 提交于
-
- 03 12月, 2013 12 次提交
-
-
由 Colin Bartlett 提交于
Ruby's Date class automatically gives us #yesterday, #today, and #tomorrow. And ActiveSupport has a handy Time.zone.today for getting a localized version. But there was no localized version of #yesterday or #tomorrow. Until now.
-
由 Carlos Antonio da Silva 提交于
-
由 Nerian 提交于
Modify the Hash#assert_valid_keys error message so that it shows the valid keys. Also, show the wrong value as it was entered. { :failore => "stuff", :funny => "business" }.assert_valid_keys([ :failure, :funny ]) => ArgumentError: Unknown key: failore { 'failore' => "stuff", :funny => "business" }.assert_valid_keys([ :failure, :funny ]) => ArgumentError: Unknown key: failore { 'failore' => "stuff", :funny => "business" }.assert_valid_keys([ :failure, :funny ]) => ArgumentError: Unknown key: "failore". Valid keys are: :failure, :funny { :failore => "stuff", :funny => "business" }.assert_valid_keys([ :failure, :funny ]) => ArgumentError: Unknown key: :failore. Valid keys are: :failure, :funny Conflicts: activerecord/CHANGELOG.md Closes #11624.
-
由 Godfrey Chan 提交于
Also added the missing CHANGELOG entry for #12183 @ 80e75520 and 4d02296c.
-
由 Carlos Antonio da Silva 提交于
Use the already existing strings instead of creating a new one each time just to test if it responds to the methods.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Genadi Samokovarov 提交于
-
由 Genadi Samokovarov 提交于
-
由 Daniel Harrington 提交于
we’re using .delegate and should require it.
-
- 01 12月, 2013 1 次提交
-
-
由 Godfrey Chan 提交于
-
- 30 11月, 2013 2 次提交
-
-
由 Akshay Vishnoi 提交于
-
由 Dmitriy Kiriyenko 提交于
In Ruby 2.0.0-p353 there was a [commit](https://github.com/ruby/ruby/commit/66915c507777c5e3a978fa73de25db763efd9206) that switched case matching from actual sending `===` method to magic lookup, that does not see it in `method_missing`. It's hard to predict how exactly and when exactly this bug will be solved so here I suggest a solution of defining it in Duration directly. In Ruby 2.0.0-p353 without the added fix added test crashes to segmentation fault.
-
- 29 11月, 2013 1 次提交
-
-
由 Lauro Caetano 提交于
Improve Module#delegate documentation to tell that delegate don't work with private or protected methods. [ci skip]
-
- 28 11月, 2013 2 次提交
-
-
由 Mike Moore 提交于
Provide message to define ActiveSupport::TestCase.name instead. Allow calling describe with a block, which Minitest::Spec does.
-
由 Greg Molnar 提交于
-
- 27 11月, 2013 5 次提交
-
-
由 Godfrey Chan 提交于
The user is expected to explicitly convert the value into an AS::Duration, i.e. `5.ago` => `5.seconds.ago` This will help to catch subtle bugs like: def recent?(days = 3) self.created_at >= days.ago end The above code would check if the model is created within the last 3 **seconds**. In the future, `Numeric#{ago,until,since,from_now}` should be removed completely, or throw some sort of errors to indicate there are no implicit conversion from `Numeric` to `AS::Duration`. Also fixed & refactor the test cases for Numeric#{ago,since} and AS::Duration#{ago,since}. The original test case had the assertion flipped and the purpose of the test wasn't very clear.
-
由 Godfrey Chan 提交于
-
由 Godfrey Chan 提交于
-
由 Godfrey Chan 提交于
Got all the tests passing again. Support for `encode_json` has been removed (and consequently the ability to encode `BigDecimal`s as numbers, as mentioned in the previous commit). Install the `activesupport-json_encoder` gem to get it back.
-
由 Godfrey Chan 提交于
This is because the new encoder will no longer support encode_json. Therefore our only choice is to return `to_i` or `to_s` in `BigDecimal#as_json`. Since casting a BigDecimal to an integer is most likely a lossy operation, we chose to encode it as a string. Support for encoding BigDecimal as a string will return via the `activesupport-json_encoder` gem.
-
- 23 11月, 2013 1 次提交
-
-
由 Godfrey Chan 提交于
should also call #as_json on the children without options (instead of nil)
-
- 22 11月, 2013 1 次提交
-
-
由 Yves Senn 提交于
-
- 21 11月, 2013 1 次提交
-
-
由 Aman Gupta 提交于
-