- 19 12月, 2017 6 次提交
-
-
由 Kasper Timm Hansen 提交于
Raise an error only when `require_master_key` is specified
-
由 Kasper Timm Hansen 提交于
Update new_framework_defaults_5_2.rb.tt
-
由 George Claghorn 提交于
-
由 Anton Rieder 提交于
Be consistent in comments when mentioning AES.
-
由 Eileen M. Uchitelle 提交于
Add headless browser support in api docs [ci skip]
-
由 Pierre Hedkvist 提交于
-
- 18 12月, 2017 7 次提交
-
-
由 Eileen M. Uchitelle 提交于
Add `skip_bootsnap` option
-
由 Eileen M. Uchitelle 提交于
Clarify docs for delegate :allow_nil option
-
由 Eileen M. Uchitelle 提交于
Don't include ellipsis in truncated digest output
-
由 George Claghorn 提交于
-
由 yuuji.yaginuma 提交于
To prevent errors from being raise in environments where credentials is unnecessary. Context: https://github.com/rails/rails/issues/31283#issuecomment-348801489 Fixes #31283
-
由 Ryuta Kamizono 提交于
Looks like it is failed due to datetime rounding. Related #23521. https://travis-ci.org/rails/rails/jobs/317734560#L1980-L1984
-
由 Ryuta Kamizono 提交于
Previously table name qualified `*` is used in that case. If it is not qualified with a table name, an ambiguous column name error will occur when using JOINs.
-
- 17 12月, 2017 6 次提交
-
-
由 Xavier Noria 提交于
Thanks to @Datasnuten for the suggestion.
-
由 Prathamesh Sonpatki 提交于
-
由 Prathamesh Sonpatki 提交于
-
由 Eugene Kenny 提交于
Using `truncate` to limit the length of the digest has the unwanted side effect of adding an ellipsis when the input is longer than the limit. Also: - Don't instantiate a new object for every digest - Rename the configuration option to `hash_digest_class` - Update the CHANGELOG entry to describe how to use the feature
-
由 George Claghorn 提交于
-
由 yuuji.yaginuma 提交于
Follow up of #31391
-
- 16 12月, 2017 9 次提交
-
-
由 yuuji.yaginuma 提交于
`bootsnap` is a useful gem normally. However, `bootsnap` is unnecessary when generating a Rails application to be used only for testing. So I want to control whether use this or not by option.
-
由 Kasper Timm Hansen 提交于
Update "Active Record Associations" guide [ci skip]
-
由 Ryuta Kamizono 提交于
Fix Active Storage Overview guide [ci skip]
-
由 Yoshiyuki Hirano 提交于
-
由 yuuji.yaginuma 提交于
Currently, sidekiq integration test + Ruby 2.5.0-rc1 show exception as follows. ``` #<Thread:0x000000000670bec0@/home/travis/build/rails/rails/vendor/bundle/ruby/2.5.0/gems/sidekiq-5.0.5/lib/sidekiq/util.rb:23 run> terminated with exception (report_on_exception is true): /home/travis/build/rails/rails/vendor/bundle/ruby/2.5.0/gems/bootsnap-1.1.7/lib/bootsnap/load_path_cache/core_ext/active_support.rb:53:in `block in load_missing_constant': uninitialized constant Sidekiq::CLI (NameError) from /home/travis/build/rails/rails/vendor/bundle/ruby/2.5.0/gems/bootsnap-1.1.7/lib/bootsnap/load_path_cache/core_ext/active_support.rb:8:in `without_bootsnap_cache' from /home/travis/build/rails/rails/vendor/bundle/ruby/2.5.0/gems/bootsnap-1.1.7/lib/bootsnap/load_path_cache/core_ext/active_support.rb:53:in `rescue in load_missing_constant' from /home/travis/build/rails/rails/vendor/bundle/ruby/2.5.0/gems/bootsnap-1.1.7/lib/bootsnap/load_path_cache/core_ext/active_support.rb:42:in `load_missing_constant' from /home/travis/build/rails/rails/vendor/bundle/ruby/2.5.0/gems/sidekiq-5.0.5/lib/sidekiq/launcher.rb:65:in `heartbeat' from /home/travis/build/rails/rails/vendor/bundle/ruby/2.5.0/gems/sidekiq-5.0.5/lib/sidekiq/launcher.rb:123:in `start_heartbeat' ``` https://travis-ci.org/rails/rails/jobs/317187279#L2152 The reason for this is that `Sidekiq::CLI` has not been loaded. Sidekiq integration test launches a Sidekiq instance within another Ruby process. In such a case, need to require 'sidekiq/cli' in that launch code. Ref: https://github.com/mperham/sidekiq/pull/3692#issuecomment-352032251
-
由 George Claghorn 提交于
-
由 Claudio B 提交于
[ci skip] Use :amazon, not :s3, so that guides reflect the current code
-
由 Claudio B 提交于
The [template](https://github.com/rails/rails/blob/master/railties/lib/rails/generators/rails/app/templates/config/storage.yml.tt#L10) that generates the `config/storage.yml` file has the Amazon S3 key specified as `:amazon`, not `:s3`. The guides should reflect the nomenclature, given that every other service also has the name of the company as the key (:google, :microsoft).
-
由 Jay Hayes 提交于
-
- 15 12月, 2017 12 次提交
-
-
由 Ryuta Kamizono 提交于
Modify test to correctly pass attributes hash
-
由 George Claghorn 提交于
-
由 Chris Salzberg 提交于
-
由 Ryuta Kamizono 提交于
These are using `remove_column` directly, not used `t` in `change_table`.
-
由 Ryuta Kamizono 提交于
Like other Basics and Overview guides.
-
由 Ryuta Kamizono 提交于
Fix in ASt guide [ci skip]
-
由 Ryuta Kamizono 提交于
[ci skip] Inherit ActiveRecord::Base in example codes
-
由 Yauheni Dakuka 提交于
-
由 Yoshiyuki Hirano 提交于
-
由 yuuji.yaginuma 提交于
Currently, generation of guide is an error in `5_2_release_notes.html`. ``` $ bunele exec rake guides:generate:html Generating 5_2_release_notes.md as 5_2_release_notes.html rails/guides/rails_guides/markdown.rb:44:in `dom_id': undefined method `[]' for nil:NilClass (NoMethodError) from rails/guides/rails_guides/markdown.rb:106:in `block (2 levels) in generate_structure' ``` It seems that it is an error because there are multiple `active-storage` anchors. Since Active Storage is a Major feature, it is unnecessary to show CHANGELOGs, so remove from `Incompatibilities` section.
-
由 Ryuta Kamizono 提交于
[ci skip] Add missing **DO NOT READ THIS FILE ON GITHUB, GUIDES ARE PUBLISHED ON http://guides.rubyonrails.org.**
-
由 Ryuta Kamizono 提交于
[ci skip] update link
-