- 18 2月, 2016 8 次提交
-
-
由 Aaron Patterson 提交于
While iterating an AC::Parameters object, the object will mutate itself and stick AC::Parameters objects where there used to be hashes: https://github.com/rails/rails/blob/f57092ad728fa1de06c4f5fd9d09dcc2c4738fd9/actionpack/lib/action_controller/metal/strong_parameters.rb#L632 If you use `permit` after this iteration, the `fields_for_style` method wouldn't return true because the child objects are now AC::Parameters objects rather than Hashes. fixes #23701
-
由 Eileen M. Uchitelle 提交于
This was showing up as an H1. Fixing the indentation here fixes the codeblock.
-
由 Eileen M. Uchitelle 提交于
Remove accidentally duplicated change log title [ci skip]
-
由 Mehmet Emin İNAÇ 提交于
-
由 Aaron Patterson 提交于
we need to continue setting the body on the request object because of Fiber based streaming templates. Fixes #23659
-
由 Sean Griffin 提交于
Fixed `where` for polymorphic associations when passed an array containing different types.
-
由 Matthew Draper 提交于
Addresses #23568, Incorrect error message with accepts_nested_attributes_for / has_many & has_one
-
由 Andrew White 提交于
modify to `error` also abort when specify fail fast option
-
- 17 2月, 2016 26 次提交
-
-
由 Yves Senn 提交于
Implement ActionController::Parameters#inspect
-
由 Yves Senn 提交于
adds missing tests for Digestor#nested_dependencies
-
由 yuuji.yaginuma 提交于
-
由 Benjamin Quorning 提交于
Now that AC::Parameters is no longer a Hash, it shouldn't look like a hash.
-
由 Kasper Timm Hansen 提交于
remove unused method
-
由 yuuji.yaginuma 提交于
`app_templates_dir` is unused since dc53fe92.
-
由 Rafael França 提交于
Remove unused Journey code
-
由 Jon Moss 提交于
- `VERSION` shouldn't be there anymore since Journey is technically part of Action Dispatch now (and thus Action Pack, and follows the normal Rails versioning scheme) - `backwards.rb` was only in the file tree because early in the history or Journey (back in 2011!), it was moved from under the Rack namespace, to its own namespace, Journey! This file is no longer required, and is assigning constants that are no longer needed.
-
由 Rafael França 提交于
Show proper error message when a non-relation object is passed to AR::Relation#or
-
由 Rafael França 提交于
Add Action Cable CHANGELOG in release notes [ci skip]
-
由 Prathamesh Sonpatki 提交于
-
由 Prathamesh Sonpatki 提交于
- Previously it used to show error message <"undefined method `limit_value' for {:title=>\"Rails\"}:Hash"> - Now it shows following error message. >> Post.where.not(name: 'DHH').or(name: 'Tenderlove') ArgumentError: You have passed Hash object to #or. Pass an ActiveRecord::Relation object instead. - Fixes #23714.
-
由 Rafael França 提交于
Fix semantics of test names for finish option in batches_test
-
由 Akshay 提交于
- The change was added in #23099
-
由 Rafael Mendonça França 提交于
-
由 Rafael França 提交于
The JSON API media type should only work wih a JSON API handler
-
由 Rafael França 提交于
Test parent local_stored_attributes isn't modified
-
由 Benjamin Fleischer 提交于
Since the media type 'application/vnd.api+json' is a spec, it is inappropriate to handle it with the JSON renderer. This PR removes support for a JSON API media type. I would recommend the media type be registered on its own as `jsonapi` when a jsonapi Renderer and deserializer (Http::Parameters::DEFAULT_PARSERS) are added. Is related to work in https://github.com/rails/rails/pull/21496
-
由 Rafael Mendonça França 提交于
This change was added in #23203 and it was not conforming our code style.
-
由 Xavier Noria 提交于
-
由 Richard Schneeman 提交于
application/gzip added as default mime type into mime type list
-
由 Vipul A M 提交于
[ci skip] Updating edge rails guides to include `on_weekday?` on Date, Time and DateTime
-
由 Chirag Aggarwal 提交于
[ci skip] Adding `on_weekend?` method in edge rails guides
-
由 Richard Schneeman 提交于
WIP: Errors in logs should show log tags as well.
-
由 Philippe Huibonhoa 提交于
When passing in an array of different types of objects to `where`, it would only take into account the class of the first object in the array. PriceEstimate.where(estimate_of: [Treasure.find(1), Car.find(2)]) # => SELECT "price_estimates".* FROM "price_estimates" WHERE ("price_estimates"."estimate_of_type" = 'Treasure' AND "price_estimates"."estimate_of_id" IN (1, 2)) This is fixed to properly look for any records matching both type and id: PriceEstimate.where(estimate_of: [Treasure.find(1), Car.find(2)]) # => SELECT "price_estimates".* FROM "price_estimates" WHERE (("price_estimates"."estimate_of_type" = 'Treasure' AND "price_estimates"."estimate_of_id" = 1) OR ("price_estimates"."estimate_of_type" = 'Car' AND "price_estimates"."estimate_of_id" = 2))
-
由 David Genord II 提交于
Saw the `merge!` and had to prove to myself that the parent model's local_stored_attributes was not being changed when stored_attributes is called on a child model. Proved to be working as expected but this test is probably still useful to keep around.
-
- 16 2月, 2016 6 次提交
-
-
由 Yves Senn 提交于
Correct config option from only_api to api_only in test
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
Let t.foreign_key use the same `to_table` twice Conflicts: activerecord/CHANGELOG.md
-
由 Yves Senn 提交于
Whenever you are sending emails in integration tests using the `:test` delivery method you need to make sure that `ActionMailer::Base.deliveries` is reset after every test. This piece of boilerplate code is present in all my applications that send emails. Let's have `ActionDispatch::IntegrationTest` reset the deliveries automatically.
-
由 Yves Senn 提交于
Use a URL instead of an URL everywhere
-
由 Yves Senn 提交于
Add missing CHANGELOG for regression fix in #18155 which fixes #13387
-