This is true of the first param (url_for_options),
not of the second options param which is being
documented here.

[ci skip]

Docs for all the other form tag helpers in this
file already clarify this.

[ci skip]

Don't fight against ourselves for the default log level

Replacing an each with reduce

Define the Duration#instance_of? method

This way no new object allocation is taking place. Thanks @jeremy for
the suggestion!

Pass logging message through block.

Missing space. [CI SKIP]

This follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance

See AR::Associations for greater detail in Nested Model Forms Guide [ci skip]

[skip ci]

Patch by @bcjordan

[ci skip] Added documentation for has_and_belongs_to_many scope parameter

Revert "Add I18n support for `:placeholder` HTML option is passed to for...

ActionDispatch::RemoteIp accept IPAddr matches for trusted proxies

Per feedback in https://github.com/rails/rails/commit/af63e4a2546629c3fb2d53cffb7d4ea0e8663f68#commitcomment-7477636

The functionality has not changed, but the code is more elegant by
using `reduce` instead of `each`.

This way no accumulator needs to be declared, no explicit return is
needed.

Refactored IP address checking in ActionDispatch::RemoteIp to rely on
the IPAddr class instead of the unwieldly regular expression to match
IP addresses. This commit keeps the same api but allows users to pass
IPAddr objects to config.action_dispatch.trusted_proxies in addition
to passing strings and regular expressions.

Example:

    # config/environments/production.rb
    config.action_dispatch.trusted_proxies = IPAddr.new('4.8.15.0/16')

See http://guides.rubyonrails.org/api_documentation_guidelines.html#wording

If we want to always default to :debug, let's just do that.

At which point the production.rb entry can become an "uncomment to
change" instead.

Update documentation, Add change to ActionView Notable changes

Small Action View Overview guide grammar and readability tweaks

Fix minor typos and improve grammar and code formatting

[ci skip] Added documentation for has_one scope parameter

[ci skip] Grammar fixes for upgrade guide from 4.0 to 4.1

Related: https://github.com/rails/rails/pull/16607

[ci skip] Clarify Action Mailer/Active Job usage note

Upgrade guide pass. [CI SKIP]

Fix some issues in 4.2 release notes. [ci skip]