1. 20 3月, 2020 1 次提交
  2. 19 3月, 2020 6 次提交
  3. 18 3月, 2020 2 次提交
  4. 17 3月, 2020 12 次提交
    • X
      Merge pull request #38756 from timdorr/patch-2 · 08dfa921
      Xavier Noria 提交于
      Tiny doc fix in .validates
      08dfa921
    • T
      Tiny doc fix in .validates · 55fdf173
      Tim Dorr 提交于
      This should be a string array literal. Simple as that :)
      55fdf173
    • E
      Merge pull request #38752 from d-m-u/patch-1 · f68c1ef3
      Eileen M. Uchitelle 提交于
      Update autosave_association.rb
      f68c1ef3
    • J
      In `head`, set response body after headers. · 38ec8db3
      Jarek Radosz 提交于
      When using ActionController::Live setting content type header after response body resulted in a race condition, throwing either “ActionDispatch::IllegalStateError: header already sent” or “RuntimeError: can't modify frozen Hash”.
      This commit restores original order (i.e. from before 75757c5c).
      38ec8db3
    • D
      Update autosave_association.rb · bdfd6f11
      d-m-u 提交于
      Fix typo
      bdfd6f11
    • R
      Merge pull request #38747 from yahonda/azure_storage_blob_2 · 8520cc77
      Rafael França 提交于
      Unlock `azure-storage-blob` version to use version 2.0
      8520cc77
    • Y
      Unlock `azure-storage-blob` version to use version 2.0 · dad4026f
      Yasuo Honda 提交于
      `azure-storage-blob` 2.0.0 has been released.
      https://rubygems.org/gems/azure-storage-blob/versions/2.0.0
      
      According to this commit and changelog, `azure-storage-blob` 1.1.0 did not support Ruby 2.6 and higher.
      As of right now, Rails master branch should support Ruby 2.5.0, 2.6.0 and 2.7.0
      then it should be appropriate to unlock `azure-storage-blob` version.
      
      https://github.com/Azure/azure-storage-ruby/commit/252e3f06a5cf2e2583302bfefa95d8b25818a44f
      
      This commit addresses this following error:
      
      ```ruby
      % cd activestorage
      % bundle exec rake test
      
      Traceback (most recent call last):
      	14: from /Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rake-13.0.1/lib/rake/rake_test_loader.rb:5:in `<main>'
      	13: from /Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rake-13.0.1/lib/rake/rake_test_loader.rb:5:in `select'
      	12: from /Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rake-13.0.1/lib/rake/rake_test_loader.rb:17:in `block in <main>'
      	11: from /Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/zeitwerk-2.3.0/lib/zeitwerk/kernel.rb:23:in `require'
      	10: from /Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/zeitwerk-2.3.0/lib/zeitwerk/kernel.rb:23:in `require'
      	 9: from /Users/yahonda/src/github.com/rails/rails/activestorage/test/service/azure_storage_service_test.rb:7:in `<top (required)>'
      	 8: from /Users/yahonda/src/github.com/rails/rails/activestorage/test/service/azure_storage_service_test.rb:8:in `<class:AzureStorageServiceTest>'
      	 7: from /Users/yahonda/src/github.com/rails/rails/activestorage/lib/active_storage/service.rb:51:in `configure'
      	 6: from /Users/yahonda/src/github.com/rails/rails/activestorage/lib/active_storage/service/configurator.rb:8:in `build'
      	 5: from /Users/yahonda/src/github.com/rails/rails/activestorage/lib/active_storage/service/configurator.rb:17:in `build'
      	 4: from /Users/yahonda/src/github.com/rails/rails/activestorage/lib/active_storage/service/configurator.rb:30:in `resolve'
      	 3: from /Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/zeitwerk-2.3.0/lib/zeitwerk/kernel.rb:23:in `require'
      	 2: from /Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/zeitwerk-2.3.0/lib/zeitwerk/kernel.rb:23:in `require'
      	 1: from /Users/yahonda/src/github.com/rails/rails/activestorage/lib/active_storage/service/azure_storage_service.rb:3:in `<top (required)>'
      /Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/rubygems_integration.rb:346:in `block (2 levels) in replace_gem': can't activate azure-storage-blob (~> 1.1), already activated azure-storage-blob-2.0.0. Make sure all dependencies are added to Gemfile. (Gem::LoadError)
      	11: from /Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rake-13.0.1/lib/rake/rake_test_loader.rb:5:in `<main>'
      	10: from /Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rake-13.0.1/lib/rake/rake_test_loader.rb:5:in `select'
      	 9: from /Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rake-13.0.1/lib/rake/rake_test_loader.rb:17:in `block in <main>'
      	 8: from /Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/zeitwerk-2.3.0/lib/zeitwerk/kernel.rb:23:in `require'
      	 7: from /Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/zeitwerk-2.3.0/lib/zeitwerk/kernel.rb:23:in `require'
      	 6: from /Users/yahonda/src/github.com/rails/rails/activestorage/test/service/azure_storage_service_test.rb:7:in `<top (required)>'
      	 5: from /Users/yahonda/src/github.com/rails/rails/activestorage/test/service/azure_storage_service_test.rb:8:in `<class:AzureStorageServiceTest>'
      	 4: from /Users/yahonda/src/github.com/rails/rails/activestorage/lib/active_storage/service.rb:51:in `configure'
      	 3: from /Users/yahonda/src/github.com/rails/rails/activestorage/lib/active_storage/service/configurator.rb:8:in `build'
      	 2: from /Users/yahonda/src/github.com/rails/rails/activestorage/lib/active_storage/service/configurator.rb:17:in `build'
      	 1: from /Users/yahonda/src/github.com/rails/rails/activestorage/lib/active_storage/service/configurator.rb:29:in `resolve'
      /Users/yahonda/src/github.com/rails/rails/activestorage/lib/active_storage/service/configurator.rb:33:in `rescue in resolve': Missing service adapter for "AzureStorage" (RuntimeError)
      rake aborted!
      ```
      
      * Update Gemfile.lock to bump azure-storage-blob version
      
      ```
      % bundle update --conservative faraday azure-storage-blob google-cloud-storage`
      ```
      
      - How to find gem name to update by setting `gem "azure-storage-blob", "= 2.0.0"` temporarily
      
      ```ruby
      % git diff
      diff --git a/Gemfile b/Gemfile
      index 5fdaceab2f..6be7dccf4b 100644
      --- a/Gemfile
      +++ b/Gemfile
      @@ -84,7 +84,7 @@ end
       group :storage do
         gem "aws-sdk-s3", require: false
         gem "google-cloud-storage", "~> 1.11", require: false
      -  gem "azure-storage-blob", require: false
      +  gem "azure-storage-blob", "= 2.0.0", require: false # Use 2.0.0 temporarily to find which gems need bump
      
         gem "image_processing", "~> 1.2"
       end
      % bundle install
      Fetching gem metadata from https://rubygems.org/.........
      Fetching gem metadata from https://rubygems.org/.
      Resolving dependencies.....
      Bundler could not find compatible versions for gem "faraday":
        In snapshot (Gemfile.lock):
          faraday (= 0.17.1)
      
        In Gemfile:
          azure-storage-blob (= 2.0.0) was resolved to 2.0.0, which depends on
            azure-storage-common (~> 2.0) was resolved to 2.0.1, which depends on
              faraday (~> 1.0)
      
          google-cloud-storage (~> 1.11) was resolved to 1.25.0, which depends on
            googleauth (~> 0.9) was resolved to 0.10.0, which depends on
              faraday (~> 0.12)
      
      Running `bundle update` will rebuild your snapshot from scratch, using only
      the gems in your Gemfile, which may resolve the conflict.
      % git checkout -f Gemfile
      % bundle update --conservative faraday azure-storage-blob google-cloud-storage
      ```
      dad4026f
    • R
      Document the internal hook to build a result · f735a216
      Rafael Mendonça França 提交于
      Also change the arguments to be keyword arguments to make easier to
      evolve this method if we need to.
      f735a216
    • E
      Merge pull request #38728 from davidauza-engineer/patch-5 · 2562d133
      Eileen M. Uchitelle 提交于
      Add options examples to find_in_batches method
      2562d133
    • D
      Add options examples to find_in_batches method [ci skip] · 51954c89
      David Auza 提交于
      Update guides/source/active_record_querying.md
      Co-Authored-By: NEileen M. Uchitelle <eileencodes@users.noreply.github.com>
      
      Update guides/source/active_record_querying.md
      Co-Authored-By: NEileen M. Uchitelle <eileencodes@users.noreply.github.com>
      
      Update guides/source/active_record_querying.md
      Co-Authored-By: NEileen M. Uchitelle <eileencodes@users.noreply.github.com>
      
      Update guides/source/active_record_querying.md
      Co-Authored-By: NEileen M. Uchitelle <eileencodes@users.noreply.github.com>
      51954c89
    • R
      Merge pull request #38735 from roramirez/quoting-gemfile-app-generator · 7f39b313
      Rafael França 提交于
      Quotation mark for gems with options in Gemfile template:
      7f39b313
    • R
      Merge pull request #38743 from jbampton/imgbot · 3ee934ca
      Rafael França 提交于
      [ImgBot] Optimize images
      3ee934ca
  5. 16 3月, 2020 1 次提交
    • I
      [ImgBot] Optimize images · 4f1472d4
      ImgBotApp 提交于
      /guides/assets/images/rails_guides_logo.gif -- 3.68kb -> 2.65kb (28.06%)
      /guides/assets/images/association_basics/belongs_to.png -- 34.22kb -> 26.71kb (21.96%)
      /guides/assets/images/getting_started/template_is_missing_articles_new.png -- 26.17kb -> 20.72kb (20.81%)
      /guides/assets/images/association_basics/has_many.png -- 35.38kb -> 29.84kb (15.66%)
      /guides/assets/images/association_basics/has_one.png -- 37.33kb -> 32.27kb (13.54%)
      /guides/assets/images/association_basics/polymorphic.png -- 82.75kb -> 72.70kb (12.15%)
      /guides/assets/images/association_basics/has_one_through.png -- 90.37kb -> 79.83kb (11.66%)
      /guides/assets/images/association_basics/habtm.png -- 60.00kb -> 53.02kb (11.63%)
      /guides/assets/images/getting_started/unknown_action_create_for_articles.png -- 15.36kb -> 13.82kb (10.04%)
      /guides/assets/images/association_basics/has_many_through.png -- 96.52kb -> 88.06kb (8.76%)
      Signed-off-by: NImgBotApp <ImgBotHelp@gmail.com>
      4f1472d4
  6. 15 3月, 2020 2 次提交
  7. 14 3月, 2020 9 次提交
  8. 13 3月, 2020 7 次提交