- 23 8月, 2018 12 次提交
-
-
由 Rafael França 提交于
Remove extra execution of `uniq!` on action_methods
-
由 Rafael França 提交于
Update ParameterFilter to yield original parameters
-
由 bogdanvlviv 提交于
Execution of `to_set` below should remove duplicated elements. Follow up #33693
-
由 Richard Schneeman 提交于
Two fewer array allocations on action_methods
-
由 Rafael França 提交于
Fix `rails initializers --help` and `rails dev:cache --help`
-
由 Peter Zhu 提交于
-
由 bogdanvlviv 提交于
- `rails initializers --help` should show description set by `desc` See railties/lib/rails/command/base.rb:27 - Fix `rails dev:cache --help` ``` Traceback (most recent call last): 10: from bin/rails:4:in `<main>' 9: from bin/rails:4:in `require' 8: from /work/rails/railties/lib/rails/commands.rb:18:in `<top (required)>' 7: from /work/rails/railties/lib/rails/command.rb:46:in `invoke' 6: from /work/rails/railties/lib/rails/command/base.rb:65:in `perform' 5: from /home/vagrant/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.0/lib/thor.rb:387:in `dispatch' 4: from /home/vagrant/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in `invoke_command' 3: from /home/vagrant/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.0/lib/thor/command.rb:27:in `run' 2: from /work/rails/railties/lib/rails/command/base.rb:150:in `help' 1: from /home/vagrant/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.0/lib/thor.rb:170:in `command_help' /home/vagrant/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.0/lib/thor/base.rb:497:in `handle_no_command_error': Could not find command "dev". (Thor::UndefinedCommandError) ``` Context https://github.com/rails/rails/pull/33694#issuecomment-415127304 Would be great to set a description to other commands.
-
由 Rafael França 提交于
Added explanation about new_framework_defaults.rb file [ci skip]
-
由 Rafael França 提交于
Remove `rake initializers` from rake tasks list
-
-
由 Kasper Timm Hansen 提交于
Stop using Mocha
-
由 schneems 提交于
Instead of creating new arrays for `uniq` and `map` we can instead modify the array in place.
-
- 22 8月, 2018 15 次提交
-
-
由 Ryuta Kamizono 提交于
This was introduced at 24f6bf0d.
-
由 Matthew Draper 提交于
Add database configuration to disable advisory locks.
-
由 Matthew Draper 提交于
Use public_send in value_for_collection
-
由 Eileen M. Uchitelle 提交于
[WIP] Action cable testing
-
-
由 utilum 提交于
This patch corrects a duplicate method name introduced in #33635. Also fixes typo in method names.
-
由 Claas Zurawski 提交于
-
由 Claas Zurawski 提交于
-
由 Rafael França 提交于
[ci skip] Add ImageMagick to Brewfile
-
由 Mr. Outis 提交于
In order to run ActiveStorage's tests successfully, you need imagemagick
-
由 yuuji.yaginuma 提交于
It seems to need an escape for the showing `ENV`. https://api.rubyonrails.org/classes/AbstractController/Caching/Fragments.html#method-i-combined_fragment_cache_key
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
[ci skip] Add ImageMagick to ActiveStorage dependencies
-
由 Mr. Outis 提交于
In order to run ActiveStorage's tests successfully, you need imagemagick.
-
由 Rafael França 提交于
Add usage of procs without arguments to callbacks guide
-
- 21 8月, 2018 2 次提交
-
-
由 Richard Schneeman 提交于
Make `rake routes` deprecate before deleting
-
由 Jeremy Daer 提交于
Improve Active Job test helpers
-
- 20 8月, 2018 11 次提交
-
-
由 Ryuta Kamizono 提交于
The `Relation::Merger` has a problem that order values would be merged as nested array. That was caused an issue #33664 since if array value is passed to `order` and first element in the array includes `?`, the array is regarded as a prepared statement and bind variables. https://api.rubyonrails.org/classes/ActiveRecord/Sanitization/ClassMethods.html#method-i-sanitize_sql_for_order Just merging that as splat args like other values would fix the issue. Fixes #33664.
-
由 Ryuta Kamizono 提交于
Fix `rails routes -c` for controller name consists of multiple word.
-
由 Ryuta Kamizono 提交于
Improve tests for ActiveRecord::ConnectionAdapters::ConnectionPool co…
-
由 Yoshiyuki Kinjo 提交于
-
由 bogdanvlviv 提交于
-
由 bogdanvlviv 提交于
-
由 bogdanvlviv 提交于
Example: ``` def test_assert_performed_with MyJob.perform_later(1,2,3) perform_enqueued_jobs assert_performed_with(job: MyJob, args: [1,2,3], queue: 'high') end ``` Follow up #33626.
-
由 bogdanvlviv 提交于
Execution of `assert_performed_jobs`, and `assert_no_performed_jobs` without a block should respect passed `:except`, `:only`, and `:queue` options.
-
由 bogdanvlviv 提交于
Note that it removes changelog entry of #33265 since the entry in this commits includes that too.
-
由 bogdanvlviv 提交于
If the `:queue` option is specified, then only the job(s) enqueued to a specific queue will not be performed. Example: ``` def test_assert_no_performed_jobs_with_queue_option assert_no_performed_jobs queue: :some_queue do HelloJob.set(queue: :other_queue).perform_later("jeremy") end end ```
-
由 bogdanvlviv 提交于
If the `:queue` option is specified, then only the job(s) enqueued to a specific queue will be performed. Example: ``` def test_assert_performed_jobs_with_queue_option assert_performed_jobs 1, queue: :some_queue do HelloJob.set(queue: :some_queue).perform_later("jeremy") HelloJob.set(queue: :other_queue).perform_later("bogdan") end end ```
-