- 03 3月, 2015 25 次提交
-
-
由 Carlos Antonio da Silva 提交于
This reverts commit a38732c8. Since the mutation logic was reverted in 07278519, we must bring the reader method back as well, since the implementation relies on it.
-
由 Rafael Mendonça França 提交于
Added testcase for #18742
-
由 Aaron Patterson 提交于
This reverts commit 393e65b4 and ec51c3fe We don't want the records to hold hard references to transactions because they point at records that have callbacks.
-
由 Aaron Patterson 提交于
this patch makes errors slightly more expensive when someone is missing a route key, but in exchange it drops 4 allocations per `url_for` call. Since missing a route key is an error, optimizing for the non-error path seems like a good trade off
-
由 Aaron Patterson 提交于
we already know the length of the args, so we can use that length for parallel iteration and cut down on allocations for `url_for` calls.
-
由 Aaron Patterson 提交于
this centralizes the logic for determining the script name key and drops object allocations when calling `engine_script_name` (which is called on each `url_for`).
-
由 Rafael Mendonça França 提交于
Remove unneeded comment
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
this lets us keep singleton instances of "state" values and precalculate return values of things like `finalized?` and `completed?`.
-
由 Aaron Patterson 提交于
this way we don't have to mutate a state object, we can just change the state of the txn
-
由 Aaron Patterson 提交于
-
由 Zoltan Kiss 提交于
-
由 Rafael Mendonça França 提交于
Improve the Rubinius build
-
由 David Heinemeier Hansson 提交于
-
由 Yves Senn 提交于
We've replaced most querues using DROP TABLE in our tests already. This patch replaces the last couple calls.
-
由 Sean Griffin 提交于
Preserve Array#take(n) behaviour of HasManyAssociation
-
由 Robin Dupret 提交于
-
由 Sean Griffin 提交于
Move `UnknownAttributeError` to a more sane namespace
-
由 Arthur Neves 提交于
-
由 Richard Schneeman 提交于
[ci skip] Fix a typo for PostgreSQL text limit, GB instead of Gb.
-
由 Robin Dupret 提交于
At the moment, `rescue_from` doesn't work with strings on Rubinius because of rubinius/rubinius#3272.
-
由 Juanito Fatas 提交于
-
由 Robin Dupret 提交于
Rubinius is still targeting compliance with Ruby 2.1.0 but we are pretty close to a green build so let's avoid this check for the moment.
-
由 Arthur Neves 提交于
-
由 Arthur Neves 提交于
We only set the state on the record if that condition is `false` in the first place, so we dont need to call that again. Also that call is expensive, follow benchmark with before and after this change: ``` Calculating ------------------------------------- persisted? 15.272k i/100ms ------------------------------------------------- persisted? 350.119k (± 4.6%) i/s - 1.756M ``` ``` Calculating ------------------------------------- persisted? 25.988k i/100ms ------------------------------------------------- persisted? 1.294M (± 5.3%) i/s - 6.445M ``` (benchmark borrowed from 57d35b2b)
-
- 02 3月, 2015 15 次提交
-
-
由 Robin Dupret 提交于
The edge version ships with a patch that uses composition over inheritance for the Mail::PartsList object (see mikel/mail#782). Let's test Action Mailer against it to prevent eventual regressions and experience it. Moreover, this branch makes the Action Mailer suite green against Rubinius.
-
由 Carlos Antonio da Silva 提交于
Merge pull request #19170 from JuanitoFatas/doc/active_record/connection_adapters/abstract/schema_definitions.rb Clarify that t.references and t.belongs_to are interchangeable. [ci skip]
-
由 Aaron Patterson 提交于
directly calling `sync_with_transaction_state` is not fast, so if we call it once, we can improve the performance of the `persisted?` method. This is important because every call to `url_for(model)` will call `persisted?`, so we want that to be fast. Here is the benchmark: ```ruby require 'active_record' ActiveRecord::Base.establish_connection adapter: "sqlite3", database: ":memory:" ActiveRecord::Base.connection.instance_eval do create_table(:articles) end class Article < ActiveRecord::Base; end article = Article.new.tap(&:save!) Benchmark.ips do |x| x.report("persisted?") do article.persisted? end end ``` Before this patch: ``` $ bundle exec ruby -rbenchmark/ips persisted.rb Calculating ------------------------------------- persisted? 3.333k i/100ms ------------------------------------------------- persisted? 51.037k (± 8.2%) i/s - 253.308k ``` After: ``` $ bundle exec ruby -rbenchmark/ips persisted.rb Calculating ------------------------------------- persisted? 7.172k i/100ms ------------------------------------------------- persisted? 120.730k (± 5.1%) i/s - 602.448k ```
-
由 Aaron Patterson 提交于
depth is always 0, so the index will always be false. No reason to create the instance variable if it isn't used
-
由 Eileen M. Uchitelle 提交于
Rake restart task no longer loads entire Rails environment when run
-
由 Juanito Fatas 提交于
-
由 Hyonjee Joo 提交于
The restart task does not need access to models or other classes and helpers from the application environment.
-
由 Rafael Mendonça França 提交于
[Robin Dupret + Rafael Mendonça França]
-
由 Eileen M. Uchitelle 提交于
Improve guides [ci skip]
-
由 Yu Haidong 提交于
-
由 Robin Dupret 提交于
-
由 Robin Dupret 提交于
Since there are disparities between the raised error messages on the different implementations, let's avoid being too accurate.
-
由 Robin Dupret 提交于
Since the `ForkingExecutor` class seems to be pretty slow on Rubinius due to DRb (c.f. http://git.io/xIVg), let's avoid running tests with it on this platform. Also, the `parallelize_me!` call make the suite to output a bunch of errors due to rubinius/rubinius#2934 since there are thread-safety problems with autoloading.
-
由 Robin Dupret 提交于
[ci skip] Add code example for MailHelper#block_format documentation
-
由 Robin Dupret 提交于
Nit pick the byebug settings guide for default values [ci skip]
-