Remove an empty line from generated migration

Currently, if you run `rails g migration remove_column_from_models`,
there is an empty line before `remove_column` line because we forgot to
use `-%>` in the template:

    $ bin/rails g migration remove_title_from_posts title:string
          invoke  active_record
          create    db/migrate/20200114061235_remove_title_from_posts.rb

    $ cat db/migrate/20200114061235_remove_title_from_posts.rb
    class RemoveTitleFromPosts < ActiveRecord::Migration[6.1]
      def change

        remove_column :posts, :title, :string
      end
    end

This commit adds the missing `-` in front of `-%>` to make it removes
the empty line.

Pass Benchmark.ms block through to realtime

https://bugs.ruby-lang.org/issues/16485
https://github.com/ruby/ruby/pull/2832

Avoids pushing an extra stack frame.

https://buildkite.com/rails/rails/builds/66424#a1fdb92a-a9a0-4ff2-afc8-a59410cd4fdf/1016-1027

Fix CI error with minitest 5.14

Follow up to 2bf1c17c, which still left
this one failure. Minitest 5.14 uses error instead of exception, so
exception had been changed to just be the same UnexpectedError instance
and losing us the actual error message.

This also switches to initializing a new UnexpectedError instance
because previously, for reasons I can't quite figure out, reusing the
same instance would still give us a DRbConnError.

Add scale support to ActiveRecord::Validations::NumericalityValidator

Fix NoMethodError on ActiveSupport::Cache::RedisCacheStore#clear with…

Remove Ruby 2.7 warning on arg forwarding

Kwargs need to be forwarded for this method_missing to avoid warnings in Ruby 2.7.

https://github.com/rack/rack/compare/2.1.0...2.1.1

https://github.com/seattlerb/minitest/commit/5802aa08280a3609b684e0ebef95dabfbd3ec9ff
https://github.com/seattlerb/minitest/pull/809#discussion_r332399750

To support both 5.13.0 and 5.14.0, use `#initialize` instead.

https://github.com/janko/image_processing/pull/63

rack 2.1.0 changed expires date format from rfc2822 to httpdate

Reduce number of created objects in Hash#to_json

Finding Orphan Records

Followup to 9256ae8a.

Since the result of `as_json` is typically encoded with `to_json`, this
patch should save the same number of allocations as the previous one.

See https://github.com/rack/rack/pull/1144.

Do not re-parse PATH_INFO when validating authenticity token

Put dev dependencies in generated plugin Gemfile

PATH_INFO will never contain query parameters (that is the contract with
the webserver), so there is no reason to call URI.parse on it.  In
addition, clients can send garbage paths that raise an exception when
being parsed rather than just failing the auth token check.

* Fix ActionController::TestSession#id to return Rack::Session::SessionId instance

* test SessionId#public_id

* test session["session_id"]
Co-authored-by: NBenjamin Quorning <22333+bquorning@users.noreply.github.com>

Fix NumericalityValidator when precision is too high:

- When a column with a precision that is higher than what the system
  allows, it would result in an error:

  ```sh
    require "bigdecimal/util"

    123.4.to_d(20) => ArgumentError, precision is too high
  ```

  To fix that problem we need to check what the max number of digits
  a Float is allowed to have, we can achieve that with `BigDecimal.double_fig`

  Fix #38209

Reduce number of created objects in Hash#as_json

Merge pull request #38204 from eileencodes/fix-reading-conn-so-text-fixtures-raise-when-writing-on-replica

Ensure the reading connection always raises if we try to write

Fix numericality validator when defined on abstract class:

- ### Problem

  It's no longer possible to define a numeric validation on abstract
  class:

  ```ruby
    class AnimalsBase < ApplicationRecord
      self.abstract_class = true

      validates :age, numericality: { min: 18 }
    end

    class Dog < AnimalsBase
    end

    Dog.create!(age: 0) => ActiveRecord::TableNotSpecified: Dog has no table configured. Set one with Dog.table_name=
  ```

  ### Solution

  Instead of trying to get the type for attribute on the class
  defining the validation, get it from the record being validated.

Typo fix of visbility.

Since test fixtures share connections (due to transactional tests) we
end up overwriting the reading configuration so Rails doesn't recognize
it as a replica connection.

This change ensures that if we're using the `reading` role that
connections will always have prevent writes turned on.

If you need a replica connection that does not block writes, you should
use a different role name other than `:reading`.

The db selector test and connection handlers test have been updated to
test for these changes. In the db selector test we don't always have a
writing handler so I updated test fixtures to return if that's nil.

Lastly one test needed to be updated to use a different handler name due
to it needing to write to successfully test what it needs to test.

Fixes #37765

This test wasn't correct. If we're calling `resolver.read` and want to
actually read from the replicas then the role would be reading not
writing. This was because the session store needed to be changed so that
we actually are "reading from the replicas" instead of reading from the
primary.

The Gemfile offers more flexibility than the gemspec in terms of gem
groups and platforms.  Putting the default development dependencies in
the Gemfile encourages users to add their own development dependencies
to the Gemfile.  This is similar to the current behavior of the
`bundle gem` command (see bundler/bundler#7222).

This change also fixes a corner case where using the "--skip-gemspec"
and "--skip-active-record" options together would incorrectly generate a
"sqlite3" dependency in the Gemfile.