- 20 12月, 2019 8 次提交
-
-
由 Ryuta Kamizono 提交于
Don't use rails command shortcuts in guides [ci skip]
-
由 Ryuta Kamizono 提交于
Activerecord ruby 2.7 warnings 6 0 stable batch 2
-
由 Petrik 提交于
Use the full rails commands instead of the shortcuts in the guides. This makes things clearer for new users.
-
由 eileencodes 提交于
-
由 Eileen M. Uchitelle 提交于
Don't allow mutations on configuration_hash
-
由 Rafael França 提交于
Don't require "action_view/base" in action pack:
-
由 Edouard CHIN 提交于
- ### Problem ActionPack requires "action_view/base" at boot time, this causes a variety of issue that I described in detail in #38024. There is no real reason to require av/base in the ActionDispatch::Debugexceptions class. ### Solution Like any other components (such as ActiveRecord, ActiveJob...), ActionView::Base shouldn't be loaded at boot time. Here are the two main changes needed for this: 1) Actionview has a special initializer that needs to run before the app is fully booted (adding a executor needs to be done before application is done booting) https://github.com/rails/rails/blob/63ec70e700e321b22e9baf2ad2d45cd3f4febc79/actionview/lib/action_view/railtie.rb#L81-L84 That initializer used a lazy load hooks but we can't do that anymore because Action::Base view won't be triggered during booting process. When it will get triggered, (presumably on the first request), it's too late to add an executor. ------------------------------------------------ 2) Compare to other components, ActionView doesn't use `Base` for configuration flag. A lot of flags ares instead set on modules (FormHelper, FormTagHelper). The problem is that those module depends on AV::Base to be loaded, as otherwise configuration set by the user aren't applied. (Since the lazy load hooks hasn't been triggered) https://github.com/rails/rails/blob/63ec70e700e321b22e9baf2ad2d45cd3f4febc79/actionview/lib/action_view/railtie.rb#L66-L69 We shouldn't wait for AB::Base to be loaded in order to set these configuration. However, we need to do it inside an `after_initialize` block in order to let application set it to the value they want. Closes #28538 Co-authored-by: betesh <iybetesh@gmail.com>"
-
由 Rafael França 提交于
Prevent negative IDs in output of #inspect.
-
- 19 12月, 2019 15 次提交
-
-
由 Rafael França 提交于
Fix Active Record attribute filtering test on Ruby 2.7
-
由 Rafael Mendonça França 提交于
Fix DebugExceptions crash on nil Exception#annoted_source_code
-
由 Genadi Samokovarov 提交于
The issue was reported in #29537. We expect Exception#annoted_source_code to return an `Array`, but this contract may not be followed by all the implementers. Fixes #29537.
-
由 Rafael França 提交于
Remove stacktrace from ActiveJob logging callback halts
-
由 Rafael França 提交于
Clarify language in Asset Pipeline Guide
-
由 Jean Boussier 提交于
-
由 eileencodes 提交于
We want to introduce an object-based DSL for building and modifying configuration objects. As part of that we want to make sure that users don't think they can modify configuration_hash values and have them change the configuration. For that reason we're going to freeze the Hash here, and have modified places in tests where we were modifying these hashes. The commit here also adds a test for the Test Databases and in that work we found that we were calling `Rails.env` and Active Record doesn't load Rails. Co-authored-by: NJohn Crepezzi <john.crepezzi@gmail.com>
-
由 Ryuta Kamizono 提交于
Update sqlite3 to avoid Ruby 2.7 warnings
-
由 Jean Boussier 提交于
-
由 Ryan Lue 提交于
-
由 Rafael França 提交于
Add missing $ prompt for bash command examples [ci skip]
-
由 Petrik 提交于
Some bash command examples were missing the $ sign.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
The `ActionDispatch::Session::MemcacheStore` is still vulnerable given it requires the gem dalli to be updated as well. CVE-2019-16782
-
由 Xavier Noria 提交于
Co-Authored-By: NHirofumi Wakasugi <baenej@gmail.com>
-
- 18 12月, 2019 17 次提交
-
-
由 Rafael França 提交于
Update ActionText docs [ci skip]
-
由 eileencodes 提交于
These tests weren't calling assert, so if the execute didn't raise but also didn't return anything it would be a broken test that never fails. We need to always add an assertion so we know what the expected behavior is.
-
由 Rafael França 提交于
Ensure result is cleared at ConnectionAdapters::PostgreSQLAdapter#execute_and_clear
-
由 Rafael Mendonça França 提交于
Config ac per env
-
由 Rafael França 提交于
allow running each test with pure ruby path/to/test.rb
-
由 Jack Kinsella 提交于
-
由 Rafael França 提交于
Use new `...` syntax in Module#delegate if it's available
-
由 Rafael França 提交于
Fix handling of undefined year in DateTimeSelector
-
由 Rafael Mendonça França 提交于
Cleanup Action View `abstract_unit`
-
由 Eileen M. Uchitelle 提交于
Fix remaining connection_config calls
-
由 Jean Boussier 提交于
It was added in https://bugs.ruby-lang.org/issues/16253 It allows to do blind delegation without having to worry about ruby2_keywords, and suposedly is also a bit faster.
-
由 Roman Sokhan 提交于
-
由 Michael Grosser 提交于
also: - makes test dependencies obvious - makes tests runnable from within subfolders
-
由 eileencodes 提交于
We missed these in rails/rails#38005 because deprecation warnings are silently swallowed by these tests. Co-authored-by: NJohn Crepezzi <john.crepezzi@gmail.com>
-
由 Rafael França 提交于
Remove superfluous keep file
-
由 Vipul A M 提交于
Fix documentation indentation: [ci skip]
-
由 Jack Kinsella 提交于
- Added guidance on issues with webpacker (making actiontext more beginner friendly) - Clarify confusion about whether `content` attribute in database is needed.
-