1. 01 12月, 2016 5 次提交
    • J
      Merge pull request #27233 from utilum/27202_remove_outdated_tip_in_form_helpers_guide · 00797f14
      Jon Moss 提交于
      Fixes #27202, [ci skip]
      00797f14
    • U
      Fixes #27202, [ci skip] · 2dc74387
      utilum 提交于
      2dc74387
    • M
      Merge pull request #27206 from kirs/fix-testing-isolation-2 · f9592e16
      Matthew Draper 提交于
      Fix arguments passing in testing isolation
      f9592e16
    • K
      Fix arguments passing in testing isolation · 4b3cd4b0
      Kir Shatrov 提交于
      The issue affects MRI 2.2.5, MRI 2.3.3, JRuby 9.1.6.0. It can be reproduced by:
      
      ```
      $ cd activemodel
      $ NO_FORK=1 bundle exec rake test
      ```
      
      If we wrap original arguments in quotes, it will be considered as a one big single argument.
      Later, [`rake/rake_test_loader.rb`](https://github.com/ruby/rake/blob/7863b97/lib/rake/rake_test_loader.rb#L15)
      will iterate over ARGS and try to require that huge single "argument" (which is a list of multiple .rb files).
      This leads to an exception:
      
      ```
      /Users/kir/Project
      s/opensource/rails/vendor/bundle/gems/rake-11.3.0/lib/rake/rake_test_loader.rb:15:in `require': cannot load such file -- /Users/kir/Projects/opensource/rails/activemodel/test/cases/
      attribute_assignment_test.rb [stripped] /Users/kir/Projects/opensource/rails/activemodel/test/cases/validations/with_validation_test.rb /Users/kir/Projects/opensource/rails/activemodel/test/cases/validations_test
      .rb (LoadError)
      
              from /Users/kir/Projects/opensource/rails/vendor/bundle/gems/rake-11.3.0/lib/rake/rake_test_loader.rb:15:in `block in <main>'
              from /Users/kir/Projects/opensource/rails/vendor/bundle/gems/rake-11.3.0/lib/rake/rake_test_loader.rb:4:in `select'
              from /Users/kir/Projects/opensource/rails/vendor/bundle/gems/rake-11.3.0/lib/rake/rake_test_loader.rb:4:in `<main>'
      ```
      
      Originally quotes were introduced in https://github.com/rails/rails/pull/19819 to fix MRI 2.2.2.
      
      The fix solves issue on all affected platforms: MRI 2.2.5, MRI 2.3.3, JRuby 9.1.6.0.
      4b3cd4b0
    • S
      Make the second argument to `attribute` optional · 1bdc395d
      Sean Griffin 提交于
      While working on updating Paper Trail for 5.1 compatibility, I noticed
      that I was required to pass a second argument to `attribute`. I didn't
      intend for this to be the case, as `attribute :foo` is totally
      reasonable shorthand for "I want `attr_accessor :foo`, but also have it
      work with things like `.attributes` and `ActiveRecord::Dirty`"
      1bdc395d
  2. 30 11月, 2016 16 次提交
  3. 29 11月, 2016 11 次提交
  4. 28 11月, 2016 8 次提交