提交 fffbf9bd 编写于 作者: A Aaron Patterson

make the logger method always return something

then we can stop scattering nil checks (e.g. `try`) through the class.
上级 6fedc7d5
......@@ -64,17 +64,17 @@ def initialize(options)
def digest
Digest::MD5.hexdigest("#{source}-#{dependency_digest}").tap do |digest|
logger.try :debug, " Cache digest for #{template.inspect}: #{digest}"
logger.debug " Cache digest for #{template.inspect}: #{digest}"
end
rescue ActionView::MissingTemplate
logger.try :error, " Couldn't find template for digesting: #{name}"
logger.error " Couldn't find template for digesting: #{name}"
''
end
def dependencies
DependencyTracker.find_dependencies(name, template, finder.view_paths)
rescue ActionView::MissingTemplate
logger.try :error, " '#{name}' file doesn't exist, so no dependencies"
logger.error " '#{name}' file doesn't exist, so no dependencies"
[]
end
......@@ -86,8 +86,13 @@ def nested_dependencies
end
private
class NullLogger
def self.debug(_); end
def self.error(_); end
end
def logger
ActionView::Base.logger
ActionView::Base.logger || NullLogger
end
def logical_name
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册