Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
fc0e3354
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
fc0e3354
编写于
4月 08, 2017
作者:
R
Rafael França
提交者:
Matthew Draper
4月 10, 2017
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Merge pull request #28705 from kamipo/extract_construct_relation_for_exists
Extract `construct_relation_for_exists` in `FinderMethods`
上级
46e55df3
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
33 addition
and
17 deletion
+33
-17
activerecord/lib/active_record/relation/finder_methods.rb
activerecord/lib/active_record/relation/finder_methods.rb
+15
-12
activerecord/test/cases/finder_test.rb
activerecord/test/cases/finder_test.rb
+18
-5
未找到文件。
activerecord/lib/active_record/relation/finder_methods.rb
浏览文件 @
fc0e3354
...
...
@@ -312,16 +312,7 @@ def exists?(conditions = :none)
relation
=
apply_join_dependency
(
self
,
construct_join_dependency
(
eager_loading:
false
))
return
false
if
ActiveRecord
::
NullRelation
===
relation
relation
=
relation
.
except
(
:select
,
:distinct
).
select
(
ONE_AS_ONE
).
limit
(
1
)
case
conditions
when
Array
,
Hash
relation
=
relation
.
where
(
conditions
)
else
unless
conditions
==
:none
relation
=
relation
.
where
(
primary_key
=>
conditions
)
end
end
relation
=
construct_relation_for_exists
(
relation
,
conditions
)
connection
.
select_value
(
relation
,
"
#{
name
}
Exists"
,
relation
.
bound_attributes
)
?
true
:
false
rescue
::
RangeError
...
...
@@ -391,6 +382,19 @@ def find_with_associations
end
end
def
construct_relation_for_exists
(
relation
,
conditions
)
relation
=
relation
.
except
(
:select
,
:distinct
).
_select!
(
ONE_AS_ONE
).
limit!
(
1
)
case
conditions
when
Array
,
Hash
relation
.
where!
(
conditions
)
else
relation
.
where!
(
primary_key
=>
conditions
)
unless
conditions
==
:none
end
relation
end
def
construct_join_dependency
(
joins
=
[],
eager_loading:
true
)
including
=
eager_load_values
+
includes_values
ActiveRecord
::
Associations
::
JoinDependency
.
new
(
@klass
,
including
,
joins
,
eager_loading:
eager_loading
)
...
...
@@ -401,8 +405,7 @@ def construct_relation_for_association_calculations
end
def
apply_join_dependency
(
relation
,
join_dependency
)
relation
=
relation
.
except
(
:includes
,
:eager_load
,
:preload
)
relation
=
relation
.
joins
join_dependency
relation
=
relation
.
except
(
:includes
,
:eager_load
,
:preload
).
joins!
(
join_dependency
)
if
using_limitable_reflections?
(
join_dependency
.
reflections
)
relation
...
...
activerecord/test/cases/finder_test.rb
浏览文件 @
fc0e3354
...
...
@@ -202,11 +202,24 @@ def test_exists_with_nil_arg
assert_equal
true
,
Topic
.
first
.
replies
.
exists?
end
# ensures +exists?+ runs valid SQL by excluding order value
def
test_exists_with_order
# Ensure +exists?+ runs without an error by excluding distinct value.
# See https://github.com/rails/rails/pull/26981.
def
test_exists_with_order_and_distinct
assert_equal
true
,
Topic
.
order
(
:id
).
distinct
.
exists?
end
def
test_exists_with_joins
assert_equal
true
,
Topic
.
joins
(
:replies
).
where
(
replies_topics:
{
approved:
true
}).
order
(
"replies_topics.created_at DESC"
).
exists?
end
def
test_exists_with_left_joins
assert_equal
true
,
Topic
.
left_joins
(
:replies
).
where
(
replies_topics:
{
approved:
true
}).
order
(
"replies_topics.created_at DESC"
).
exists?
end
def
test_exists_with_eager_load
assert_equal
true
,
Topic
.
eager_load
(
:replies
).
where
(
replies_topics:
{
approved:
true
}).
order
(
"replies_topics.created_at DESC"
).
exists?
end
def
test_exists_with_includes_limit_and_empty_result
assert_equal
false
,
Topic
.
includes
(
:replies
).
limit
(
0
).
exists?
assert_equal
false
,
Topic
.
includes
(
:replies
).
limit
(
1
).
where
(
"0 = 1"
).
exists?
...
...
@@ -236,9 +249,9 @@ def test_exists_with_aggregate_having_three_mappings
def
test_exists_with_aggregate_having_three_mappings_with_one_difference
existing_address
=
customers
(
:david
).
address
assert_equal
false
,
Customer
.
exists?
(
address:
Address
.
new
(
existing_address
.
street
,
existing_address
.
city
,
existing_address
.
country
+
"1"
))
assert_equal
false
,
Customer
.
exists?
(
address:
Address
.
new
(
existing_address
.
street
,
existing_address
.
city
+
"1"
,
existing_address
.
country
))
assert_equal
false
,
Customer
.
exists?
(
address:
Address
.
new
(
existing_address
.
street
+
"1"
,
existing_address
.
city
,
existing_address
.
country
))
assert_equal
false
,
Customer
.
exists?
(
address:
Address
.
new
(
existing_address
.
street
,
existing_address
.
city
,
existing_address
.
country
+
"1"
))
assert_equal
false
,
Customer
.
exists?
(
address:
Address
.
new
(
existing_address
.
street
,
existing_address
.
city
+
"1"
,
existing_address
.
country
))
assert_equal
false
,
Customer
.
exists?
(
address:
Address
.
new
(
existing_address
.
street
+
"1"
,
existing_address
.
city
,
existing_address
.
country
))
end
def
test_exists_does_not_instantiate_records
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录