提交 fc09ebc6 编写于 作者: X Xavier Noria 提交者: Michael Koziarski

Wrap calls to update_attributes in a transaction.

Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#922 state:committed]
上级 f4391c36
......@@ -10,7 +10,7 @@ def self.included(base)
base.extend(ClassMethods)
base.class_eval do
[:destroy, :save, :save!].each do |method|
[:destroy, :save, :save!, :update_attribute, :update_attributes, :update_attributes!].each do |method|
alias_method_chain method, :transactions
end
end
......@@ -200,6 +200,20 @@ def save_with_transactions! #:nodoc:
rollback_active_record_state! { self.class.transaction { save_without_transactions! } }
end
def update_attribute_with_transactions(name, value)
with_transaction_returning_status(:update_attribute_without_transactions, name, value)
end
def update_attributes_with_transactions(attributes)
with_transaction_returning_status(:update_attributes_without_transactions, attributes)
end
def update_attributes_with_transactions!(attributes)
transaction do
update_attributes_without_transactions!(attributes)
end
end
# Reset id and @new_record if the transaction rolls back.
def rollback_active_record_state!
id_present = has_attribute?(self.class.primary_key)
......
......@@ -182,6 +182,40 @@ def test_callback_rollback_in_create
end
end
def test_update_attribute_should_rollback_on_failure
Developer.before_save do
false
end
developer = Developer.first
developer.audit_logs.clear
2.times { developer.audit_logs.create(:message => 'message') }
assert_equal 2, developer.audit_logs.size
status = developer.update_attribute(:audit_log_ids, [])
assert !status
assert_equal 2, developer.audit_logs(true).size
end
def test_update_attributes_should_rollback_on_failure
developer = Developer.first
developer.audit_logs.clear
2.times { developer.audit_logs.create(:message => 'message') }
assert_equal 2, developer.audit_logs.size
status = developer.update_attributes(:audit_log_ids => [], :name => nil)
assert !status
assert_equal 2, developer.audit_logs(true).size
end
def test_update_attributes_should_rollback_on_failure!
developer = Developer.first
developer.audit_logs.clear
2.times { developer.audit_logs.create(:message => 'message') }
assert_equal 2, developer.audit_logs.size
assert_raise(ActiveRecord::RecordInvalid) do
developer.update_attributes!(:audit_log_ids => [], :name => nil)
end
assert_equal 2, developer.audit_logs(true).size
end
def test_nested_explicit_transactions
Topic.transaction do
Topic.transaction do
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册