Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
f74098bf
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
f74098bf
编写于
7月 14, 2019
作者:
R
Ryuta Kamizono
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Merge pull request #36658 from Shopify/duplicable-changes
Remove dead code in duplicable.rb
上级
b5a2c01b
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
8 addition
and
118 deletion
+8
-118
activesupport/lib/active_support/core_ext/object/duplicable.rb
...esupport/lib/active_support/core_ext/object/duplicable.rb
+7
-117
activesupport/test/core_ext/object/duplicable_test.rb
activesupport/test/core_ext/object/duplicable_test.rb
+1
-1
未找到文件。
activesupport/lib/active_support/core_ext/object/duplicable.rb
浏览文件 @
f74098bf
...
@@ -28,96 +28,6 @@ def duplicable?
...
@@ -28,96 +28,6 @@ def duplicable?
end
end
end
end
class
NilClass
begin
nil
.
dup
rescue
TypeError
# +nil+ is not duplicable:
#
# nil.duplicable? # => false
# nil.dup # => TypeError: can't dup NilClass
def
duplicable?
false
end
end
end
class
FalseClass
begin
false
.
dup
rescue
TypeError
# +false+ is not duplicable:
#
# false.duplicable? # => false
# false.dup # => TypeError: can't dup FalseClass
def
duplicable?
false
end
end
end
class
TrueClass
begin
true
.
dup
rescue
TypeError
# +true+ is not duplicable:
#
# true.duplicable? # => false
# true.dup # => TypeError: can't dup TrueClass
def
duplicable?
false
end
end
end
class
Symbol
begin
:symbol
.
dup
# Some symbols couldn't be duped in Ruby 2.4.0 only, due to a bug.
# This feature check catches any regression.
"symbol_from_string"
.
to_sym
.
dup
rescue
TypeError
# Symbols are not duplicable:
#
# :my_symbol.duplicable? # => false
# :my_symbol.dup # => TypeError: can't dup Symbol
def
duplicable?
false
end
end
end
class
Numeric
begin
1
.
dup
rescue
TypeError
# Numbers are not duplicable:
#
# 3.duplicable? # => false
# 3.dup # => TypeError: can't dup Integer
def
duplicable?
false
end
end
end
require
"bigdecimal"
class
BigDecimal
# BigDecimals are duplicable:
#
# BigDecimal("1.2").duplicable? # => true
# BigDecimal("1.2").dup # => #<BigDecimal:...,'0.12E1',18(18)>
def
duplicable?
true
end
end
class
Method
class
Method
# Methods are not duplicable:
# Methods are not duplicable:
#
#
...
@@ -128,32 +38,12 @@ def duplicable?
...
@@ -128,32 +38,12 @@ def duplicable?
end
end
end
end
class
Complex
class
UnboundMethod
begin
# Unbound methods are not duplicable:
Complex
(
1
).
dup
#
rescue
TypeError
# method(:puts).unbind.duplicable? # => false
# method(:puts).unbind.dup # => TypeError: allocator undefined for UnboundMethod
# Complexes are not duplicable:
def
duplicable?
#
false
# Complex(1).duplicable? # => false
# Complex(1).dup # => TypeError: can't copy Complex
def
duplicable?
false
end
end
end
class
Rational
begin
Rational
(
1
).
dup
rescue
TypeError
# Rationals are not duplicable:
#
# Rational(1).duplicable? # => false
# Rational(1).dup # => TypeError: can't copy Rational
def
duplicable?
false
end
end
end
end
end
activesupport/test/core_ext/object/duplicable_test.rb
浏览文件 @
f74098bf
...
@@ -6,7 +6,7 @@
...
@@ -6,7 +6,7 @@
require
"active_support/core_ext/numeric/time"
require
"active_support/core_ext/numeric/time"
class
DuplicableTest
<
ActiveSupport
::
TestCase
class
DuplicableTest
<
ActiveSupport
::
TestCase
RAISE_DUP
=
[
method
(
:puts
)]
RAISE_DUP
=
[
method
(
:puts
)
,
method
(
:puts
).
unbind
]
ALLOW_DUP
=
[
"1"
,
"symbol_from_string"
.
to_sym
,
Object
.
new
,
/foo/
,
[],
{},
Time
.
now
,
Class
.
new
,
Module
.
new
,
BigDecimal
(
"4.56"
),
nil
,
false
,
true
,
1
,
2.3
,
Complex
(
1
),
Rational
(
1
)]
ALLOW_DUP
=
[
"1"
,
"symbol_from_string"
.
to_sym
,
Object
.
new
,
/foo/
,
[],
{},
Time
.
now
,
Class
.
new
,
Module
.
new
,
BigDecimal
(
"4.56"
),
nil
,
false
,
true
,
1
,
2.3
,
Complex
(
1
),
Rational
(
1
)]
def
test_duplicable
def
test_duplicable
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录