Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
f6b21d48
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
f6b21d48
编写于
1月 07, 2015
作者:
G
Godfrey Chan
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #16640 from mfazekas/fix_loop_in_changed_for_autosave
Fix potenital infinite recursion in changed_for_autosave?
上级
af2e0fec
fb71fa69
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
21 addition
and
4 deletion
+21
-4
activerecord/lib/active_record/autosave_association.rb
activerecord/lib/active_record/autosave_association.rb
+11
-4
activerecord/test/cases/autosave_association_test.rb
activerecord/test/cases/autosave_association_test.rb
+10
-0
未找到文件。
activerecord/lib/active_record/autosave_association.rb
浏览文件 @
f6b21d48
...
@@ -278,11 +278,18 @@ def associated_records_to_validate_or_save(association, new_record, autosave)
...
@@ -278,11 +278,18 @@ def associated_records_to_validate_or_save(association, new_record, autosave)
# go through nested autosave associations that are loaded in memory (without loading
# go through nested autosave associations that are loaded in memory (without loading
# any new ones), and return true if is changed for autosave
# any new ones), and return true if is changed for autosave
def
nested_records_changed_for_autosave?
def
nested_records_changed_for_autosave?
self
.
class
.
_reflections
.
values
.
any?
do
|
reflection
|
@_nested_records_changed_for_autosave_already_called
||=
false
if
reflection
.
options
[
:autosave
]
return
false
if
@_nested_records_changed_for_autosave_already_called
association
=
association_instance_get
(
reflection
.
name
)
begin
association
&&
Array
.
wrap
(
association
.
target
).
any?
(
&
:changed_for_autosave?
)
@_nested_records_changed_for_autosave_already_called
=
true
self
.
class
.
_reflections
.
values
.
any?
do
|
reflection
|
if
reflection
.
options
[
:autosave
]
association
=
association_instance_get
(
reflection
.
name
)
association
&&
Array
.
wrap
(
association
.
target
).
any?
(
&
:changed_for_autosave?
)
end
end
end
ensure
@_nested_records_changed_for_autosave_already_called
=
false
end
end
end
end
...
...
activerecord/test/cases/autosave_association_test.rb
浏览文件 @
f6b21d48
...
@@ -1030,6 +1030,16 @@ def test_should_automatically_save_the_associated_model
...
@@ -1030,6 +1030,16 @@ def test_should_automatically_save_the_associated_model
assert_equal
'The Vile Insanity'
,
@pirate
.
reload
.
ship
.
name
assert_equal
'The Vile Insanity'
,
@pirate
.
reload
.
ship
.
name
end
end
def
test_changed_for_autosave_should_handle_cycles
@ship
.
pirate
=
@pirate
assert_queries
(
0
)
{
@ship
.
save!
}
@parrot
=
@pirate
.
parrots
.
create
(
name:
"some_name"
)
@parrot
.
name
=
"changed_name"
assert_queries
(
1
)
{
@ship
.
save!
}
assert_queries
(
0
)
{
@ship
.
save!
}
end
def
test_should_automatically_save_bang_the_associated_model
def
test_should_automatically_save_bang_the_associated_model
@pirate
.
ship
.
name
=
'The Vile Insanity'
@pirate
.
ship
.
name
=
'The Vile Insanity'
@pirate
.
save!
@pirate
.
save!
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录