Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
ef361eac
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
ef361eac
编写于
6月 10, 2020
作者:
R
Ryuta Kamizono
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Deprecate `map!` and `collect!` on `ActiveRecord::Result`
These actually does not inplace mutate result. Use true `map` instead.
上级
37c19f7e
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
29 addition
and
1 deletion
+29
-1
activerecord/CHANGELOG.md
activerecord/CHANGELOG.md
+4
-0
activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb
.../lib/active_record/connection_adapters/sqlite3_adapter.rb
+1
-1
activerecord/lib/active_record/result.rb
activerecord/lib/active_record/result.rb
+2
-0
activerecord/test/cases/result_test.rb
activerecord/test/cases/result_test.rb
+22
-0
未找到文件。
activerecord/CHANGELOG.md
浏览文件 @
ef361eac
*
Deprecate
`map!`
and
`collect!`
on
`ActiveRecord::Result`
.
*Ryuta Kamizono*
*
Support
`relation.and`
for intersection as Set theory.
```ruby
...
...
activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb
浏览文件 @
ef361eac
...
...
@@ -518,7 +518,7 @@ def table_structure_with_collation(table_name, basic_structure)
collation_hash
[
$1
]
=
$2
if
COLLATE_REGEX
=~
column_string
end
basic_structure
.
map
!
do
|
column
|
basic_structure
.
map
do
|
column
|
column_name
=
column
[
"name"
]
if
collation_hash
.
has_key?
column_name
...
...
activerecord/lib/active_record/result.rb
浏览文件 @
ef361eac
...
...
@@ -75,6 +75,8 @@ def to_hash
alias
:map!
:map
alias
:collect!
:map
deprecate
"map!"
:
:map
deprecate
"collect!"
:
:map
# Returns true if there are no records, otherwise false.
def
empty?
...
...
activerecord/test/cases/result_test.rb
浏览文件 @
ef361eac
...
...
@@ -12,6 +12,28 @@ def result
])
end
test
"map! is deprecated"
do
assert_deprecated
do
result
.
map!
{
nil
}
end
assert_equal
[
{
"col_1"
=>
"row 1 col 1"
,
"col_2"
=>
"row 1 col 2"
},
{
"col_1"
=>
"row 2 col 1"
,
"col_2"
=>
"row 2 col 2"
},
{
"col_1"
=>
"row 3 col 1"
,
"col_2"
=>
"row 3 col 2"
},
],
result
.
to_a
end
test
"collect! is deprecated"
do
assert_deprecated
do
result
.
collect!
{
nil
}
end
assert_equal
[
{
"col_1"
=>
"row 1 col 1"
,
"col_2"
=>
"row 1 col 2"
},
{
"col_1"
=>
"row 2 col 1"
,
"col_2"
=>
"row 2 col 2"
},
{
"col_1"
=>
"row 3 col 1"
,
"col_2"
=>
"row 3 col 2"
},
],
result
.
to_a
end
test
"includes_column?"
do
assert
result
.
includes_column?
(
"col_1"
)
assert_not
result
.
includes_column?
(
"foo"
)
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录