Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
ec9a89cb
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
ec9a89cb
编写于
6月 03, 2018
作者:
G
Gannon McGibbon
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Add deprecation warning when String#first and String#last receive negative integers
[Gannon McGibbon + Eric Turner]
上级
9fa43429
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
30 addition
and
0 deletion
+30
-0
activesupport/CHANGELOG.md
activesupport/CHANGELOG.md
+4
-0
activesupport/lib/active_support/core_ext/string/access.rb
activesupport/lib/active_support/core_ext/string/access.rb
+8
-0
activesupport/test/core_ext/string_ext_test.rb
activesupport/test/core_ext/string_ext_test.rb
+18
-0
未找到文件。
activesupport/CHANGELOG.md
浏览文件 @
ec9a89cb
*
Deprecate using negative limits in
`String#first`
and
`String#last`
.
*Gannon McGibbon*, *Eric Turner*
*
Fix bug where
`#without`
for
`ActiveSupport::HashWithIndifferentAccess`
would fail
with symbol arguments
...
...
activesupport/lib/active_support/core_ext/string/access.rb
浏览文件 @
ec9a89cb
...
...
@@ -75,6 +75,10 @@ def to(position)
# str.first(0) # => ""
# str.first(6) # => "hello"
def
first
(
limit
=
1
)
ActiveSupport
::
Deprecation
.
warn
(
"Calling String#first with a negative integer limit "
\
"will raise an ArgumentError in Rails 6.1."
)
if
limit
<
0
if
limit
==
0
""
elsif
limit
>=
size
...
...
@@ -95,6 +99,10 @@ def first(limit = 1)
# str.last(0) # => ""
# str.last(6) # => "hello"
def
last
(
limit
=
1
)
ActiveSupport
::
Deprecation
.
warn
(
"Calling String#last with a negative integer limit "
\
"will raise an ArgumentError in Rails 6.1."
)
if
limit
<
0
if
limit
==
0
""
elsif
limit
>=
size
...
...
activesupport/test/core_ext/string_ext_test.rb
浏览文件 @
ec9a89cb
...
...
@@ -469,6 +469,15 @@ class StringAccessTest < ActiveSupport::TestCase
assert_not_same
different_string
,
string
end
test
"#first with negative Integer is deprecated"
do
string
=
"hello"
message
=
"Calling String#first with a negative integer limit "
\
"will raise an ArgumentError in Rails 6.1."
assert_deprecated
(
message
)
do
string
.
first
(
-
1
)
end
end
test
"#last returns the last character"
do
assert_equal
"o"
,
"hello"
.
last
assert_equal
"x"
,
"x"
.
last
...
...
@@ -487,6 +496,15 @@ class StringAccessTest < ActiveSupport::TestCase
assert_not_same
different_string
,
string
end
test
"#last with negative Integer is deprecated"
do
string
=
"hello"
message
=
"Calling String#last with a negative integer limit "
\
"will raise an ArgumentError in Rails 6.1."
assert_deprecated
(
message
)
do
string
.
last
(
-
1
)
end
end
test
"access returns a real string"
do
hash
=
{}
hash
[
"h"
]
=
true
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录