Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
e8cf45dc
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
e8cf45dc
编写于
8月 07, 2020
作者:
R
Ryuta Kamizono
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Don't use arel factory methods for creating join nodes
Directly `klass.new` is clear enough than factory methods.
上级
ab0e39c2
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
4 addition
and
4 deletion
+4
-4
activerecord/lib/active_record/associations/association_scope.rb
...ecord/lib/active_record/associations/association_scope.rb
+1
-1
activerecord/lib/active_record/associations/join_dependency/join_association.rb
...e_record/associations/join_dependency/join_association.rb
+2
-2
activerecord/lib/active_record/relation/query_methods.rb
activerecord/lib/active_record/relation/query_methods.rb
+1
-1
未找到文件。
activerecord/lib/active_record/associations/association_scope.rb
浏览文件 @
e8cf45dc
...
...
@@ -52,7 +52,7 @@ def self.get_bind_values(owner, chain)
attr_reader
:value_transformation
def
join
(
table
,
constraint
)
table
.
create_join
(
table
,
table
.
create_on
(
constraint
),
Arel
::
Nodes
::
LeadingJoin
)
Arel
::
Nodes
::
LeadingJoin
.
new
(
table
,
Arel
::
Nodes
::
On
.
new
(
constraint
)
)
end
def
last_chain_scope
(
scope
,
reflection
,
owner
)
...
...
activerecord/lib/active_record/associations/join_dependency/join_association.rb
浏览文件 @
e8cf45dc
...
...
@@ -50,7 +50,7 @@ def join_constraints(foreign_table, foreign_klass, join_type, alias_tracker, &bl
end
end
joins
<<
table
.
create_join
(
table
,
table
.
create_on
(
nodes
),
join_type
)
joins
<<
join_type
.
new
(
table
,
Arel
::
Nodes
::
On
.
new
(
nodes
)
)
if
others
&&
!
others
.
empty?
joins
.
concat
arel
.
join_sources
...
...
@@ -79,7 +79,7 @@ def strict_loading?
private
def
append_constraints
(
join
,
constraints
)
if
join
.
is_a?
(
Arel
::
Nodes
::
StringJoin
)
join_string
=
table
.
create_and
(
constraints
.
unshift
(
join
.
left
)
)
join_string
=
Arel
::
Nodes
::
And
.
new
(
constraints
.
unshift
join
.
left
)
join
.
left
=
Arel
.
sql
(
base_klass
.
connection
.
visitor
.
compile
(
join_string
))
else
right
=
join
.
right
...
...
activerecord/lib/active_record/relation/query_methods.rb
浏览文件 @
e8cf45dc
...
...
@@ -1252,7 +1252,7 @@ def build_join_buckets
end
joins
.
each_with_index
do
|
join
,
i
|
joins
[
i
]
=
table
.
create_string_join
(
Arel
.
sql
(
join
.
strip
))
if
join
.
is_a?
(
String
)
joins
[
i
]
=
Arel
::
Nodes
::
StringJoin
.
new
(
Arel
.
sql
(
join
.
strip
))
if
join
.
is_a?
(
String
)
end
while
joins
.
first
.
is_a?
(
Arel
::
Nodes
::
Join
)
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录