Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
e6ad2e4c
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
e6ad2e4c
编写于
4月 30, 2020
作者:
R
Ryuta Kamizono
提交者:
GitHub
4月 30, 2020
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #39083 from kamipo/deprecate_allowed_index_name_length
Deprecate `allowed_index_name_length` in `DatabaseLimits`
上级
c7c3abe0
ab2d859e
变更
6
隐藏空白更改
内联
并排
Showing
6 changed file
with
12 addition
and
9 deletion
+12
-9
activerecord/CHANGELOG.md
activerecord/CHANGELOG.md
+1
-1
activerecord/lib/active_record/connection_adapters/abstract/database_limits.rb
...ve_record/connection_adapters/abstract/database_limits.rb
+1
-0
activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
..._record/connection_adapters/abstract/schema_statements.rb
+2
-4
activerecord/test/cases/adapter_test.rb
activerecord/test/cases/adapter_test.rb
+4
-0
activerecord/test/cases/migration/columns_test.rb
activerecord/test/cases/migration/columns_test.rb
+1
-1
activerecord/test/cases/migration/index_test.rb
activerecord/test/cases/migration/index_test.rb
+3
-3
未找到文件。
activerecord/CHANGELOG.md
浏览文件 @
e6ad2e4c
*
Deprecate
`in_clause_length`
in
`DatabaseLimits`
.
*
Deprecate
`in_clause_length`
and
`allowed_index_name_length`
in
`DatabaseLimits`
.
*Ryuta Kamizono*
...
...
activerecord/lib/active_record/connection_adapters/abstract/database_limits.rb
浏览文件 @
e6ad2e4c
...
...
@@ -32,6 +32,7 @@ def table_name_length
def
allowed_index_name_length
index_name_length
end
deprecate
:allowed_index_name_length
# Returns the maximum length of an index name.
def
index_name_length
...
...
activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
浏览文件 @
e6ad2e4c
...
...
@@ -1441,10 +1441,8 @@ def extract_foreign_key_action(specifier)
end
def
validate_index_length!
(
table_name
,
new_name
,
internal
=
false
)
max_index_length
=
internal
?
index_name_length
:
allowed_index_name_length
if
new_name
.
length
>
max_index_length
raise
ArgumentError
,
"Index name '
#{
new_name
}
' on table '
#{
table_name
}
' is too long; the limit is
#{
allowed_index_name_length
}
characters"
if
new_name
.
length
>
index_name_length
raise
ArgumentError
,
"Index name '
#{
new_name
}
' on table '
#{
table_name
}
' is too long; the limit is
#{
index_name_length
}
characters"
end
end
...
...
activerecord/test/cases/adapter_test.rb
浏览文件 @
e6ad2e4c
...
...
@@ -411,6 +411,10 @@ def test_joins_per_query_is_deprecated
assert_deprecated
{
@connection
.
joins_per_query
}
end
def
test_allowed_index_name_length_is_deprecated
assert_deprecated
{
@connection
.
allowed_index_name_length
}
end
unless
current_adapter?
(
:OracleAdapter
)
def
test_in_clause_length_is_deprecated
assert_deprecated
{
@connection
.
in_clause_length
}
...
...
activerecord/test/cases/migration/columns_test.rb
浏览文件 @
e6ad2e4c
...
...
@@ -254,7 +254,7 @@ def test_change_column_with_custom_index_name
def
test_change_column_with_long_index_name
table_name_prefix
=
"test_models_"
long_index_name
=
table_name_prefix
+
(
"x"
*
(
connection
.
allowed_
index_name_length
-
table_name_prefix
.
length
))
long_index_name
=
table_name_prefix
+
(
"x"
*
(
connection
.
index_name_length
-
table_name_prefix
.
length
))
add_column
"test_models"
,
"category"
,
:string
add_index
:test_models
,
:category
,
name:
long_index_name
...
...
activerecord/test/cases/migration/index_test.rb
浏览文件 @
e6ad2e4c
...
...
@@ -44,7 +44,7 @@ def test_rename_index_too_long
e
=
assert_raises
(
ArgumentError
)
{
connection
.
rename_index
(
table_name
,
"old_idx"
,
too_long_index_name
)
}
assert_match
(
/too long; the limit is
#{
connection
.
allowed_
index_name_length
}
characters/
,
e
.
message
)
assert_match
(
/too long; the limit is
#{
connection
.
index_name_length
}
characters/
,
e
.
message
)
assert
connection
.
index_name_exists?
(
table_name
,
"old_idx"
)
end
...
...
@@ -66,7 +66,7 @@ def test_add_index_does_not_accept_too_long_index_names
e
=
assert_raises
(
ArgumentError
)
{
connection
.
add_index
(
table_name
,
"foo"
,
name:
too_long_index_name
)
}
assert_match
(
/too long; the limit is
#{
connection
.
allowed_
index_name_length
}
characters/
,
e
.
message
)
assert_match
(
/too long; the limit is
#{
connection
.
index_name_length
}
characters/
,
e
.
message
)
assert_not
connection
.
index_name_exists?
(
table_name
,
too_long_index_name
)
connection
.
add_index
(
table_name
,
"foo"
,
name:
good_index_name
)
...
...
@@ -229,7 +229,7 @@ def test_add_partial_index
private
def
good_index_name
"x"
*
connection
.
allowed_
index_name_length
"x"
*
connection
.
index_name_length
end
end
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录