Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
e3daaeea
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
e3daaeea
编写于
12月 24, 2011
作者:
J
Jeremy Kemper
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #4168 from lest/remove-define-attr-method
remove deprecated define_attr_method from ActiveModel::AttributeMethods
上级
734ce00a
9813c623
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
0 addition
and
72 deletion
+0
-72
activemodel/lib/active_model/attribute_methods.rb
activemodel/lib/active_model/attribute_methods.rb
+0
-41
activemodel/test/cases/attribute_methods_test.rb
activemodel/test/cases/attribute_methods_test.rb
+0
-31
未找到文件。
activemodel/lib/active_model/attribute_methods.rb
浏览文件 @
e3daaeea
...
...
@@ -66,47 +66,6 @@ module AttributeMethods
end
module
ClassMethods
def
define_attr_method
(
name
,
value
=
nil
,
deprecation_warning
=
true
,
&
block
)
#:nodoc:
# This deprecation_warning param is for internal use so that we can silence
# the warning from Active Record, because we are implementing more specific
# messages there instead.
#
# It doesn't apply to the original_#{name} method as we want to warn if
# people are calling that regardless.
if
deprecation_warning
ActiveSupport
::
Deprecation
.
warn
(
"define_attr_method is deprecated and will be removed without replacement."
)
end
sing
=
singleton_class
sing
.
class_eval
<<-
eorb
,
__FILE__
,
__LINE__
+
1
remove_possible_method :'original_
#{
name
}
'
remove_possible_method :'_original_
#{
name
}
'
alias_method :'_original_
#{
name
}
', :'
#{
name
}
'
define_method :'original_
#{
name
}
' do
ActiveSupport::Deprecation.warn(
"This method is generated by ActiveModel::AttributeMethods::ClassMethods#define_attr_method, " \
"which is deprecated and will be removed."
)
send(:'_original_
#{
name
}
')
end
eorb
if
block_given?
sing
.
send
:define_method
,
name
,
&
block
else
# If we can compile the method name, do it. Otherwise use define_method.
# This is an important *optimization*, please don't change it. define_method
# has slower dispatch and consumes more memory.
if
name
=~
NAME_COMPILABLE_REGEXP
sing
.
class_eval
<<-
RUBY
,
__FILE__
,
__LINE__
+
1
def
#{
name
}
;
#{
value
.
nil?
?
'nil'
:
value
.
to_s
.
inspect
}
; end
RUBY
else
value
=
value
.
to_s
if
value
sing
.
send
(
:define_method
,
name
)
{
value
}
end
end
end
# Declares a method available for all attributes with the given prefix.
# Uses +method_missing+ and <tt>respond_to?</tt> to rewrite the method.
#
...
...
activemodel/test/cases/attribute_methods_test.rb
浏览文件 @
e3daaeea
...
...
@@ -133,37 +133,6 @@ def foo
assert_equal
"value of foo bar"
,
ModelWithAttributesWithSpaces
.
new
.
send
(
:'foo bar'
)
end
test
'#define_attr_method generates attribute method'
do
assert_deprecated
do
ModelWithAttributes
.
define_attr_method
(
:bar
,
'bar'
)
end
assert_respond_to
ModelWithAttributes
,
:bar
assert_deprecated
do
assert_equal
"original bar"
,
ModelWithAttributes
.
original_bar
end
assert_equal
"bar"
,
ModelWithAttributes
.
bar
ActiveSupport
::
Deprecation
.
silence
do
ModelWithAttributes
.
define_attr_method
(
:bar
)
end
assert
!
ModelWithAttributes
.
bar
end
test
'#define_attr_method generates attribute method with invalid identifier characters'
do
ActiveSupport
::
Deprecation
.
silence
do
ModelWithWeirdNamesAttributes
.
define_attr_method
(
:'c?d'
,
'c?d'
)
end
assert_respond_to
ModelWithWeirdNamesAttributes
,
:'c?d'
ActiveSupport
::
Deprecation
.
silence
do
assert_equal
"original c?d"
,
ModelWithWeirdNamesAttributes
.
send
(
'original_c?d'
)
end
assert_equal
"c?d"
,
ModelWithWeirdNamesAttributes
.
send
(
'c?d'
)
end
test
'#alias_attribute works with attributes with spaces in their names'
do
ModelWithAttributesWithSpaces
.
define_attribute_methods
([
:'foo bar'
])
ModelWithAttributesWithSpaces
.
alias_attribute
(
:'foo_bar'
,
:'foo bar'
)
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录