Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
e3b2a573
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
e3b2a573
编写于
8月 15, 2019
作者:
G
George Claghorn
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix attaching many uploaded files one at a time
Closes #36806.
上级
5a4305f0
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
26 addition
and
1 deletion
+26
-1
activestorage/lib/active_storage/attached/changes/delete_many.rb
...torage/lib/active_storage/attached/changes/delete_many.rb
+4
-0
activestorage/lib/active_storage/attached/many.rb
activestorage/lib/active_storage/attached/many.rb
+1
-1
activestorage/test/models/attached/many_test.rb
activestorage/test/models/attached/many_test.rb
+21
-0
未找到文件。
activestorage/lib/active_storage/attached/changes/delete_many.rb
浏览文件 @
e3b2a573
...
...
@@ -8,6 +8,10 @@ def initialize(name, record)
@name
,
@record
=
name
,
record
end
def
attachables
[]
end
def
attachments
ActiveStorage
::
Attachment
.
none
end
...
...
activestorage/lib/active_storage/attached/many.rb
浏览文件 @
e3b2a573
...
...
@@ -31,7 +31,7 @@ def attach(*attachables)
if
record
.
persisted?
&&
!
record
.
changed?
record
.
update
(
name
=>
blobs
+
attachables
.
flatten
)
else
record
.
public_send
(
"
#{
name
}
="
,
blobs
+
attachables
.
flatten
)
record
.
public_send
(
"
#{
name
}
="
,
(
change
&
.
attachables
||
blobs
)
+
attachables
.
flatten
)
end
end
...
...
activestorage/test/models/attached/many_test.rb
浏览文件 @
e3b2a573
...
...
@@ -109,6 +109,27 @@ class ActiveStorage::ManyAttachedTest < ActiveSupport::TestCase
assert_equal
"video.mp4"
,
@user
.
highlights
.
second
.
filename
.
to_s
end
test
"attaching new blobs from uploaded files to an existing, changed record one at a time"
do
@user
.
name
=
"Tina"
assert
@user
.
changed?
@user
.
highlights
.
attach
fixture_file_upload
(
"racecar.jpg"
)
@user
.
highlights
.
attach
fixture_file_upload
(
"video.mp4"
)
assert_equal
"racecar.jpg"
,
@user
.
highlights
.
first
.
filename
.
to_s
assert_equal
"video.mp4"
,
@user
.
highlights
.
second
.
filename
.
to_s
assert_not
@user
.
highlights
.
first
.
persisted?
assert_not
@user
.
highlights
.
second
.
persisted?
assert
@user
.
will_save_change_to_name?
assert_not
ActiveStorage
::
Blob
.
service
.
exist?
(
@user
.
highlights
.
first
.
key
)
assert_not
ActiveStorage
::
Blob
.
service
.
exist?
(
@user
.
highlights
.
second
.
key
)
@user
.
save!
assert_equal
"racecar.jpg"
,
@user
.
highlights
.
reload
.
first
.
filename
.
to_s
assert_equal
"video.mp4"
,
@user
.
highlights
.
second
.
filename
.
to_s
assert
ActiveStorage
::
Blob
.
service
.
exist?
(
@user
.
highlights
.
first
.
key
)
assert
ActiveStorage
::
Blob
.
service
.
exist?
(
@user
.
highlights
.
second
.
key
)
end
test
"attaching existing blobs to an existing record one at a time"
do
@user
.
highlights
.
attach
create_blob
(
filename:
"funky.jpg"
)
@user
.
highlights
.
attach
create_blob
(
filename:
"town.jpg"
)
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录