Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
ded9a154
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
ded9a154
编写于
3月 18, 2019
作者:
K
Kasper Timm Hansen
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Simplify values_list with more composition
This also prevents insert_all from leaking its attributes checks.
上级
89fc7fbf
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
30 addition
and
24 deletion
+30
-24
activerecord/lib/active_record/insert_all.rb
activerecord/lib/active_record/insert_all.rb
+30
-24
未找到文件。
activerecord/lib/active_record/insert_all.rb
浏览文件 @
ded9a154
...
...
@@ -35,6 +35,17 @@ def update_duplicates?
on_duplicate
==
:update
end
def
map_key_with_value
inserts
.
map
do
|
attributes
|
attributes
=
attributes
.
stringify_keys
verify_attributes
(
attributes
)
keys
.
map
do
|
key
|
yield
key
,
attributes
[
key
]
end
end
end
private
def
ensure_valid_options_for_connection!
if
returning
&&
!
connection
.
supports_insert_returning?
...
...
@@ -74,6 +85,12 @@ def primary_keys
Array
.
wrap
(
model
.
primary_key
)
end
def
verify_attributes
(
attributes
)
if
keys
!=
attributes
.
keys
.
to_set
raise
ArgumentError
,
"All objects being inserted must have the same keys"
end
end
class
Builder
attr_reader
:model
...
...
@@ -89,23 +106,11 @@ def into
end
def
values_list
columns
=
connection
.
schema_cache
.
columns_hash
(
model
.
table_name
)
keys
=
insert_all
.
keys
verify_columns_exist_for
(
keys
,
columns
)
types
=
keys
.
map
{
|
key
|
[
key
,
connection
.
lookup_cast_type_from_column
(
columns
[
key
])
]
}.
to_h
types
=
extract_types_from_columns_on
(
model
.
table_name
,
keys:
insert_all
.
keys
)
values_list
=
insert_all
.
inserts
.
map
do
|
attributes
|
attributes
=
attributes
.
stringify_keys
unless
attributes
.
keys
.
to_set
==
keys
raise
ArgumentError
,
"All objects being inserted must have the same keys"
end
keys
.
map
do
|
key
|
bind
=
Relation
::
QueryAttribute
.
new
(
key
,
attributes
[
key
],
types
[
key
])
connection
.
with_yaml_fallback
(
bind
.
value_for_database
)
end
values_list
=
insert_all
.
map_key_with_value
do
|
key
,
value
|
bind
=
Relation
::
QueryAttribute
.
new
(
key
,
value
,
types
[
key
])
connection
.
with_yaml_fallback
(
bind
.
value_for_database
)
end
Arel
::
InsertManager
.
new
.
create_values_list
(
values_list
).
to_sql
...
...
@@ -133,16 +138,17 @@ def columns_list
quote_columns
(
insert_all
.
keys
).
join
(
","
)
end
def
quote_columns
(
columns
)
columns
.
map
(
&
connection
.
method
(
:quote_column_name
))
end
def
extract_types_from_columns_on
(
table_name
,
keys
:)
columns
=
connection
.
schema_cache
.
columns_hash
(
table_name
)
def
verify_columns_exist_for
(
keys
,
columns
)
unknown_columns
=
keys
-
columns
.
keys
unknown_column
=
(
keys
-
columns
.
keys
).
first
raise
UnknownAttributeError
.
new
(
model
.
new
,
unknown_column
)
if
unknown_column
if
unknown_columns
.
any?
raise
UnknownAttributeError
.
new
(
model
.
new
,
unknown_columns
.
first
)
end
keys
.
map
{
|
key
|
[
key
,
connection
.
lookup_cast_type_from_column
(
columns
[
key
])
]
}.
to_h
end
def
quote_columns
(
columns
)
columns
.
map
(
&
connection
.
method
(
:quote_column_name
))
end
def
conflict_columns
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录