Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
de9c0ef8
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
de9c0ef8
编写于
3月 26, 2012
作者:
A
Aaron Patterson
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #5561 from carlosantoniodasilva/form-builder-block-arg
Properly deprecate the block argument in AV FormBuilder
上级
045197f4
7a0cf2f5
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
21 addition
and
3 deletion
+21
-3
actionpack/lib/action_view/helpers/form_helper.rb
actionpack/lib/action_view/helpers/form_helper.rb
+9
-3
actionpack/test/template/form_helper_test.rb
actionpack/test/template/form_helper_test.rb
+12
-0
未找到文件。
actionpack/lib/action_view/helpers/form_helper.rb
浏览文件 @
de9c0ef8
...
...
@@ -9,6 +9,7 @@
require
'active_support/core_ext/object/blank'
require
'active_support/core_ext/string/output_safety'
require
'active_support/core_ext/array/extract_options'
require
'active_support/deprecation'
module
ActionView
# = Action View Form Helpers
...
...
@@ -22,7 +23,7 @@ module Helpers
# being routed to the appropriate controller action (with the appropriate <tt>:id</tt>
# parameter in the case of an existing resource), (ii) input fields should
# be named in such a way that in the controller their values appear in the
# appropriate places within the +params+ hash, and (iii) for an existing record,
# appropriate places within the +params+ hash, and (iii) for an existing record,
# when the form is initially displayed, input fields corresponding to attributes
# of the resource should show the current values of those attributes.
#
...
...
@@ -156,7 +157,7 @@ def convert_to_model(object)
# if <tt>:person</tt> also happens to be the name of an instance variable
# <tt>@person</tt>, the default value of the field shown when the form is
# initially displayed (e.g. in the situation where you are editing an
# existing record) will be the value of the corresponding attribute of
# existing record) will be the value of the corresponding attribute of
# <tt>@person</tt>.
#
# The rightmost argument to +form_for+ is an
...
...
@@ -1057,7 +1058,12 @@ def to_model
self
end
def
initialize
(
object_name
,
object
,
template
,
options
)
def
initialize
(
object_name
,
object
,
template
,
options
,
block
=
nil
)
if
block
ActiveSupport
::
Deprecation
.
warn
(
"Giving a block to FormBuilder is deprecated and has no effect anymore."
)
end
@nested_child_index
=
{}
@object_name
,
@object
,
@template
,
@options
=
object_name
,
object
,
template
,
options
@parent_builder
=
options
[
:parent_builder
]
...
...
actionpack/test/template/form_helper_test.rb
浏览文件 @
de9c0ef8
...
...
@@ -2231,6 +2231,18 @@ def test_fields_for_returns_block_result
assert_equal
"fields"
,
output
end
def
test_form_builder_block_argument_deprecation
builder_class
=
Class
.
new
(
ActionView
::
Helpers
::
FormBuilder
)
do
def
initialize
(
object_name
,
object
,
template
,
options
,
block
)
super
end
end
assert_deprecated
/Giving a block to FormBuilder is deprecated and has no effect anymore/
do
builder_class
.
new
(
:foo
,
nil
,
nil
,
{},
proc
{})
end
end
protected
def
hidden_fields
(
method
=
nil
)
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录