Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
d7a1f98d
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
d7a1f98d
编写于
7月 15, 2013
作者:
Y
Yves Senn
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #11282 from arunagw/deprecation-removed-attribute-missing-activerecord
Remove deprecated `attribute_missing`.
上级
ea7620dc
0d4075fb
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
4 addition
and
29 deletion
+4
-29
activerecord/CHANGELOG.md
activerecord/CHANGELOG.md
+4
-0
activerecord/lib/active_record/attribute_methods.rb
activerecord/lib/active_record/attribute_methods.rb
+0
-14
activerecord/test/cases/attribute_methods_test.rb
activerecord/test/cases/attribute_methods_test.rb
+0
-15
未找到文件。
activerecord/CHANGELOG.md
浏览文件 @
d7a1f98d
*
Remove deprecation warning from
`attribute_missing`
for attributes that are columns.
*Arun Agrawal*
*
Remove extra decrement of transaction deep level.
Fixes: #4566
...
...
activerecord/lib/active_record/attribute_methods.rb
浏览文件 @
d7a1f98d
...
...
@@ -176,20 +176,6 @@ def method_missing(method, *args, &block) # :nodoc:
end
end
def
attribute_missing
(
match
,
*
args
,
&
block
)
# :nodoc:
if
self
.
class
.
columns_hash
[
match
.
attr_name
]
ActiveSupport
::
Deprecation
.
warn
(
"The method `
#{
match
.
method_name
}
', matching the attribute `
#{
match
.
attr_name
}
' has "
\
"dispatched through method_missing. This shouldn't happen, because `
#{
match
.
attr_name
}
' "
\
"is a column of the table. If this error has happened through normal usage of Active "
\
"Record (rather than through your own code or external libraries), please report it as "
\
"a bug."
)
end
super
end
# A Person object with a name attribute can ask <tt>person.respond_to?(:name)</tt>,
# <tt>person.respond_to?(:name=)</tt>, and <tt>person.respond_to?(:name?)</tt>
# which will all return +true+. It also define the attribute methods if they have
...
...
activerecord/test/cases/attribute_methods_test.rb
浏览文件 @
d7a1f98d
...
...
@@ -759,21 +759,6 @@ def test_instance_method_should_be_defined_on_the_base_class
assert
subklass
.
method_defined?
(
:id
),
"subklass is missing id method"
end
def
test_dispatching_column_attributes_through_method_missing_deprecated
Topic
.
define_attribute_methods
topic
=
Topic
.
new
(
:id
=>
5
)
topic
.
id
=
5
topic
.
method
(
:id
).
owner
.
send
(
:undef_method
,
:id
)
assert_deprecated
do
assert_equal
5
,
topic
.
id
end
ensure
Topic
.
undefine_attribute_methods
end
def
test_read_attribute_with_nil_should_not_asplode
assert_equal
nil
,
Topic
.
new
.
read_attribute
(
nil
)
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录