Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
d597569d
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
d597569d
编写于
7月 18, 2018
作者:
R
Rafael França
提交者:
Rafael Mendonça França
7月 18, 2018
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Merge pull request #31320 from gtqnchev/to_form_params-fix
Fix issue with `button_to`'s `to_form_params`
上级
dae9ffe7
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
21 addition
and
3 deletion
+21
-3
actionview/CHANGELOG.md
actionview/CHANGELOG.md
+11
-0
actionview/lib/action_view/helpers/url_helper.rb
actionview/lib/action_view/helpers/url_helper.rb
+2
-2
actionview/test/template/url_helper_test.rb
actionview/test/template/url_helper_test.rb
+8
-1
未找到文件。
actionview/CHANGELOG.md
浏览文件 @
d597569d
*
Fix issue with
`button_to`
's
`to_form_params`
`button_to` was throwing exception when invoked with `params` hash that
contains symbol and string keys. The reason for the exception was that
`to_form_params` was comparing the given symbol and string keys.
The issue is fixed by turning all keys to strings inside
`to_form_params` before comparing them.
*Georgi Georgiev*
*
Fix JavaScript views rendering does not work with Firefox when using
Content Security Policy.
...
...
actionview/lib/action_view/helpers/url_helper.rb
浏览文件 @
d597569d
...
...
@@ -634,7 +634,7 @@ def method_tag(method)
# suitable for use as the names and values of form input fields:
#
# to_form_params(name: 'David', nationality: 'Danish')
# # => [{name:
:name
, value: 'David'}, {name: 'nationality', value: 'Danish'}]
# # => [{name:
'name'
, value: 'David'}, {name: 'nationality', value: 'Danish'}]
#
# to_form_params(country: {name: 'Denmark'})
# # => [{name: 'country[name]', value: 'Denmark'}]
...
...
@@ -666,7 +666,7 @@ def to_form_params(attribute, namespace = nil)
params
.
push
(
*
to_form_params
(
value
,
array_prefix
))
end
else
params
<<
{
name:
namespace
,
value:
attribute
.
to_param
}
params
<<
{
name:
namespace
.
to_s
,
value:
attribute
.
to_param
}
end
params
.
sort_by
{
|
pair
|
pair
[
:name
]
}
...
...
actionview/test/template/url_helper_test.rb
浏览文件 @
d597569d
...
...
@@ -77,11 +77,18 @@ def test_url_for_with_invalid_referer
def
test_to_form_params_with_hash
assert_equal
(
[{
name:
:name
,
value:
"David"
},
{
name: :nationality
,
value:
"Danish"
}],
[{
name:
"name"
,
value:
"David"
},
{
name:
"nationality"
,
value:
"Danish"
}],
to_form_params
(
name:
"David"
,
nationality:
"Danish"
)
)
end
def
test_to_form_params_with_hash_having_symbol_and_string_keys
assert_equal
(
[{
name:
"name"
,
value:
"David"
},
{
name:
"nationality"
,
value:
"Danish"
}],
to_form_params
(
"name"
=>
"David"
,
:nationality
=>
"Danish"
)
)
end
def
test_to_form_params_with_nested_hash
assert_equal
(
[{
name:
"country[name]"
,
value:
"Denmark"
}],
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录