Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
d3567824
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
d3567824
编写于
11月 26, 2013
作者:
Y
Yves Senn
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #13018 from heruku/scoping_fix
changed update counter to act on unscoped model
上级
36697040
45d4d141
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
19 addition
and
1 deletion
+19
-1
activerecord/CHANGELOG.md
activerecord/CHANGELOG.md
+6
-0
activerecord/lib/active_record/counter_cache.rb
activerecord/lib/active_record/counter_cache.rb
+1
-1
activerecord/test/cases/associations/has_many_associations_test.rb
...ord/test/cases/associations/has_many_associations_test.rb
+8
-0
activerecord/test/models/topic.rb
activerecord/test/models/topic.rb
+4
-0
未找到文件。
activerecord/CHANGELOG.md
浏览文件 @
d3567824
*
Update counter cache on a has_many relationship regardless of default scope
Fix #12952.
*Uku Taht*
*
`rename_index`
adds the new index before removing the old one. This allows
to rename indexes on columns with a foreign key and prevents the following error:
...
...
activerecord/lib/active_record/counter_cache.rb
浏览文件 @
d3567824
...
...
@@ -77,7 +77,7 @@ def update_counters(id, counters)
"
#{
quoted_column
}
= COALESCE(
#{
quoted_column
}
, 0)
#{
operator
}
#{
value
.
abs
}
"
end
where
(
primary_key
=>
id
).
update_all
updates
.
join
(
', '
)
unscoped
.
where
(
primary_key
=>
id
).
update_all
updates
.
join
(
', '
)
end
# Increment a numeric field by one, via a direct SQL update.
...
...
activerecord/test/cases/associations/has_many_associations_test.rb
浏览文件 @
d3567824
...
...
@@ -1781,4 +1781,12 @@ def test_collection_association_with_private_kernel_method
assert_equal
[
original_child
],
car
.
reload
.
failed_bulbs
end
test
'updates counter cache when default scope is given'
do
topic
=
DefaultRejectedTopic
.
create
approved:
true
assert_difference
"topic.reload.replies_count"
,
1
do
topic
.
approved_replies
.
create!
end
end
end
activerecord/test/models/topic.rb
浏览文件 @
d3567824
...
...
@@ -106,6 +106,10 @@ class ImportantTopic < Topic
serialize
:important
,
Hash
end
class
DefaultRejectedTopic
<
Topic
default_scope
->
{
where
(
approved:
false
)
}
end
class
BlankTopic
<
Topic
# declared here to make sure that dynamic finder with a bang can find a model that responds to `blank?`
def
blank?
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录