Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
d3494903
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
d3494903
编写于
10月 31, 2012
作者:
D
David Heinemeier Hansson
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Revert "Don't allocate new strings in compiled attribute methods"
This reverts commit
f1765019
.
上级
750a30b1
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
20 addition
and
39 deletion
+20
-39
activerecord/lib/active_record/attribute_methods/read.rb
activerecord/lib/active_record/attribute_methods/read.rb
+12
-27
activerecord/lib/active_record/attribute_methods/write.rb
activerecord/lib/active_record/attribute_methods/write.rb
+8
-12
未找到文件。
activerecord/lib/active_record/attribute_methods/read.rb
浏览文件 @
d3494903
...
...
@@ -32,36 +32,21 @@ def cache_attribute?(attr_name)
protected
# We want to generate the methods via module_eval rather than
#
define_method, because define_method is slower on dispatch and
#
uses more memory (because it
creates a closure).
# We want to generate the methods via module_eval rather than
define_method,
#
because define_method is slower on dispatch and uses more memory (because it
# creates a closure).
#
# But sometimes the database might return columns with
# characters that are not allowed in normal method names (like
# 'my_column(omg)'. So to work around this we first define with
# the __temp__ identifier, and then use alias method to rename
# it to what we want.
#
# We are also defining a constant to hold the frozen string of
# the attribute name. Using a constant means that we do not have
# to allocate an object on each call to the attribute method.
# Making it frozen means that it doesn't get duped when used to
# key the @attributes_cache in read_attribute.
def
define_method_attribute
(
name
)
safe_name
=
name
.
unpack
(
'h*'
).
first
# But sometimes the database might return columns with characters that are not
# allowed in normal method names (like 'my_column(omg)'. So to work around this
# we first define with the __temp__ identifier, and then use alias method to
# rename it to what we want.
def
define_method_attribute
(
attr_name
)
generated_attribute_methods
.
module_eval
<<-
STR
,
__FILE__
,
__LINE__
+
1
module AttrNames
unless defined? ATTR_
#{
safe_name
}
ATTR_
#{
safe_name
}
=
#{
name
.
inspect
}
.freeze
end
def __temp__
read_attribute('
#{
attr_name
}
') { |n| missing_attribute(n, caller) }
end
def __temp__
#{
safe_name
}
read_attribute(AttrNames::ATTR_
#{
safe_name
}
) { |n| missing_attribute(n, caller) }
end
alias_method
#{
name
.
inspect
}
, :__temp__
#{
safe_name
}
undef_method :__temp__
#{
safe_name
}
alias_method '
#{
attr_name
}
', :__temp__
undef_method :__temp__
STR
end
...
...
activerecord/lib/active_record/attribute_methods/write.rb
浏览文件 @
d3494903
...
...
@@ -9,19 +9,15 @@ module Write
module
ClassMethods
protected
# See define_method_attribute in read.rb for an explanation of
# this code.
def
define_method_attribute
=
(
name
)
safe_name
=
name
.
unpack
(
'h*'
).
first
generated_attribute_methods
.
module_eval
<<-
STR
,
__FILE__
,
__LINE__
+
1
def __temp__
#{
safe_name
}
=(value)
write_attribute(AttrNames::ATTR_
#{
safe_name
}
, value)
def
define_method_attribute
=
(
attr_name
)
if
attr_name
=~
ActiveModel
::
AttributeMethods
::
NAME_COMPILABLE_REGEXP
generated_attribute_methods
.
module_eval
(
"def
#{
attr_name
}
=(new_value); write_attribute('
#{
attr_name
}
', new_value); end"
,
__FILE__
,
__LINE__
)
else
generated_attribute_methods
.
send
(
:define_method
,
"
#{
attr_name
}
="
)
do
|
new_value
|
write_attribute
(
attr_name
,
new_value
)
end
end
alias_method
#{
(
name
+
'='
).
inspect
}
, :__temp__
#{
safe_name
}
=
undef_method :__temp__
#{
safe_name
}
=
STR
end
end
end
# Updates the attribute identified by <tt>attr_name</tt> with the
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录