Merge pull request #17324 from vipulnsward/activejob-warnings

Enable emitting of warnings from ActiveJob tests.

activejob/Rakefile

@@ -35,6 +35,7 @@ namespace :test do
       t.libs << 'test'
       t.test_files = FileList['test/cases/**/*_test.rb']
       t.verbose = true
+      t.warning = true
       t.ruby_opts = ["--dev"] if defined?(JRUBY_VERSION)
     end
 
@@ -53,6 +54,7 @@ namespace :test do
         t.libs << 'test'
         t.test_files = FileList['test/integration/**/*_test.rb']
         t.verbose = true
+        t.warning = true
         t.ruby_opts = ["--dev"] if defined?(JRUBY_VERSION)
       end
     end

activejob/test/support/integration/adapters/backburner.rb

@@ -29,7 +29,7 @@ def tube
   def can_run?
     begin
       Backburner::Worker.connection.send :connect!
-    rescue => e
+    rescue
       return false
     end
     true

activejob/test/support/integration/adapters/qu.rb

@@ -30,7 +30,7 @@ def stop_workers
   def can_run?
     begin
       Qu.backend.connection.client.connect
-    rescue => e
+    rescue
       return false
     end
     true

activejob/test/support/integration/adapters/resque.rb

@@ -41,7 +41,7 @@ def stop_workers
   def can_run?
     begin
       Resque.redis.client.connect
-    rescue => e
+    rescue
       return false
     end
     true

activejob/test/support/integration/adapters/sidekiq.rb

@@ -49,7 +49,7 @@ def stop_workers
   def can_run?
     begin
       Sidekiq.redis { |conn| conn.connect }
-    rescue => e
+    rescue
       return false
     end
     true

activejob/test/support/integration/adapters/sneakers.rb

@@ -68,7 +68,7 @@ def stop_workers
   def can_run?
     begin
       bunny_publisher
-    rescue => e
+    rescue
       return false
     end
     true