It's not needed to initialize the attr when calling mattr_writer

cebe5c2f · Santiago Pastorino · Aaron Patterson · 7aec9f9c · cebe5c2f
隐藏空白更改
内联并排

Showing with 1 addition and 7 deletion

activesupport/lib/active_support/core_ext/module/attribute_accessors.rb ...lib/active_support/core_ext/module/attribute_accessors.rb +1 -7

未找到文件。
--- a/activesupport/lib/active_support/core_ext/module/attribute_accessors.rb
+++ b/activesupport/lib/active_support/core_ext/module/attribute_accessors.rb
@@ -5,9 +5,7 @@ def mattr_reader(*syms)
    options = syms.extract_options!
    syms.each do |sym|
      class_eval(<<-EOS, __FILE__, __LINE__ + 1)
-        unless defined? @@#{sym}
-          @@#{sym} = nil
-        end
+        @@#{sym} = nil unless defined? @@#{sym}

        def self.#{sym}
          @@#{sym}
@@ -28,10 +26,6 @@ def mattr_writer(*syms)
    options = syms.extract_options!
    syms.each do |sym|
      class_eval(<<-EOS, __FILE__, __LINE__ + 1)
-        unless defined? @@#{sym}
-          @@#{sym} = nil
-        end
-
        def self.#{sym}=(obj)
          @@#{sym} = obj
        end