Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
c327f4dc
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
c327f4dc
编写于
2月 05, 2018
作者:
F
fatkodima
提交者:
Jeremy Daer
2月 05, 2018
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Add missing instrumentation to RedisCacheStore#read_multi
上级
87238c3e
变更
7
隐藏空白更改
内联
并排
Showing
7 changed file
with
25 addition
and
18 deletion
+25
-18
activesupport/lib/active_support/cache/redis_cache_store.rb
activesupport/lib/active_support/cache/redis_cache_store.rb
+5
-1
activesupport/test/cache/behaviors.rb
activesupport/test/cache/behaviors.rb
+1
-0
activesupport/test/cache/behaviors/cache_instrumentation_behavior.rb
...rt/test/cache/behaviors/cache_instrumentation_behavior.rb
+15
-17
activesupport/test/cache/stores/file_store_test.rb
activesupport/test/cache/stores/file_store_test.rb
+1
-0
activesupport/test/cache/stores/mem_cache_store_test.rb
activesupport/test/cache/stores/mem_cache_store_test.rb
+1
-0
activesupport/test/cache/stores/memory_store_test.rb
activesupport/test/cache/stores/memory_store_test.rb
+1
-0
activesupport/test/cache/stores/redis_cache_store_test.rb
activesupport/test/cache/stores/redis_cache_store_test.rb
+1
-0
未找到文件。
activesupport/lib/active_support/cache/redis_cache_store.rb
浏览文件 @
c327f4dc
...
...
@@ -187,7 +187,11 @@ def inspect
# fetched values.
def
read_multi
(
*
names
)
if
mget_capable?
read_multi_mget
(
*
names
)
instrument
(
:read_multi
,
names
,
options
)
do
|
payload
|
read_multi_mget
(
*
names
).
tap
do
|
results
|
payload
[
:hits
]
=
results
.
keys
end
end
else
super
end
...
...
activesupport/test/cache/behaviors.rb
浏览文件 @
c327f4dc
...
...
@@ -3,6 +3,7 @@
require_relative
"behaviors/autoloading_cache_behavior"
require_relative
"behaviors/cache_delete_matched_behavior"
require_relative
"behaviors/cache_increment_decrement_behavior"
require_relative
"behaviors/cache_instrumentation_behavior"
require_relative
"behaviors/cache_store_behavior"
require_relative
"behaviors/cache_store_version_behavior"
require_relative
"behaviors/connection_pool_behavior"
...
...
activesupport/test/cache/
cache_store_write_multi_test
.rb
→
activesupport/test/cache/
behaviors/cache_instrumentation_behavior
.rb
浏览文件 @
c327f4dc
# frozen_string_literal: true
require
"abstract_unit"
require
"active_support/cache"
class
CacheStoreWriteMultiEntriesStoreProviderInterfaceTest
<
ActiveSupport
::
TestCase
setup
do
@cache
=
ActiveSupport
::
Cache
.
lookup_store
(
:null_store
)
end
test
"fetch_multi uses write_multi_entries store provider interface"
do
module
CacheInstrumentationBehavior
def
test_fetch_multi_uses_write_multi_entries_store_provider_interface
assert_called_with
(
@cache
,
:write_multi_entries
)
do
@cache
.
fetch_multi
"a"
,
"b"
,
"c"
do
|
key
|
key
*
2
end
end
end
end
class
CacheStoreWriteMultiInstrumentationTest
<
ActiveSupport
::
TestCase
setup
do
@cache
=
ActiveSupport
::
Cache
.
lookup_store
(
:memory_store
)
end
test
"instrumentation"
do
def
test_write_multi_instrumentation
writes
=
{
"a"
=>
"aa"
,
"b"
=>
"bb"
}
events
=
with_instrumentation
"write_multi"
do
...
...
@@ -34,7 +21,7 @@ class CacheStoreWriteMultiInstrumentationTest < ActiveSupport::TestCase
assert_equal
({
"a"
=>
"aa"
,
"b"
=>
"bb"
},
events
[
0
].
payload
[
:key
])
end
test
"instrumentation with fetch_multi as super operation"
do
def
test_instrumentation_with_fetch_multi_as_super_operation
@cache
.
write
(
"b"
,
"bb"
)
events
=
with_instrumentation
"read_multi"
do
...
...
@@ -46,6 +33,17 @@ class CacheStoreWriteMultiInstrumentationTest < ActiveSupport::TestCase
assert_equal
[
"b"
],
events
[
0
].
payload
[
:hits
]
end
def
test_read_multi_instrumentation
@cache
.
write
(
"b"
,
"bb"
)
events
=
with_instrumentation
"read_multi"
do
@cache
.
read_multi
(
"a"
,
"b"
)
{
|
key
|
key
*
2
}
end
assert_equal
%w[ cache_read_multi.active_support ]
,
events
.
map
(
&
:name
)
assert_equal
[
"b"
],
events
[
0
].
payload
[
:hits
]
end
private
def
with_instrumentation
(
method
)
event_name
=
"cache_
#{
method
}
.active_support"
...
...
activesupport/test/cache/stores/file_store_test.rb
浏览文件 @
c327f4dc
...
...
@@ -30,6 +30,7 @@ def cache_dir
include
LocalCacheBehavior
include
CacheDeleteMatchedBehavior
include
CacheIncrementDecrementBehavior
include
CacheInstrumentationBehavior
include
AutoloadingCacheBehavior
def
test_clear
...
...
activesupport/test/cache/stores/mem_cache_store_test.rb
浏览文件 @
c327f4dc
...
...
@@ -49,6 +49,7 @@ def setup
include
CacheStoreVersionBehavior
include
LocalCacheBehavior
include
CacheIncrementDecrementBehavior
include
CacheInstrumentationBehavior
include
EncodedKeyCacheBehavior
include
AutoloadingCacheBehavior
include
ConnectionPoolBehavior
...
...
activesupport/test/cache/stores/memory_store_test.rb
浏览文件 @
c327f4dc
...
...
@@ -14,6 +14,7 @@ def setup
include
CacheStoreVersionBehavior
include
CacheDeleteMatchedBehavior
include
CacheIncrementDecrementBehavior
include
CacheInstrumentationBehavior
def
test_prune_size
@cache
.
write
(
1
,
"aaaaaaaaaa"
)
&&
sleep
(
0.001
)
...
...
activesupport/test/cache/stores/redis_cache_store_test.rb
浏览文件 @
c327f4dc
...
...
@@ -107,6 +107,7 @@ class RedisCacheStoreCommonBehaviorTest < StoreTest
include
CacheStoreVersionBehavior
include
LocalCacheBehavior
include
CacheIncrementDecrementBehavior
include
CacheInstrumentationBehavior
include
AutoloadingCacheBehavior
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录