Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
bde898c1
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
bde898c1
编写于
12月 11, 2018
作者:
R
Ryuta Kamizono
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Prevent write queries for `exec_query`
Follow up #34505.
上级
bad1041b
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
46 addition
and
1 deletion
+46
-1
activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb
...b/active_record/connection_adapters/postgresql_adapter.rb
+4
-0
activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb
.../lib/active_record/connection_adapters/sqlite3_adapter.rb
+5
-1
activerecord/test/cases/adapter_test.rb
activerecord/test/cases/adapter_test.rb
+37
-0
未找到文件。
activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb
浏览文件 @
bde898c1
...
...
@@ -609,6 +609,10 @@ def load_additional_types(oids = nil)
FEATURE_NOT_SUPPORTED
=
"0A000"
#:nodoc:
def
execute_and_clear
(
sql
,
name
,
binds
,
prepare:
false
)
if
preventing_writes?
&&
write_query?
(
sql
)
raise
ActiveRecord
::
ReadOnlyError
,
"Write query attempted while in readonly mode:
#{
sql
}
"
end
if
without_prepared_statement?
(
binds
)
result
=
exec_no_cache
(
sql
,
name
,
[])
elsif
!
prepare
...
...
activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb
浏览文件 @
bde898c1
...
...
@@ -209,7 +209,7 @@ def disable_referential_integrity # :nodoc:
# DATABASE STATEMENTS ======================================
#++
READ_QUERY
=
ActiveRecord
::
ConnectionAdapters
::
AbstractAdapter
.
build_read_query_regexp
(
:select
)
# :nodoc:
READ_QUERY
=
ActiveRecord
::
ConnectionAdapters
::
AbstractAdapter
.
build_read_query_regexp
(
:select
,
:pragma
)
# :nodoc:
private_constant
:READ_QUERY
def
write_query?
(
sql
)
# :nodoc:
...
...
@@ -222,6 +222,10 @@ def explain(arel, binds = [])
end
def
exec_query
(
sql
,
name
=
nil
,
binds
=
[],
prepare:
false
)
if
preventing_writes?
&&
write_query?
(
sql
)
raise
ActiveRecord
::
ReadOnlyError
,
"Write query attempted while in readonly mode:
#{
sql
}
"
end
materialize_transactions
type_casted_binds
=
type_casted_binds
(
binds
)
...
...
activerecord/test/cases/adapter_test.rb
浏览文件 @
bde898c1
...
...
@@ -165,6 +165,43 @@ class << @connection
end
end
def
test_errors_when_an_insert_query_is_called_while_preventing_writes
assert_raises
(
ActiveRecord
::
ReadOnlyError
)
do
@connection
.
while_preventing_writes
do
@connection
.
insert
(
"INSERT INTO subscribers(nick) VALUES ('138853948594')"
)
end
end
end
def
test_errors_when_an_update_query_is_called_while_preventing_writes
@connection
.
insert
(
"INSERT INTO subscribers(nick) VALUES ('138853948594')"
)
assert_raises
(
ActiveRecord
::
ReadOnlyError
)
do
@connection
.
while_preventing_writes
do
@connection
.
update
(
"UPDATE subscribers SET nick = '9989' WHERE nick = '138853948594'"
)
end
end
end
def
test_errors_when_a_delete_query_is_called_while_preventing_writes
@connection
.
insert
(
"INSERT INTO subscribers(nick) VALUES ('138853948594')"
)
assert_raises
(
ActiveRecord
::
ReadOnlyError
)
do
@connection
.
while_preventing_writes
do
@connection
.
delete
(
"DELETE FROM subscribers WHERE nick = '138853948594'"
)
end
end
end
def
test_doesnt_error_when_a_select_query_is_called_while_preventing_writes
@connection
.
insert
(
"INSERT INTO subscribers(nick) VALUES ('138853948594')"
)
@connection
.
while_preventing_writes
do
result
=
@connection
.
select_all
(
"SELECT subscribers.* FROM subscribers WHERE nick = '138853948594'"
)
assert_equal
1
,
result
.
length
end
end
def
test_uniqueness_violations_are_translated_to_specific_exception
@connection
.
execute
"INSERT INTO subscribers(nick) VALUES('me')"
error
=
assert_raises
(
ActiveRecord
::
RecordNotUnique
)
do
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录