Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
bcf0e08a
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
bcf0e08a
编写于
2月 07, 2013
作者:
M
Michael Koziarski
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #9220 from robertomiranda/where-with-empty-hash
Active Record: Change behaviour with empty hash in where clause
上级
f1637492
e1700141
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
11 addition
and
3 deletion
+11
-3
activerecord/CHANGELOG.md
activerecord/CHANGELOG.md
+4
-0
activerecord/lib/active_record/relation/predicate_builder.rb
activerecord/lib/active_record/relation/predicate_builder.rb
+1
-1
activerecord/test/cases/relation/where_test.rb
activerecord/test/cases/relation/where_test.rb
+6
-2
未找到文件。
activerecord/CHANGELOG.md
浏览文件 @
bcf0e08a
## Rails 4.0.0 (unreleased) ##
*
Raise ArgumentError instead of generate invalid SQL when empty hash is used in where clause value
Roberto Miranda
*
Quote numeric values being compared to non-numeric columns. Otherwise,
in some database, the string column values will be coerced to a numeric
allowing 0, 0.0 or false to match any string starting with a non-digit.
...
...
activerecord/lib/active_record/relation/predicate_builder.rb
浏览文件 @
bcf0e08a
...
...
@@ -8,7 +8,7 @@ def self.build_from_hash(klass, attributes, default_table)
if
value
.
is_a?
(
Hash
)
if
value
.
empty?
queries
<<
'1 = 2'
raise
ArgumentError
,
"Condition value in SQL clause can't be an empty hash"
else
table
=
Arel
::
Table
.
new
(
column
,
default_table
.
engine
)
association
=
klass
.
reflect_on_association
(
column
.
to_sym
)
...
...
activerecord/test/cases/relation/where_test.rb
浏览文件 @
bcf0e08a
...
...
@@ -92,7 +92,9 @@ def test_where_with_table_name
end
def
test_where_with_table_name_and_empty_hash
assert_equal
0
,
Post
.
where
(
:posts
=>
{}).
count
assert_raises
(
ArgumentError
)
do
Post
.
where
(
:posts
=>
{})
end
end
def
test_where_with_table_name_and_empty_array
...
...
@@ -100,7 +102,9 @@ def test_where_with_table_name_and_empty_array
end
def
test_where_with_empty_hash_and_no_foreign_key
assert_equal
0
,
Edge
.
where
(
:sink
=>
{}).
count
assert_raises
(
ArgumentError
)
do
Edge
.
where
(
:sink
=>
{}).
count
end
end
def
test_where_with_blank_conditions
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录