Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
b6dd0c4d
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
b6dd0c4d
编写于
2月 08, 2015
作者:
A
Andrew White
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #18764 from tsun1215/master
Explicitly ignored wildcard verbs from head_routes
上级
de9a3748
b9c63b0a
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
33 addition
and
0 deletion
+33
-0
actionpack/CHANGELOG.md
actionpack/CHANGELOG.md
+20
-0
actionpack/lib/action_dispatch/journey/router.rb
actionpack/lib/action_dispatch/journey/router.rb
+1
-0
actionpack/test/dispatch/routing_test.rb
actionpack/test/dispatch/routing_test.rb
+12
-0
未找到文件。
actionpack/CHANGELOG.md
浏览文件 @
b6dd0c4d
*
Explicitly ignored wildcard verbs when searching for HEAD routes before fallback
Fixes an issue where a mounted rack app at root would intercept the HEAD
request causing an incorrect behavior during the fall back to GET requests.
Example:
```ruby
draw do
get '/home' => 'test#index'
mount rack_app, at: '/'
end
head '/home'
assert_response :success
```
In this case, a HEAD request runs through the routes the first time and fails
to match anything. Then, it runs through the list with the fallback and matches
`get '/home'`. The original behavior would match the rack app in the first pass.
*Terence Sun*
*
Migrating xhr methods to keyword arguments syntax
in
`ActionController::TestCase`
and
`ActionDispatch::Integration`
...
...
actionpack/lib/action_dispatch/journey/router.rb
浏览文件 @
b6dd0c4d
...
...
@@ -121,6 +121,7 @@ def find_routes req
end
def
match_head_routes
(
routes
,
req
)
routes
.
delete_if
{
|
route
|
route
.
verb
==
//
}
head_routes
=
match_routes
(
routes
,
req
)
if
head_routes
.
empty?
...
...
actionpack/test/dispatch/routing_test.rb
浏览文件 @
b6dd0c4d
...
...
@@ -3477,6 +3477,18 @@ def test_scope_where_as_is_empty
assert_equal
'/post/comments/new'
,
new_comment_path
end
def
test_head_fetch_with_mount_on_root
draw
do
get
'/home'
=>
'test#index'
mount
lambda
{
|
env
|
[
404
,
{
"Content-Type"
=>
"text/html"
},
[
"testing"
]]
},
at:
'/'
end
head
'/home'
assert_response
:success
head
'/'
assert_response
:not_found
end
private
def
draw
(
&
block
)
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录