Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
af0caadb
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
af0caadb
编写于
12月 15, 2017
作者:
G
George Claghorn
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Handle invalid signed blob IDs gracefully
上级
ca2c4cb7
变更
7
隐藏空白更改
内联
并排
Showing
7 changed file
with
51 addition
and
18 deletion
+51
-18
activestorage/app/controllers/active_storage/blobs_controller.rb
...torage/app/controllers/active_storage/blobs_controller.rb
+4
-6
activestorage/app/controllers/active_storage/previews_controller.rb
...age/app/controllers/active_storage/previews_controller.rb
+4
-6
activestorage/app/controllers/active_storage/variants_controller.rb
...age/app/controllers/active_storage/variants_controller.rb
+4
-6
activestorage/app/controllers/concerns/active_storage/set_blob.rb
...orage/app/controllers/concerns/active_storage/set_blob.rb
+16
-0
activestorage/test/controllers/blobs_controller_test.rb
activestorage/test/controllers/blobs_controller_test.rb
+5
-0
activestorage/test/controllers/previews_controller_test.rb
activestorage/test/controllers/previews_controller_test.rb
+9
-0
activestorage/test/controllers/variants_controller_test.rb
activestorage/test/controllers/variants_controller_test.rb
+9
-0
未找到文件。
activestorage/app/controllers/active_storage/blobs_controller.rb
浏览文件 @
af0caadb
...
...
@@ -5,12 +5,10 @@
# security-through-obscurity factor of the signed blob references, you'll need to implement your own
# authenticated redirection controller.
class
ActiveStorage::BlobsController
<
ActionController
::
Base
include
ActiveStorage
::
SetBlob
def
show
if
blob
=
ActiveStorage
::
Blob
.
find_signed
(
params
[
:signed_id
])
expires_in
ActiveStorage
::
Blob
.
service
.
url_expires_in
redirect_to
blob
.
service_url
(
disposition:
params
[
:disposition
])
else
head
:not_found
end
expires_in
ActiveStorage
::
Blob
.
service
.
url_expires_in
redirect_to
@blob
.
service_url
(
disposition:
params
[
:disposition
])
end
end
activestorage/app/controllers/active_storage/previews_controller.rb
浏览文件 @
af0caadb
# frozen_string_literal: true
class
ActiveStorage::PreviewsController
<
ActionController
::
Base
include
ActiveStorage
::
SetBlob
def
show
if
blob
=
ActiveStorage
::
Blob
.
find_signed
(
params
[
:signed_blob_id
])
expires_in
ActiveStorage
::
Blob
.
service
.
url_expires_in
redirect_to
ActiveStorage
::
Preview
.
new
(
blob
,
params
[
:variation_key
]).
processed
.
service_url
(
disposition:
params
[
:disposition
])
else
head
:not_found
end
expires_in
ActiveStorage
::
Blob
.
service
.
url_expires_in
redirect_to
ActiveStorage
::
Preview
.
new
(
@blob
,
params
[
:variation_key
]).
processed
.
service_url
(
disposition:
params
[
:disposition
])
end
end
activestorage/app/controllers/active_storage/variants_controller.rb
浏览文件 @
af0caadb
...
...
@@ -5,12 +5,10 @@
# security-through-obscurity factor of the signed blob and variation reference, you'll need to implement your own
# authenticated redirection controller.
class
ActiveStorage::VariantsController
<
ActionController
::
Base
include
ActiveStorage
::
SetBlob
def
show
if
blob
=
ActiveStorage
::
Blob
.
find_signed
(
params
[
:signed_blob_id
])
expires_in
ActiveStorage
::
Blob
.
service
.
url_expires_in
redirect_to
ActiveStorage
::
Variant
.
new
(
blob
,
params
[
:variation_key
]).
processed
.
service_url
(
disposition:
params
[
:disposition
])
else
head
:not_found
end
expires_in
ActiveStorage
::
Blob
.
service
.
url_expires_in
redirect_to
ActiveStorage
::
Variant
.
new
(
@blob
,
params
[
:variation_key
]).
processed
.
service_url
(
disposition:
params
[
:disposition
])
end
end
activestorage/app/controllers/concerns/active_storage/set_blob.rb
0 → 100644
浏览文件 @
af0caadb
# frozen_string_literal: true
module
ActiveStorage::SetBlob
extend
ActiveSupport
::
Concern
included
do
before_action
:set_blob
end
private
def
set_blob
@blob
=
ActiveStorage
::
Blob
.
find_signed
(
params
[
:signed_blob_id
]
||
params
[
:signed_id
])
rescue
ActiveSupport
::
MessageVerifier
::
InvalidSignature
head
:not_found
end
end
activestorage/test/controllers/blobs_controller_test.rb
浏览文件 @
af0caadb
...
...
@@ -8,6 +8,11 @@ class ActiveStorage::BlobsControllerTest < ActionDispatch::IntegrationTest
@blob
=
create_file_blob
filename:
"racecar.jpg"
end
test
"showing blob with invalid signed ID"
do
get
rails_service_blob_url
(
"invalid"
,
"racecar.jpg"
)
assert_response
:not_found
end
test
"showing blob utilizes browser caching"
do
get
rails_blob_url
(
@blob
)
...
...
activestorage/test/controllers/previews_controller_test.rb
浏览文件 @
af0caadb
...
...
@@ -21,4 +21,13 @@ class ActiveStorage::PreviewsControllerTest < ActionDispatch::IntegrationTest
assert_equal
77
,
image
.
width
assert_equal
100
,
image
.
height
end
test
"showing preview with invalid signed blob ID"
do
get
rails_blob_preview_url
(
filename:
@blob
.
filename
,
signed_blob_id:
"invalid"
,
variation_key:
ActiveStorage
::
Variation
.
encode
(
resize:
"100x100"
))
assert_response
:not_found
end
end
activestorage/test/controllers/variants_controller_test.rb
浏览文件 @
af0caadb
...
...
@@ -20,4 +20,13 @@ class ActiveStorage::VariantsControllerTest < ActionDispatch::IntegrationTest
assert_equal
100
,
image
.
width
assert_equal
67
,
image
.
height
end
test
"showing variant with invalid signed blob ID"
do
get
rails_blob_variation_url
(
filename:
@blob
.
filename
,
signed_blob_id:
"invalid"
,
variation_key:
ActiveStorage
::
Variation
.
encode
(
resize:
"100x100"
))
assert_response
:not_found
end
end
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录