Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
a8f6662d
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
a8f6662d
编写于
7月 14, 2013
作者:
V
Vipul A M
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Remove deprecated calls to `SelectManage#insert` with preference to using `compile_insert`
上级
27330eba
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
0 addition
and
39 deletion
+0
-39
lib/arel/select_manager.rb
lib/arel/select_manager.rb
+0
-25
test/test_select_manager.rb
test/test_select_manager.rb
+0
-14
未找到文件。
lib/arel/select_manager.rb
浏览文件 @
a8f6662d
...
...
@@ -264,31 +264,6 @@ def to_a # :nodoc:
@engine
.
connection
.
send
(
:select
,
to_sql
,
'AREL'
).
map
{
|
x
|
Row
.
new
(
x
)
}
end
# FIXME: this method should go away
def
insert
values
if
$VERBOSE
warn
<<-
eowarn
insert (
#{
caller
.
first
}
) is deprecated and will be removed in Arel 4.0.0. Please
switch to `compile_insert`
eowarn
end
im
=
compile_insert
(
values
)
table
=
@ctx
.
froms
primary_key
=
table
.
primary_key
primary_key_name
=
primary_key
.
name
if
primary_key
# FIXME: in AR tests values sometimes were Array and not Hash therefore is_a?(Hash) check is added
primary_key_value
=
primary_key
&&
values
.
is_a?
(
Hash
)
&&
values
[
primary_key
]
im
.
into
table
# Oracle adapter needs primary key name to generate RETURNING ... INTO ... clause
# for tables which assign primary key value using trigger.
# RETURNING ... INTO ... clause will be added only if primary_key_value is nil
# therefore it is necessary to pass primary key value as well
@engine
.
connection
.
insert
im
.
to_sql
,
'AREL'
,
primary_key_name
,
primary_key_value
end
private
def
collapse
exprs
,
existing
=
nil
exprs
=
exprs
.
unshift
(
existing
.
expr
)
if
existing
...
...
test/test_select_manager.rb
浏览文件 @
a8f6662d
...
...
@@ -435,20 +435,6 @@ def test_join_sources
end
end
describe
'insert'
do
it
'uses the select FROM'
do
engine
=
EngineProxy
.
new
Table
.
engine
table
=
Table
.
new
:users
manager
=
Arel
::
SelectManager
.
new
engine
manager
.
from
table
manager
.
insert
'VALUES(NULL)'
engine
.
executed
.
last
.
must_be_like
%{
INSERT INTO "users" VALUES(NULL)
}
end
end
describe
'lock'
do
# This should fail on other databases
it
'adds a lock node'
do
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录