Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
a8a60e92
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
a8a60e92
编写于
11月 19, 2012
作者:
V
Victor Costan
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Postgresql doesn't accepts limits on text columns.
上级
abb38fea
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
35 addition
and
0 deletion
+35
-0
activerecord/CHANGELOG.md
activerecord/CHANGELOG.md
+5
-0
activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb
...ecord/connection_adapters/postgresql/schema_statements.rb
+7
-0
activerecord/test/cases/adapters/postgresql/sql_types_test.rb
...verecord/test/cases/adapters/postgresql/sql_types_test.rb
+18
-0
activerecord/test/schema/postgresql_specific_schema.rb
activerecord/test/schema/postgresql_specific_schema.rb
+5
-0
未找到文件。
activerecord/CHANGELOG.md
浏览文件 @
a8a60e92
## Rails 4.0.0 (unreleased) ##
## Rails 4.0.0 (unreleased) ##
*
When running migrations on Postgresql, the
`:limit`
option for
`binary`
and
`text`
columns is silently dropped.
Previously, these migrations caused sql exceptions, because Postgresql doesn't support limits on these types.
*Victor Costan*
*
Don't change STI type when calling
`ActiveRecord::Base#becomes`
.
*
Don't change STI type when calling
`ActiveRecord::Base#becomes`
.
Add
`ActiveRecord::Base#becomes!`
with the previous behavior.
Add
`ActiveRecord::Base#becomes!`
with the previous behavior.
...
...
activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb
浏览文件 @
a8a60e92
...
@@ -396,6 +396,13 @@ def type_to_sql(type, limit = nil, precision = nil, scale = nil)
...
@@ -396,6 +396,13 @@ def type_to_sql(type, limit = nil, precision = nil, scale = nil)
when
nil
,
0
..
0x3fffffff
;
super
(
type
)
when
nil
,
0
..
0x3fffffff
;
super
(
type
)
else
raise
(
ActiveRecordError
,
"No binary type has byte size
#{
limit
}
."
)
else
raise
(
ActiveRecordError
,
"No binary type has byte size
#{
limit
}
."
)
end
end
when
'text'
# PostgreSQL doesn't support limits on text columns.
# The hard limit is 1Gb, according to section 8.3 in the manual.
case
limit
when
nil
,
0
..
0x3fffffff
;
super
(
type
)
else
raise
(
ActiveRecordError
,
"The limit on text can be at most 1GB - 1byte."
)
end
when
'integer'
when
'integer'
return
'integer'
unless
limit
return
'integer'
unless
limit
...
...
activerecord/test/cases/adapters/postgresql/sql_types_test.rb
0 → 100644
浏览文件 @
a8a60e92
require
"cases/helper"
class
SqlTypesTest
<
ActiveRecord
::
TestCase
def
test_binary_types
assert_equal
'bytea'
,
type_to_sql
(
:binary
,
100_000
)
assert_raise
ActiveRecord
::
ActiveRecordError
do
type_to_sql
:binary
,
4294967295
end
assert_equal
'text'
,
type_to_sql
(
:text
,
100_000
)
assert_raise
ActiveRecord
::
ActiveRecordError
do
type_to_sql
:text
,
4294967295
end
end
def
type_to_sql
(
*
args
)
ActiveRecord
::
Base
.
connection
.
type_to_sql
(
*
args
)
end
end
activerecord/test/schema/postgresql_specific_schema.rb
浏览文件 @
a8a60e92
...
@@ -192,5 +192,10 @@
...
@@ -192,5 +192,10 @@
_SQL
_SQL
rescue
#This version of PostgreSQL either has no XML support or is was not compiled with XML support: skipping table
rescue
#This version of PostgreSQL either has no XML support or is was not compiled with XML support: skipping table
end
end
create_table
:limitless_fields
,
force:
true
do
|
t
|
t
.
binary
:binary
,
limit:
100_000
t
.
text
:text
,
limit:
100_000
end
end
end
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录