Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
a6bc35c8
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
a6bc35c8
编写于
4月 25, 2013
作者:
Z
Zach Ohlgren
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix bug in ActiveRecord::Sanitization#sanitize_sql_hash_for_conditions
Fixing CHANGLOG description Remove extra line. Remove blank lines.
上级
c9e4c9ac
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
15 addition
and
4 deletion
+15
-4
activerecord/CHANGELOG.md
activerecord/CHANGELOG.md
+10
-3
activerecord/lib/active_record/sanitization.rb
activerecord/lib/active_record/sanitization.rb
+1
-1
activerecord/test/cases/sanitize_test.rb
activerecord/test/cases/sanitize_test.rb
+4
-0
未找到文件。
activerecord/CHANGELOG.md
浏览文件 @
a6bc35c8
*
Fixed a bug in ActiveRecord#sanitize_sql_hash_for_conditions in which
`self.class`
is an argument to PredicateBuilder#build_from_hash
causing PredicateBuilder to call non-existant method
Class#reflect_on_association.
*Zach Ohlgren*
*
While removing index if column option is missing then raise IrreversibleMigration exception.
Following code should raise `IrreversibleMigration`. But the code was
...
...
@@ -80,9 +87,9 @@
*
Abort a rake task when missing db/structure.sql like
`db:schema:load`
task.
*kennyj*
*
rake:db:test:prepare falls back to original environment after execution.
*Slava Markevich*
Please check
[
4-0-stable
](
https://github.com/rails/rails/blob/4-0-stable/activerecord/CHANGELOG.md
)
for previous changes.
Please check
[
4-0-stable
](
https://github.com/rails/rails/blob/4-0-stable/activerecord/CHANGELOG.md
)
for previous changes.
\ No newline at end of file
activerecord/lib/active_record/sanitization.rb
浏览文件 @
a6bc35c8
...
...
@@ -89,7 +89,7 @@ def sanitize_sql_hash_for_conditions(attrs, default_table_name = self.table_name
attrs
=
expand_hash_conditions_for_aggregates
(
attrs
)
table
=
Arel
::
Table
.
new
(
table_name
,
arel_engine
).
alias
(
default_table_name
)
PredicateBuilder
.
build_from_hash
(
self
.
class
,
attrs
,
table
).
map
{
|
b
|
PredicateBuilder
.
build_from_hash
(
self
,
attrs
,
table
).
map
{
|
b
|
connection
.
visitor
.
accept
b
}.
join
(
' AND '
)
end
...
...
activerecord/test/cases/sanitize_test.rb
浏览文件 @
a6bc35c8
...
...
@@ -5,6 +5,10 @@ class SanitizeTest < ActiveRecord::TestCase
def
setup
end
def
test_sanitize_sql_hash_handles_associations
assert_equal
"`adorable_animals`.`name` = 'Bambi'"
,
Binary
.
send
(
:sanitize_sql_hash
,
{
adorable_animals:
{
name:
'Bambi'
}})
end
def
test_sanitize_sql_array_handles_string_interpolation
quoted_bambi
=
ActiveRecord
::
Base
.
connection
.
quote_string
(
"Bambi"
)
assert_equal
"name=
#{
quoted_bambi
}
"
,
Binary
.
send
(
:sanitize_sql_array
,
[
"name=%s"
,
"Bambi"
])
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录