Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
a2762d95
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
a2762d95
编写于
5月 10, 2016
作者:
R
Rafael Mendonça França
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Remove deprecated support for status option in head
上级
6c24e47e
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
5 addition
and
28 deletion
+5
-28
actionpack/CHANGELOG.md
actionpack/CHANGELOG.md
+4
-0
actionpack/lib/action_controller/metal/head.rb
actionpack/lib/action_controller/metal/head.rb
+1
-7
actionpack/test/controller/render_test.rb
actionpack/test/controller/render_test.rb
+0
-21
未找到文件。
actionpack/CHANGELOG.md
浏览文件 @
a2762d95
*
Remove deprecated support to passing status as option
`head`
.
*Rafael Mendonça França*
*
Remove deprecated support to passing original exception to
`ActionController::BadRequest`
and the
`ActionController::BadRequest#original_exception`
method.
...
...
actionpack/lib/action_controller/metal/head.rb
浏览文件 @
a2762d95
...
...
@@ -18,13 +18,7 @@ module Head
# See Rack::Utils::SYMBOL_TO_STATUS_CODE for a full list of valid +status+ symbols.
def
head
(
status
,
options
=
{})
if
status
.
is_a?
(
Hash
)
msg
=
status
[
:status
]
?
"The :status option"
:
"The implicit :ok status"
options
,
status
=
status
,
status
.
delete
(
:status
)
ActiveSupport
::
Deprecation
.
warn
(
<<-
MSG
.
squish
)
#{
msg
}
on `head` has been deprecated and will be removed in Rails 5.1.
Please pass the status as a separate parameter before the options, instead.
MSG
raise
ArgumentError
,
"
#{
status
.
inspect
}
is not a valid value for `status`."
end
status
||=
:ok
...
...
actionpack/test/controller/render_test.rb
浏览文件 @
a2762d95
...
...
@@ -173,14 +173,6 @@ def handle_last_modified_and_etags
fresh_when
(
last_modified:
Time
.
now
.
utc
.
beginning_of_day
,
etag:
[
:foo
,
123
])
end
def
head_with_status_hash
head
status: :created
end
def
head_with_hash_does_not_include_status
head
warning: :deprecated
end
def
head_created
head
:created
end
...
...
@@ -670,19 +662,6 @@ def test_head_created
assert_response
:created
end
def
test_passing_hash_to_head_as_first_parameter_deprecated
assert_deprecated
do
get
:head_with_status_hash
end
end
def
test_head_with_default_value_is_deprecated
assert_deprecated
do
get
:head_with_hash_does_not_include_status
assert_response
:ok
end
end
def
test_head_created_with_application_json_content_type
post
:head_created_with_application_json_content_type
assert
@response
.
body
.
blank?
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录