Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
a205bf87
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
a205bf87
编写于
6月 15, 2012
作者:
J
Jon Leighton
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix config.active_record.whitelist_attributes with AR::Model
上级
e030f26a
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
44 addition
and
6 deletion
+44
-6
activerecord/lib/active_record/attribute_assignment.rb
activerecord/lib/active_record/attribute_assignment.rb
+13
-0
activerecord/lib/active_record/railtie.rb
activerecord/lib/active_record/railtie.rb
+0
-3
activerecord/test/cases/mass_assignment_security_test.rb
activerecord/test/cases/mass_assignment_security_test.rb
+27
-0
railties/test/application/configuration_test.rb
railties/test/application/configuration_test.rb
+4
-3
未找到文件。
activerecord/lib/active_record/attribute_assignment.rb
浏览文件 @
a205bf87
require
'active_support/concern'
module
ActiveRecord
ActiveSupport
.
on_load
(
:active_record_config
)
do
mattr_accessor
:whitelist_attributes
,
instance_accessor:
false
end
module
AttributeAssignment
extend
ActiveSupport
::
Concern
include
ActiveModel
::
MassAssignmentSecurity
included
do
attr_accessible
(
nil
)
if
Model
.
whitelist_attributes
end
module
ClassMethods
def
inherited
(
child
)
# :nodoc:
child
.
attr_accessible
(
nil
)
if
Model
.
whitelist_attributes
super
end
private
# The primary key and inheritance column can never be set by mass-assignment for security reasons.
...
...
activerecord/lib/active_record/railtie.rb
浏览文件 @
a205bf87
...
...
@@ -68,9 +68,6 @@ class Railtie < Rails::Railtie
initializer
"active_record.set_configs"
do
|
app
|
ActiveSupport
.
on_load
(
:active_record
)
do
if
app
.
config
.
active_record
.
delete
(
:whitelist_attributes
)
attr_accessible
(
nil
)
end
app
.
config
.
active_record
.
each
do
|
k
,
v
|
send
"
#{
k
}
="
,
v
end
...
...
activerecord/test/cases/mass_assignment_security_test.rb
浏览文件 @
a205bf87
...
...
@@ -251,6 +251,33 @@ def test_protection_against_class_attribute_writers
assert
!
Task
.
new
.
respond_to?
(
"
#{
method
}
="
)
end
end
test
"ActiveRecord::Model.whitelist_attributes works for models which include Model"
do
begin
prev
,
ActiveRecord
::
Model
.
whitelist_attributes
=
ActiveRecord
::
Model
.
whitelist_attributes
,
true
klass
=
Class
.
new
{
include
ActiveRecord
::
Model
}
assert_equal
ActiveModel
::
MassAssignmentSecurity
::
WhiteList
,
klass
.
active_authorizers
[
:default
].
class
assert_equal
[],
klass
.
active_authorizers
[
:default
].
to_a
ensure
ActiveRecord
::
Model
.
whitelist_attributes
=
prev
end
end
test
"ActiveRecord::Model.whitelist_attributes works for models which inherit Base"
do
begin
prev
,
ActiveRecord
::
Model
.
whitelist_attributes
=
ActiveRecord
::
Model
.
whitelist_attributes
,
true
klass
=
Class
.
new
(
ActiveRecord
::
Base
)
assert_equal
ActiveModel
::
MassAssignmentSecurity
::
WhiteList
,
klass
.
active_authorizers
[
:default
].
class
assert_equal
[],
klass
.
active_authorizers
[
:default
].
to_a
klass
.
attr_accessible
'foo'
assert_equal
[
'foo'
],
Class
.
new
(
klass
).
active_authorizers
[
:default
].
to_a
ensure
ActiveRecord
::
Model
.
whitelist_attributes
=
prev
end
end
end
...
...
railties/test/application/configuration_test.rb
浏览文件 @
a205bf87
...
...
@@ -374,9 +374,10 @@ def index
require
"
#{
app_path
}
/config/environment"
assert_equal
ActiveModel
::
MassAssignmentSecurity
::
WhiteList
,
ActiveRecord
::
Base
.
active_authorizers
[
:default
].
class
assert_equal
[],
ActiveRecord
::
Base
.
active_authorizers
[
:default
].
to_a
klass
=
Class
.
new
(
ActiveRecord
::
Base
)
assert_equal
ActiveModel
::
MassAssignmentSecurity
::
WhiteList
,
klass
.
active_authorizers
[
:default
].
class
assert_equal
[],
klass
.
active_authorizers
[
:default
].
to_a
end
test
"registers interceptors with ActionMailer"
do
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录