Merge pull request #29728 from kirs/frozen-activesupport

Use frozen-string-literal in ActiveSupport

.rubocop.yml

@@ -77,6 +77,12 @@ Layout/SpaceBeforeFirstArg:
 Style/MethodDefParentheses:
   Enabled: true
 
+Style/FrozenStringLiteralComment:
+  Enabled: true
+  EnforcedStyle: always
+  Include:
+    - 'activesupport/**/*'
+
 # Use `foo {}` not `foo{}`.
 Layout/SpaceBeforeBlockBraces:
   Enabled: true

activesupport/Rakefile

+# frozen_string_literal: true
 require "rake/testtask"
 
 task default: :test

activesupport/activesupport.gemspec

+# frozen_string_literal: true
 version = File.read(File.expand_path("../RAILS_VERSION", __dir__)).strip
 
 Gem::Specification.new do |s|

activesupport/bin/generate_tables

 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 begin
   $:.unshift(File.expand_path("../lib", __dir__))

activesupport/bin/test

 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 COMPONENT_ROOT = File.expand_path("..", __dir__)
 require_relative "../../tools/test"

activesupport/lib/active_support.rb

+# frozen_string_literal: true
 #--
 # Copyright (c) 2005-2017 David Heinemeier Hansson
 #

activesupport/lib/active_support/all.rb

+# frozen_string_literal: true
 require "active_support"
 require_relative "time"
 require_relative "core_ext"

activesupport/lib/active_support/array_inquirer.rb

+# frozen_string_literal: true
 module ActiveSupport
   # Wrapping an array in an +ArrayInquirer+ gives a friendlier way to check
   # its string-like contents:

activesupport/lib/active_support/backtrace_cleaner.rb

+# frozen_string_literal: true
 module ActiveSupport
   # Backtraces often include many lines that are not relevant for the context
   # under review. This makes it hard to find the signal amongst the backtrace

activesupport/lib/active_support/benchmarkable.rb

+# frozen_string_literal: true
 require_relative "core_ext/benchmark"
 require_relative "core_ext/hash/keys"
 

activesupport/lib/active_support/builder.rb

+# frozen_string_literal: true
 begin
   require "builder"
 rescue LoadError => e

activesupport/lib/active_support/cache.rb

+# frozen_string_literal: true
 require "zlib"
 require_relative "core_ext/array/extract_options"
 require_relative "core_ext/array/wrap"

activesupport/lib/active_support/cache/file_store.rb

+# frozen_string_literal: true
 require_relative "../core_ext/marshal"
 require_relative "../core_ext/file/atomic"
 require_relative "../core_ext/string/conversions"

activesupport/lib/active_support/cache/mem_cache_store.rb

+# frozen_string_literal: true
 begin
   require "dalli"
 rescue LoadError => e

activesupport/lib/active_support/cache/memory_store.rb

+# frozen_string_literal: true
 require "monitor"
 
 module ActiveSupport

activesupport/lib/active_support/cache/null_store.rb

+# frozen_string_literal: true
 module ActiveSupport
   module Cache
     # A cache store implementation which doesn't actually store anything. Useful in

activesupport/lib/active_support/cache/strategy/local_cache.rb

+# frozen_string_literal: true
 require_relative "../../core_ext/object/duplicable"
 require_relative "../../core_ext/string/inflections"
 require_relative "../../per_thread_registry"

activesupport/lib/active_support/cache/strategy/local_cache_middleware.rb

+# frozen_string_literal: true
 require "rack/body_proxy"
 require "rack/utils"
 

activesupport/lib/active_support/callbacks.rb

+# frozen_string_literal: true
 require_relative "concern"
 require_relative "descendants_tracker"
 require_relative "core_ext/array/extract_options"

activesupport/lib/active_support/concern.rb

+# frozen_string_literal: true
 module ActiveSupport
   # A typical module looks like this:
   #

activesupport/lib/active_support/concurrency/share_lock.rb

+# frozen_string_literal: true
 require "thread"
 require "monitor"
 

activesupport/lib/active_support/configurable.rb

+# frozen_string_literal: true
 require_relative "concern"
 require_relative "ordered_options"
 require_relative "core_ext/array/extract_options"

activesupport/lib/active_support/core_ext.rb

+# frozen_string_literal: true
 Dir.glob(File.expand_path("core_ext/*.rb", __dir__)).each do |path|
   require path
 end

activesupport/lib/active_support/core_ext/array.rb

+# frozen_string_literal: true
 require_relative "array/wrap"
 require_relative "array/access"
 require_relative "array/conversions"

activesupport/lib/active_support/core_ext/array/access.rb

+# frozen_string_literal: true
 class Array
   # Returns the tail of the array from +position+.
   #

activesupport/lib/active_support/core_ext/array/conversions.rb

+# frozen_string_literal: true
 require_relative "../../xml_mini"
 require_relative "../hash/keys"
 require_relative "../string/inflections"

activesupport/lib/active_support/core_ext/array/extract_options.rb

+# frozen_string_literal: true
 class Hash
   # By default, only instances of Hash itself are extractable.
   # Subclasses of Hash may implement this method and return

activesupport/lib/active_support/core_ext/array/grouping.rb

+# frozen_string_literal: true
 class Array
   # Splits or iterates over the array in groups of size +number+,
   # padding any remaining slots with +fill_with+ unless it is +false+.

activesupport/lib/active_support/core_ext/array/inquiry.rb

+# frozen_string_literal: true
 require_relative "../../array_inquirer"
 
 class Array

activesupport/lib/active_support/core_ext/array/prepend_and_append.rb

+# frozen_string_literal: true
 class Array
   # The human way of thinking about adding stuff to the end of a list is with append.
   alias_method :append,  :push unless [].respond_to?(:append)

activesupport/lib/active_support/core_ext/array/wrap.rb

+# frozen_string_literal: true
 class Array
   # Wraps its argument in an array unless it is already an array (or array-like).
   #

activesupport/lib/active_support/core_ext/benchmark.rb

+# frozen_string_literal: true
 require "benchmark"
 
 class << Benchmark

activesupport/lib/active_support/core_ext/big_decimal.rb

+# frozen_string_literal: true
 require_relative "big_decimal/conversions"

activesupport/lib/active_support/core_ext/big_decimal/conversions.rb

+# frozen_string_literal: true
 require "bigdecimal"
 require "bigdecimal/util"
 

activesupport/lib/active_support/core_ext/class.rb

+# frozen_string_literal: true
 require_relative "class/attribute"
 require_relative "class/subclasses"

activesupport/lib/active_support/core_ext/class/attribute.rb

+# frozen_string_literal: true
 require_relative "../kernel/singleton_class"
 require_relative "../module/remove_method"
 require_relative "../array/extract_options"

activesupport/lib/active_support/core_ext/class/attribute_accessors.rb

+# frozen_string_literal: true
 # cattr_* became mattr_* aliases in 7dfbd91b0780fbd6a1dd9bfbc176e10894871d2d,
 # but we keep this around for libraries that directly require it knowing they
 # want cattr_*. No need to deprecate.

activesupport/lib/active_support/core_ext/class/subclasses.rb

+# frozen_string_literal: true
 require_relative "../module/anonymous"
 require_relative "../module/reachable"
 

activesupport/lib/active_support/core_ext/date.rb

+# frozen_string_literal: true
 require_relative "date/acts_like"
 require_relative "date/blank"
 require_relative "date/calculations"

activesupport/lib/active_support/core_ext/date/acts_like.rb

+# frozen_string_literal: true
 require_relative "../object/acts_like"
 
 class Date

activesupport/lib/active_support/core_ext/date/blank.rb

+# frozen_string_literal: true
 require "date"
 
 class Date #:nodoc:

activesupport/lib/active_support/core_ext/date/calculations.rb

+# frozen_string_literal: true
 require "date"
 require_relative "../../duration"
 require_relative "../object/acts_like"

activesupport/lib/active_support/core_ext/date/conversions.rb

+# frozen_string_literal: true
 require "date"
 require_relative "../../inflector/methods"
 require_relative "zones"

activesupport/lib/active_support/core_ext/date/zones.rb

+# frozen_string_literal: true
 require "date"
 require_relative "../date_and_time/zones"
 

activesupport/lib/active_support/core_ext/date_and_time/calculations.rb

+# frozen_string_literal: true
 require_relative "../object/try"
 
 module DateAndTime

activesupport/lib/active_support/core_ext/date_and_time/compatibility.rb

+# frozen_string_literal: true
 require_relative "../module/attribute_accessors"
 
 module DateAndTime

activesupport/lib/active_support/core_ext/date_and_time/zones.rb

+# frozen_string_literal: true
 module DateAndTime
   module Zones
     # Returns the simultaneous time in <tt>Time.zone</tt> if a zone is given or

activesupport/lib/active_support/core_ext/date_time.rb

+# frozen_string_literal: true
 require_relative "date_time/acts_like"
 require_relative "date_time/blank"
 require_relative "date_time/calculations"

activesupport/lib/active_support/core_ext/date_time/acts_like.rb

+# frozen_string_literal: true
 require "date"
 require_relative "../object/acts_like"
 

activesupport/lib/active_support/core_ext/date_time/blank.rb

+# frozen_string_literal: true
 require "date"
 
 class DateTime #:nodoc:

activesupport/lib/active_support/core_ext/date_time/calculations.rb

+# frozen_string_literal: true
 require "date"
 
 class DateTime

activesupport/lib/active_support/core_ext/date_time/compatibility.rb

+# frozen_string_literal: true
 require_relative "../date_and_time/compatibility"
 require_relative "../module/remove_method"
 

activesupport/lib/active_support/core_ext/date_time/conversions.rb

+# frozen_string_literal: true
 require "date"
 require_relative "../../inflector/methods"
 require_relative "../time/conversions"

activesupport/lib/active_support/core_ext/digest/uuid.rb

+# frozen_string_literal: true
 require "securerandom"
 
 module Digest

activesupport/lib/active_support/core_ext/enumerable.rb

+# frozen_string_literal: true
 module Enumerable
   # Enumerable#sum was added in Ruby 2.4, but it only works with Numeric elements
   # when we omit an identity.

activesupport/lib/active_support/core_ext/file.rb

+# frozen_string_literal: true
 require_relative "file/atomic"

activesupport/lib/active_support/core_ext/file/atomic.rb

+# frozen_string_literal: true
 require "fileutils"
 
 class File

activesupport/lib/active_support/core_ext/hash.rb

+# frozen_string_literal: true
 require_relative "hash/compact"
 require_relative "hash/conversions"
 require_relative "hash/deep_merge"

activesupport/lib/active_support/core_ext/hash/compact.rb

+# frozen_string_literal: true
 class Hash
   unless Hash.instance_methods(false).include?(:compact)
     # Returns a hash with non +nil+ values.

activesupport/lib/active_support/core_ext/hash/conversions.rb

+# frozen_string_literal: true
 require_relative "../../xml_mini"
 require_relative "../../time"
 require_relative "../object/blank"

activesupport/lib/active_support/core_ext/hash/deep_merge.rb

+# frozen_string_literal: true
 class Hash
   # Returns a new hash with +self+ and +other_hash+ merged recursively.
   #

activesupport/lib/active_support/core_ext/hash/except.rb

+# frozen_string_literal: true
 class Hash
   # Returns a hash that includes everything except given keys.
   #   hash = { a: true, b: false, c: nil }

activesupport/lib/active_support/core_ext/hash/indifferent_access.rb

+# frozen_string_literal: true
 require_relative "../../hash_with_indifferent_access"
 
 class Hash

activesupport/lib/active_support/core_ext/hash/keys.rb

+# frozen_string_literal: true
 class Hash
   # Returns a new hash with all keys converted using the +block+ operation.
   #

activesupport/lib/active_support/core_ext/hash/reverse_merge.rb

+# frozen_string_literal: true
 class Hash
   # Merges the caller into +other_hash+. For example,
   #

activesupport/lib/active_support/core_ext/hash/slice.rb

+# frozen_string_literal: true
 class Hash
   # Slices a hash to include only the given keys. Returns a hash containing
   # the given keys.

activesupport/lib/active_support/core_ext/hash/transform_values.rb

+# frozen_string_literal: true
 class Hash
   # Returns a new hash with the results of running +block+ once for every value.
   # The keys are unchanged.

activesupport/lib/active_support/core_ext/integer.rb

+# frozen_string_literal: true
 require_relative "integer/multiple"
 require_relative "integer/inflections"
 require_relative "integer/time"

activesupport/lib/active_support/core_ext/integer/inflections.rb

+# frozen_string_literal: true
 require_relative "../../inflector"
 
 class Integer

activesupport/lib/active_support/core_ext/integer/multiple.rb

+# frozen_string_literal: true
 class Integer
   # Check whether the integer is evenly divisible by the argument.
   #

activesupport/lib/active_support/core_ext/integer/time.rb

+# frozen_string_literal: true
 require_relative "../../duration"
 require_relative "../numeric/time"
 

activesupport/lib/active_support/core_ext/kernel.rb

+# frozen_string_literal: true
 require_relative "kernel/agnostics"
 require_relative "kernel/concern"
 require_relative "kernel/reporting"

activesupport/lib/active_support/core_ext/kernel/agnostics.rb

+# frozen_string_literal: true
 class Object
   # Makes backticks behave (somewhat more) similarly on all platforms.
   # On win32 `nonexistent_command` raises Errno::ENOENT; on Unix, the

activesupport/lib/active_support/core_ext/kernel/concern.rb

+# frozen_string_literal: true
 require_relative "../module/concerning"
 
 module Kernel

activesupport/lib/active_support/core_ext/kernel/reporting.rb

+# frozen_string_literal: true
 module Kernel
   module_function
 

activesupport/lib/active_support/core_ext/kernel/singleton_class.rb

+# frozen_string_literal: true
 module Kernel
   # class_eval on an object acts like singleton_class.class_eval.
   def class_eval(*args, &block)

activesupport/lib/active_support/core_ext/load_error.rb

+# frozen_string_literal: true
 class LoadError
   REGEXPS = [
     /^no such file to load -- (.+)$/i,

activesupport/lib/active_support/core_ext/marshal.rb

+# frozen_string_literal: true
 module ActiveSupport
   module MarshalWithAutoloading # :nodoc:
     def load(source, proc = nil)

activesupport/lib/active_support/core_ext/module.rb

+# frozen_string_literal: true
 require_relative "module/aliasing"
 require_relative "module/introspection"
 require_relative "module/anonymous"

activesupport/lib/active_support/core_ext/module/aliasing.rb

+# frozen_string_literal: true
 class Module
   # Allows you to make aliases for attributes, which includes
   # getter, setter, and a predicate.

activesupport/lib/active_support/core_ext/module/anonymous.rb

+# frozen_string_literal: true
 class Module
   # A module may or may not have a name.
   #

activesupport/lib/active_support/core_ext/module/attr_internal.rb

+# frozen_string_literal: true
 class Module
   # Declares an attribute reader backed by an internally-named instance variable.
   def attr_internal_reader(*attrs)

activesupport/lib/active_support/core_ext/module/attribute_accessors.rb

+# frozen_string_literal: true
 require_relative "../array/extract_options"
 require_relative "../regexp"
 

activesupport/lib/active_support/core_ext/module/attribute_accessors_per_thread.rb

+# frozen_string_literal: true
 require_relative "../array/extract_options"
 require_relative "../regexp"
 

activesupport/lib/active_support/core_ext/module/concerning.rb

+# frozen_string_literal: true
 require_relative "../../concern"
 
 class Module

activesupport/lib/active_support/core_ext/module/delegation.rb

+# frozen_string_literal: true
 require "set"
 require_relative "../regexp"
 

activesupport/lib/active_support/core_ext/module/deprecation.rb

+# frozen_string_literal: true
 class Module
   #   deprecate :foo
   #   deprecate bar: 'message'

activesupport/lib/active_support/core_ext/module/introspection.rb

+# frozen_string_literal: true
 require_relative "../../inflector"
 
 class Module

activesupport/lib/active_support/core_ext/module/reachable.rb

+# frozen_string_literal: true
 require_relative "anonymous"
 require_relative "../string/inflections"
 

activesupport/lib/active_support/core_ext/module/remove_method.rb

+# frozen_string_literal: true
 class Module
   # Removes the named method, if it exists.
   def remove_possible_method(method)

activesupport/lib/active_support/core_ext/name_error.rb

+# frozen_string_literal: true
 class NameError
   # Extract the name of the missing constant from the exception message.
   #

activesupport/lib/active_support/core_ext/numeric.rb

+# frozen_string_literal: true
 require_relative "numeric/bytes"
 require_relative "numeric/time"
 require_relative "numeric/inquiry"

activesupport/lib/active_support/core_ext/numeric/bytes.rb

+# frozen_string_literal: true
 class Numeric
   KILOBYTE = 1024
   MEGABYTE = KILOBYTE * 1024

activesupport/lib/active_support/core_ext/numeric/conversions.rb

+# frozen_string_literal: true
 require_relative "../big_decimal/conversions"
 require_relative "../../number_helper"
 require_relative "../module/deprecation"

activesupport/lib/active_support/core_ext/numeric/inquiry.rb

+# frozen_string_literal: true
 unless 1.respond_to?(:positive?) # TODO: Remove this file when we drop support to ruby < 2.3
   class Numeric
     # Returns true if the number is positive.

activesupport/lib/active_support/core_ext/numeric/time.rb

+# frozen_string_literal: true
 require_relative "../../duration"
 require_relative "../time/calculations"
 require_relative "../time/acts_like"

activesupport/lib/active_support/core_ext/object.rb

+# frozen_string_literal: true
 require_relative "object/acts_like"
 require_relative "object/blank"
 require_relative "object/duplicable"

activesupport/lib/active_support/core_ext/object/acts_like.rb

+# frozen_string_literal: true
 class Object
   # A duck-type assistant method. For example, Active Support extends Date
   # to define an <tt>acts_like_date?</tt> method, and extends Time to define

activesupport/lib/active_support/core_ext/object/blank.rb

+# frozen_string_literal: true
 require_relative "../regexp"
 
 class Object

activesupport/lib/active_support/core_ext/object/conversions.rb

+# frozen_string_literal: true
 require_relative "to_param"
 require_relative "to_query"
 require_relative "../array/conversions"