Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
8afa8b0c
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
8afa8b0c
编写于
1月 30, 2012
作者:
K
kennyj
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix GH #4737. Missing helper file (LoadError) in mountable plugin.
上级
d2c64009
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
11 addition
and
8 deletion
+11
-8
railties/lib/rails/generators/rails/plugin_new/plugin_new_generator.rb
...rails/generators/rails/plugin_new/plugin_new_generator.rb
+3
-1
railties/test/generators/plugin_new_generator_test.rb
railties/test/generators/plugin_new_generator_test.rb
+8
-7
未找到文件。
railties/lib/rails/generators/rails/plugin_new/plugin_new_generator.rb
浏览文件 @
8afa8b0c
...
...
@@ -285,7 +285,9 @@ def camelized
end
def
valid_const?
if
camelized
=~
/^\d/
if
original_name
=~
/[^0-9a-zA-Z_]+/
raise
Error
,
"Invalid plugin name
#{
original_name
}
. Please give a name which use only alphabetic or numeric or
\"
_
\"
characters."
elsif
camelized
=~
/^\d/
raise
Error
,
"Invalid plugin name
#{
original_name
}
. Please give a name which does not start with numbers."
elsif
RESERVED_NAMES
.
include?
(
name
)
raise
Error
,
"Invalid plugin name
#{
original_name
}
. Please give a name which does not match one of the reserved rails words."
...
...
railties/test/generators/plugin_new_generator_test.rb
浏览文件 @
8afa8b0c
...
...
@@ -27,13 +27,14 @@ class PluginNewGeneratorTest < Rails::Generators::TestCase
include
SharedGeneratorTests
def
test_invalid_plugin_name_raises_an_error
content
=
capture
(
:stderr
){
run_generator
[
File
.
join
(
destination_root
,
"43-things"
)]
}
assert_equal
"Invalid plugin name 43-things. Please give a name which does not start with numbers.
\n
"
,
content
end
def
test_invalid_plugin_name_is_fixed
run_generator
[
File
.
join
(
destination_root
,
"things-43"
)]
assert_file
"things-43/lib/things-43.rb"
,
/module Things43/
content
=
capture
(
:stderr
){
run_generator
[
File
.
join
(
destination_root
,
"things-43"
)]
}
assert_equal
"Invalid plugin name things-43. Please give a name which use only alphabetic or numeric or
\"
_
\"
characters.
\n
"
,
content
content
=
capture
(
:stderr
){
run_generator
[
File
.
join
(
destination_root
,
"things4.3"
)]
}
assert_equal
"Invalid plugin name things4.3. Please give a name which use only alphabetic or numeric or
\"
_
\"
characters.
\n
"
,
content
content
=
capture
(
:stderr
){
run_generator
[
File
.
join
(
destination_root
,
"43things"
)]
}
assert_equal
"Invalid plugin name 43things. Please give a name which does not start with numbers.
\n
"
,
content
end
def
test_camelcase_plugin_name_underscores_filenames
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录