Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
8a39f411
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
8a39f411
编写于
8月 16, 2011
作者:
A
Aaron Patterson
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
prevent sql injection attacks by escaping quotes in column names
上级
b0555bb8
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
20 addition
and
3 deletion
+20
-3
activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb
...d/lib/active_record/connection_adapters/mysql2_adapter.rb
+1
-1
activerecord/lib/active_record/connection_adapters/mysql_adapter.rb
...rd/lib/active_record/connection_adapters/mysql_adapter.rb
+1
-1
activerecord/lib/active_record/connection_adapters/sqlite_adapter.rb
...d/lib/active_record/connection_adapters/sqlite_adapter.rb
+1
-1
activerecord/test/cases/base_test.rb
activerecord/test/cases/base_test.rb
+17
-0
未找到文件。
activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb
浏览文件 @
8a39f411
...
@@ -169,7 +169,7 @@ def quote(value, column = nil)
...
@@ -169,7 +169,7 @@ def quote(value, column = nil)
end
end
def
quote_column_name
(
name
)
#:nodoc:
def
quote_column_name
(
name
)
#:nodoc:
@quoted_column_names
[
name
]
||=
"`
#{
name
}
`"
@quoted_column_names
[
name
]
||=
"`
#{
name
.
to_s
.
gsub
(
'`'
,
'``'
)
}
`"
end
end
def
quote_table_name
(
name
)
#:nodoc:
def
quote_table_name
(
name
)
#:nodoc:
...
...
activerecord/lib/active_record/connection_adapters/mysql_adapter.rb
浏览文件 @
8a39f411
...
@@ -250,7 +250,7 @@ def type_cast(value, column)
...
@@ -250,7 +250,7 @@ def type_cast(value, column)
end
end
def
quote_column_name
(
name
)
#:nodoc:
def
quote_column_name
(
name
)
#:nodoc:
@quoted_column_names
[
name
]
||=
"`
#{
name
}
`"
@quoted_column_names
[
name
]
||=
"`
#{
name
.
to_s
.
gsub
(
'`'
,
'``'
)
}
`"
end
end
def
quote_table_name
(
name
)
#:nodoc:
def
quote_table_name
(
name
)
#:nodoc:
...
...
activerecord/lib/active_record/connection_adapters/sqlite_adapter.rb
浏览文件 @
8a39f411
...
@@ -148,7 +148,7 @@ def quote_string(s) #:nodoc:
...
@@ -148,7 +148,7 @@ def quote_string(s) #:nodoc:
end
end
def
quote_column_name
(
name
)
#:nodoc:
def
quote_column_name
(
name
)
#:nodoc:
%Q("
#{
name
}
")
%Q("
#{
name
.
to_s
.
gsub
(
'"'
,
'""'
)
}
")
end
end
# Quote date/time values for use in SQL input. Includes microseconds
# Quote date/time values for use in SQL input. Includes microseconds
...
...
activerecord/test/cases/base_test.rb
浏览文件 @
8a39f411
...
@@ -67,6 +67,23 @@ def setup
...
@@ -67,6 +67,23 @@ def setup
class
BasicsTest
<
ActiveRecord
::
TestCase
class
BasicsTest
<
ActiveRecord
::
TestCase
fixtures
:topics
,
:companies
,
:developers
,
:projects
,
:computers
,
:accounts
,
:minimalistics
,
'warehouse-things'
,
:authors
,
:categorizations
,
:categories
,
:posts
fixtures
:topics
,
:companies
,
:developers
,
:projects
,
:computers
,
:accounts
,
:minimalistics
,
'warehouse-things'
,
:authors
,
:categorizations
,
:categories
,
:posts
def
test_column_names_are_escaped
conn
=
ActiveRecord
::
Base
.
connection
classname
=
conn
.
class
.
name
[
/[^:]*$/
]
badchar
=
{
'SQLite3Adapter'
=>
'"'
,
'MysqlAdapter'
=>
'`'
,
'Mysql2Adapter'
=>
'`'
,
'PostgreSQLAdapter'
=>
'"'
,
'OracleAdapter'
=>
'"'
,
}.
fetch
(
classname
)
{
raise
"need a bad char for
#{
classname
}
"
}
quoted
=
conn
.
quote_column_name
"foo
#{
badchar
}
bar"
assert_equal
(
"
#{
badchar
}
foo
#{
badchar
*
2
}
bar
#{
badchar
}
"
,
quoted
)
end
def
test_columns_should_obey_set_primary_key
def
test_columns_should_obey_set_primary_key
pk
=
Subscriber
.
columns
.
find
{
|
x
|
x
.
name
==
'nick'
}
pk
=
Subscriber
.
columns
.
find
{
|
x
|
x
.
name
==
'nick'
}
assert
pk
.
primary
,
'nick should be primary key'
assert
pk
.
primary
,
'nick should be primary key'
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录