提交 7f6e7ba1 编写于 作者: E Ernie Miller 提交者: Michael Koziarski

Fixed AssociationCollection#<< resulting in unexpected values in @target when :uniq => true

Signed-off-by: NMichael Koziarski <michael@koziarski.com>
上级 06e4eb49
...@@ -344,7 +344,7 @@ def add_record_to_target_with_callbacks(record) ...@@ -344,7 +344,7 @@ def add_record_to_target_with_callbacks(record)
callback(:before_add, record) callback(:before_add, record)
yield(record) if block_given? yield(record) if block_given?
@target ||= [] unless loaded? @target ||= [] unless loaded?
@target << record @target << record unless @reflection.options[:uniq] && @target.include?(record)
callback(:after_add, record) callback(:after_add, record)
record record
end end
......
...@@ -299,6 +299,17 @@ def test_uniq_before_the_fact ...@@ -299,6 +299,17 @@ def test_uniq_before_the_fact
assert_equal 3, projects(:active_record, :reload).developers.size assert_equal 3, projects(:active_record, :reload).developers.size
end end
def test_uniq_option_prevents_duplicate_push
project = projects(:active_record)
project.developers << developers(:jamis)
project.developers << developers(:david)
assert_equal 3, project.developers.size
project.developers << developers(:david)
project.developers << developers(:jamis)
assert_equal 3, project.developers.size
end
def test_deleting def test_deleting
david = Developer.find(1) david = Developer.find(1)
active_record = Project.find(1) active_record = Project.find(1)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册