Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
7caea98e
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
7caea98e
编写于
2月 05, 2019
作者:
G
Gannon McGibbon
浏览文件
操作
浏览文件
下载
差异文件
Merge branch 'float_dom_ids'
Closes #34975.
上级
deca8c52
f8696b88
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
27 addition
and
5 deletion
+27
-5
actionview/CHANGELOG.md
actionview/CHANGELOG.md
+6
-0
actionview/lib/action_view/helpers/tags/base.rb
actionview/lib/action_view/helpers/tags/base.rb
+1
-1
actionview/test/template/form_collections_helper_test.rb
actionview/test/template/form_collections_helper_test.rb
+20
-4
未找到文件。
actionview/CHANGELOG.md
浏览文件 @
7caea98e
*
Ensure unique DOM IDs for collection inputs with float values.
Fixes #34974
*Mark Edmondson*
## Rails 6.0.0.beta1 (January 18, 2019) ##
*
[
Rename npm package
](
https://github.com/rails/rails/pull/34905
)
from
...
...
actionview/lib/action_view/helpers/tags/base.rb
浏览文件 @
7caea98e
...
...
@@ -138,7 +138,7 @@ def sanitized_method_name
end
def
sanitized_value
(
value
)
value
.
to_s
.
gsub
(
/
\s
/
,
"_"
).
gsub
(
/[^-[[:word:]]]/
,
""
).
mb_chars
.
downcase
.
to_s
value
.
to_s
.
gsub
(
/
[\s\.]
/
,
"_"
).
gsub
(
/[^-[[:word:]]]/
,
""
).
mb_chars
.
downcase
.
to_s
end
def
select_content_tag
(
option_tags
,
options
,
html_options
)
...
...
actionview/test/template/form_collections_helper_test.rb
浏览文件 @
7caea98e
...
...
@@ -48,8 +48,16 @@ def with_collection_check_boxes(*args, &block)
test
"collection radio should sanitize collection values for labels correctly"
do
with_collection_radio_buttons
:user
,
:name
,
[
"$0.99"
,
"$1.99"
],
:to_s
,
:to_s
assert_select
"label[for=user_name_099]"
,
"$0.99"
assert_select
"label[for=user_name_199]"
,
"$1.99"
assert_select
"label[for=user_name_0_99]"
,
"$0.99"
assert_select
"label[for=user_name_1_99]"
,
"$1.99"
end
test
"collection radio correctly builds unique DOM IDs for float values"
do
with_collection_radio_buttons
:user
,
:name
,
[
1.0
,
10
],
:to_s
,
:to_s
assert_select
"label[for=user_name_1_0]"
,
"1.0"
assert_select
"label[for=user_name_10]"
,
"10"
assert_select
'input#user_name_1_0[type=radio][value="1.0"]'
assert_select
'input#user_name_10[type=radio][value="10"]'
end
test
"collection radio accepts checked item"
do
...
...
@@ -302,8 +310,16 @@ def with_collection_check_boxes(*args, &block)
test
"collection check box should sanitize collection values for labels correctly"
do
with_collection_check_boxes
:user
,
:name
,
[
"$0.99"
,
"$1.99"
],
:to_s
,
:to_s
assert_select
"label[for=user_name_099]"
,
"$0.99"
assert_select
"label[for=user_name_199]"
,
"$1.99"
assert_select
"label[for=user_name_0_99]"
,
"$0.99"
assert_select
"label[for=user_name_1_99]"
,
"$1.99"
end
test
"collection check boxes correctly builds unique DOM IDs for float values"
do
with_collection_check_boxes
:user
,
:name
,
[
1.0
,
10
],
:to_s
,
:to_s
assert_select
"label[for=user_name_1_0]"
,
"1.0"
assert_select
"label[for=user_name_10]"
,
"10"
assert_select
'input#user_name_1_0[type=checkbox][value="1.0"]'
assert_select
'input#user_name_10[type=checkbox][value="10"]'
end
test
"collection check boxes generates labels for non-English values correctly"
do
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录