Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
7a1c00d4
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
7a1c00d4
编写于
4月 25, 2017
作者:
R
Rafael França
提交者:
GitHub
4月 25, 2017
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #28872 from eugeneius/enumerator_size
Remove checks for Enumerator#size method
上级
b32d64df
90f851a1
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
14 addition
and
22 deletion
+14
-22
activerecord/test/cases/batches_test.rb
activerecord/test/cases/batches_test.rb
+10
-14
activerecord/test/cases/result_test.rb
activerecord/test/cases/result_test.rb
+2
-4
activesupport/test/core_ext/enumerable_test.rb
activesupport/test/core_ext/enumerable_test.rb
+2
-4
未找到文件。
activerecord/test/cases/batches_test.rb
浏览文件 @
7a1c00d4
...
...
@@ -35,12 +35,10 @@ def test_each_should_return_an_enumerator_if_no_block_is_present
end
end
if
Enumerator
.
method_defined?
:size
def
test_each_should_return_a_sized_enumerator
assert_equal
11
,
Post
.
find_each
(
batch_size:
1
).
size
assert_equal
5
,
Post
.
find_each
(
batch_size:
2
,
start:
7
).
size
assert_equal
11
,
Post
.
find_each
(
batch_size:
10_000
).
size
end
def
test_each_should_return_a_sized_enumerator
assert_equal
11
,
Post
.
find_each
(
batch_size:
1
).
size
assert_equal
5
,
Post
.
find_each
(
batch_size:
2
,
start:
7
).
size
assert_equal
11
,
Post
.
find_each
(
batch_size:
10_000
).
size
end
def
test_each_enumerator_should_execute_one_query_per_batch
...
...
@@ -515,14 +513,12 @@ def test_in_batches_relations_update_all_should_not_affect_matching_records_in_o
assert_equal
2
,
person
.
reload
.
author_id
# incremented only once
end
if
Enumerator
.
method_defined?
:size
def
test_find_in_batches_should_return_a_sized_enumerator
assert_equal
11
,
Post
.
find_in_batches
(
batch_size:
1
).
size
assert_equal
6
,
Post
.
find_in_batches
(
batch_size:
2
).
size
assert_equal
4
,
Post
.
find_in_batches
(
batch_size:
2
,
start:
4
).
size
assert_equal
4
,
Post
.
find_in_batches
(
batch_size:
3
).
size
assert_equal
1
,
Post
.
find_in_batches
(
batch_size:
10_000
).
size
end
def
test_find_in_batches_should_return_a_sized_enumerator
assert_equal
11
,
Post
.
find_in_batches
(
batch_size:
1
).
size
assert_equal
6
,
Post
.
find_in_batches
(
batch_size:
2
).
size
assert_equal
4
,
Post
.
find_in_batches
(
batch_size:
2
,
start:
4
).
size
assert_equal
4
,
Post
.
find_in_batches
(
batch_size:
3
).
size
assert_equal
1
,
Post
.
find_in_batches
(
batch_size:
10_000
).
size
end
[
true
,
false
].
each
do
|
load
|
...
...
activerecord/test/cases/result_test.rb
浏览文件 @
7a1c00d4
...
...
@@ -45,10 +45,8 @@ def result
end
end
if
Enumerator
.
method_defined?
:size
test
"each without block returns a sized enumerator"
do
assert_equal
3
,
result
.
each
.
size
end
test
"each without block returns a sized enumerator"
do
assert_equal
3
,
result
.
each
.
size
end
test
"cast_values returns rows after type casting"
do
...
...
activesupport/test/core_ext/enumerable_test.rb
浏览文件 @
7a1c00d4
...
...
@@ -171,10 +171,8 @@ def test_index_by
assert_equal
({
5
=>
Payment
.
new
(
5
),
15
=>
Payment
.
new
(
15
),
10
=>
Payment
.
new
(
10
)
},
payments
.
index_by
(
&
:price
))
assert_equal
Enumerator
,
payments
.
index_by
.
class
if
Enumerator
.
method_defined?
:size
assert_nil
payments
.
index_by
.
size
assert_equal
42
,
(
1
..
42
).
index_by
.
size
end
assert_nil
payments
.
index_by
.
size
assert_equal
42
,
(
1
..
42
).
index_by
.
size
assert_equal
({
5
=>
Payment
.
new
(
5
),
15
=>
Payment
.
new
(
15
),
10
=>
Payment
.
new
(
10
)
},
payments
.
index_by
.
each
(
&
:price
))
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录