pass the outer joins to join_constraints

activerecord/lib/active_record/associations/join_dependency.rb

@@ -84,7 +84,8 @@ def apply_tables!(node)
         node.children.each { |child| construct_tables! node, child }
       end
 
-      def join_constraints
+      def join_constraints(outer_joins)
+        outer_joins.each { |oj| merge_outer_joins! oj }
         make_joins join_root
       end
 

activerecord/lib/active_record/relation/query_methods.rb

@@ -950,11 +950,7 @@ def build_joins(manager, joins)
         join_list
       )
 
-      stashed_association_joins.each do |dep|
-        join_dependency.merge_outer_joins! dep
-      end
-
-      joins = join_dependency.join_constraints
+      joins = join_dependency.join_constraints stashed_association_joins
 
       joins.each { |join| manager.from(join) }