Merge pull request #24889 from lvl0nax/as_array_split_refactoring

Array#split refactoring for case with block

activesupport/lib/active_support/core_ext/array/grouping.rb

@@ -89,24 +89,19 @@ def in_groups(number, fill_with = nil)
   #   [1, 2, 3, 4, 5].split(3)              # => [[1, 2], [4, 5]]
   #   (1..10).to_a.split { |i| i % 3 == 0 } # => [[1, 2], [4, 5], [7, 8], [10]]
   def split(value = nil)
+    arr = self.dup
+    result = []
     if block_given?
-      inject([[]]) do |results, element|
-        if yield(element)
-          results << []
-        else
-          results.last << element
-        end
-
-        results
+      while (idx = arr.index { |i| yield i })
+        result << arr.shift(idx)
+        arr.shift
       end
     else
-      arr = self.dup
-      result = []
       while (idx = arr.index(value))
         result << arr.shift(idx)
         arr.shift
       end
-      result << arr
     end
+    result << arr
   end
 end